From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C308188929; Wed, 9 Oct 2024 09:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728465684; cv=none; b=N2fFpiwtu+mw71jQtnkLglHzPCUnkExhjxNzpC17A4F3iru6Qz9r6ADRszkEcfjtVfMZ/iBy9A3JjPJO8OPk2gEbPlzYIvbGMGJ6eAFf8pKwZMd+pdj1VhcMZ9bcc1IjfPv7epajhOdNerq0x35taA79viWddkQavOvU/s1grb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728465684; c=relaxed/simple; bh=5rJacYbHgJtDxtv3PNAGVx97A2TLXEf8FNd4ufMljKU=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=RwF4JWvdrahn9JUM41XfbmJ9jzc3pzMpnd8HVtBPOPhxXW9XvPUF4fsoy1fhTGpbpZGlHUmfoYAkGsVtUyrGTsh1k/xjhLqg/uKFh1tkSwJEs43G41Tq3qjvzPi8AAQVJJKma0aaPRSIgb3ArGmgcjEt6/4GnJwyDfyr5FmL8/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=F8WlZO7v; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="F8WlZO7v" X-UUID: d6e3ad88861f11ef8b96093e013ec31c-20241009 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=x/5+Sddg3H+O4oysQuhNA4Lmgxc5WiB96rQ7dFLcGlc=; b=F8WlZO7vFeQpo70sDfkUfQYtNG+x4NobK5oN1NWw0Cr3XJuWaIw3ldBESMCXVPwHdUjQIG3Dcz9Tm9gJcOtAzN5FlXNxyJUpOPz/ThtfpCF4If9zMjYcZ/w5UYuPNSj5OwTqIp04JUoXHFmy2Yjf5zTyUochgRpEyYQMk+1AOxQ=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:9ccd4a46-aa9d-466c-9708-f35890c5ed6c,IP:0,U RL:0,TC:0,Content:1,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:1 X-CID-META: VersionHash:6dc6a47,CLOUDID:59318826-5902-4533-af4f-d0904aa89b3c,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:4|-5,EDM:-3,IP:ni l,URL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_ULS,TF_CID_SPAM_SNR X-UUID: d6e3ad88861f11ef8b96093e013ec31c-20241009 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1547505070; Wed, 09 Oct 2024 17:21:17 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 9 Oct 2024 17:21:15 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 9 Oct 2024 17:21:14 +0800 Message-ID: <314aafed-5903-2478-971f-59870b8ac5fa@mediatek.com> Date: Wed, 9 Oct 2024 17:21:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Content-Language: en-US To: AngeloGioacchino Del Regno , "Rob Herring" , Krzysztof Kozlowski , "Conor Dooley" , Matthias Brugger , , , , , Seiya Wang , Tinghan Shen , Chunfeng Yun , Alexandre Mergnat , Jian Yang , Jianguo Zhang , "Jieyy Yang" CC: Bear Wang , Pablo Sun , Macpaul Lin , Sen Chu , "Chris-qj chen" , MediaTek Chromebook Upstream , Chen-Yu Tsai References: <20241008071540.32607-1-macpaul.lin@mediatek.com> From: Macpaul Lin In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--15.120500-8.000000 X-TMASE-MatchedRID: VfovoVrt/oYNtKv7cnNXnSa1MaKuob8PofZV/2Xa0cK+UkTh6A/Dwdno quRwHY3BkAluVYknZHpbzVVgo9RtXiA1dgOjatGGXP5rFAucBUHnpmIrKZRxTs/PM4nfEDArIyZ NTlgT7qnRLHyi43Gvn5VYfV6rzvhfRyV3gdKbiKMpa6LJktEjgPaS52LUPfcSUUVrdcYJZJ0sgd kHScxUMWUQAwDxYVxG1S+wyEMlXe8HTXUunEyzWGwbuvhCHs3cfLPKYyLDlAffUZT83lbkEBHxr RblSw8bLPQ+pa7MIVkfZdczzDm/ur9ZdlL8eonaVnRXm1iHN1bEQdG7H66TyH4gKq42LRYkUK59 MjR9wrsi5A4ICRHaqPCJJCAkXsc/RHeQpqAFdaB+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.120500-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 62E55BFEEA33CD37E8BF54AEA8EB2CAABBF29006B944BE04D6245EF911B536242000:8 On 10/8/24 17:09, AngeloGioacchino Del Regno wrote: > Il 08/10/24 09:15, Macpaul Lin ha scritto: >> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error. >> The error message was: >>    t-phy@11e30000: 'power-domains' does not match any of the regexes: >>      '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+' >> Fix this issue by dropping 'power-domains' of u3phy1 node. >> >> This is because MediaTek tphy dose not need to add mtcmos.  It is not >> necessary to add 'power-domains'. If the power of the tphy is turned off, >> it will affect other functions. From the current USB hardware design >> perspective, even if mtcmos is added to the phy, it is always on. >> >> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and >> evaluation board") >> Signed-off-by: Macpaul Lin > > Reviewed-by: AngeloGioacchino Del Regno > Sorry for bothering, it seems MediaTek internal still have some discussion about according to Conor's suggestion: [1] https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6 Please don't to pick this patch until if MediaTek could have some conclusions. >> --- >>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 - >>   1 file changed, 1 deletion(-) >> >> Changes for v2: >>   - Add detail description of the tphy design for explaining the reason >>     of this change. >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> index ade685ed2190..1c6f08dde31c 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 { >>               #address-cells = <1>; >>               #size-cells = <1>; >>               ranges = <0 0 0x11e30000 0xe00>; >> -            power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>; >>               status = "disabled"; >>               u2port1: usb-phy@0 { > > Thanks! Macpaul Lin