From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>,
Vladimir Zapolskiy <vz@mleia.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: s5p-sss - use unregister_{ahashes,skciphers} in probe/remove
Date: Thu, 19 Mar 2026 17:55:07 +0100 [thread overview]
Message-ID: <314ab59a-3958-4f7f-bd7c-2b6ac8c8e3cb@kernel.org> (raw)
In-Reply-To: <20260317080450.1054742-3-thorsten.blum@linux.dev>
On 17/03/2026 09:04, Thorsten Blum wrote:
> Replace multiple for loops with calls to crypto_unregister_ahashes() and
> crypto_unregister_skciphers().
>
> If crypto_register_skcipher() fails in s5p_aes_probe(), log the error
> directly instead of checking 'i < ARRAY_SIZE(algs)' later. Also drop
> now-unused local index variables. No functional changes.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/crypto/s5p-sss.c | 27 ++++++++++-----------------
> 1 file changed, 10 insertions(+), 17 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-19 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 8:04 Thorsten Blum
2026-03-19 16:55 ` Krzysztof Kozlowski [this message]
2026-03-19 20:02 ` Vladimir Zapolskiy
2026-03-27 10:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=314ab59a-3958-4f7f-bd7c-2b6ac8c8e3cb@kernel.org \
--to=krzk@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®