From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233162FCC13 for ; Wed, 19 Nov 2025 20:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763582751; cv=none; b=I2hcIsSgc1PCpbuq3zXvHkv5jcHLzMXsAilRpOss2AhMWfjO0TnA50t6sHra60QxUL2OWmgPyrGVIIyww1ldJoiX22PI9F3n1PGjdKbuN2kIPyzJlPzegGYac6ZHwc5s2zkGEyf730ogT3YDE81M1AE7Lz9fwgtbSFE78o+GlCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763582751; c=relaxed/simple; bh=Edvp/r0H+9qfQH3ylHtC4AsmZDbZWW2Dbdj7gUdVW2s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g0uGj+YlS+gO+NEImEbfCSD5ToDf2DY563gxLbhKX1LcJqZxYDH1Kq3xhyRtXS9+MNSBNn+y2+sbiDU/liAnx1riRqPnr4iV/KVcL4QWu4qjxwYC9qmcpL4AyvkvxWHQ9UrY2xJUowqOlgVRaXnGQ3V9/nOziqqm6uul3XG2h5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GTE0xQdz; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GTE0xQdz" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-9491ba846b2so3807339f.2 for ; Wed, 19 Nov 2025 12:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1763582747; x=1764187547; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+HLe7CUVAdln3tUOoLTiQQTktKzCo7GVaO9dJqNiMNo=; b=GTE0xQdzCzJWfcPInF3KF+d2VmEC575AQJ3yCAJLqWwesTmc4CQXBzzBNvRBrAoD+9 yQF9jg364Uh4YfCkCSMHpnqma7SS6eLjSGdJGclajrmHhEZewcQKpK4A2B6LeYhuxXZ+ wplHjZNno0Rt6OYzwdPS92duBj0F8LzHk3aIw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763582747; x=1764187547; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+HLe7CUVAdln3tUOoLTiQQTktKzCo7GVaO9dJqNiMNo=; b=SOu/E5KmgWepvwKjKIqF0cDm2wiQjC5odu7Z1MCyQdlBCGTJth0pH8cktmo4oobvLb V3MVHv7vi3bEMLVfaDaXeHtd39WEEZADxEyvMzzGUlgVPlRXm1BCOBAoAjA9YxRx6+dW 5a8CwlAXQ6cDC1ujUU9NuThLFGlmmruusEWkXQhujm+UxVFmNwoNgUcxeEt1dpQm6WBt WZZ2pD1hC9NEg4cLEzRq7hJEr5dN+lSVueNbPm8Zq4njASrRIldKb5qp1cdX1inbv7N7 vC71RnbMzENCjpZuAn2TY/WdFATasUGzpsp9qsb5qUOl1cr9pYNZf1GlogyR4llVBcpU +NJQ== X-Forwarded-Encrypted: i=1; AJvYcCXzpqvs8c6tFSThFK6BMTG8PO6YezcrIAs3FHhwncbHVoVyNVqfPhYra6pVSqtZ8ylCELguSSbsQyglW6A=@vger.kernel.org X-Gm-Message-State: AOJu0YwMzumEpuxeZ8F7i3WWIUg/rUBqUx8D5zY6IecI8Vpkqs7kYsyB riTh3xZ+OrtvfH81pDMijZZC63qxGaoyPBfVYBEWA12R4iL4tEVDz9iWHQk3LVBlGLs= X-Gm-Gg: ASbGncu5vd0COaGGRZadspEhyPI9Kvu4uX0RNsvbB4lA0bLXUV2ahte4D9U+uqdydIr yS4VmGlYiD4fbwLD0fzbzBUiV2SJLXuEFejQVY+EC2lMMP0P9aROgJCZxRg+/hgW4hkDZmMwnOj qhUkvXQ/DY6CMxdjNdnaZKfpaV9apV9Dx9JrWRAmVXsuOvJ14Sc1PemiU1rHsRaXhQlzxU0jp6c Bz3mREnPwEGYuQiAWkP2rjalR13HVrVe46kBkQ+Gpjl4eIenvGIpt869yAvvvVXql91BfOl8qRr r6sOTY4ML0DF9vV4FAuhgWkVTrRPHQ5A+rXM7xIxihqCQ/4d48MfNV24uOJIxh8+UYM+iPJvTeT 12a8VC6apydy1Yh/ypCkHkkMyLUFNWU7VxBulvZt2E5q5knjmpuxFYoOSde9IA98xSdyJp/CfnJ ZMaHDB7fm3lBt4zXdcWL6uU3CDyTpGYm9mFw== X-Google-Smtp-Source: AGHT+IHqpTx1fCKJCoUMk5o0n7baQ5DxxYVyZrm30vno6Hi1Mjg+zbIFcxjnPPnVBFu4ospwA0PQfg== X-Received: by 2002:a05:6638:63d1:b0:5b7:115a:36b5 with SMTP id 8926c6da1cb9f-5b95419f4d6mr492657173.19.1763582746671; Wed, 19 Nov 2025 12:05:46 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5b954b59576sm86074173.57.2025.11.19.12.05.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 12:05:46 -0800 (PST) Message-ID: <3150f8ed-5de4-48fa-a6ac-136b07955235@linuxfoundation.org> Date: Wed, 19 Nov 2025 13:05:45 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: vimc: add RGB/YUV input entity implementation To: opensource india Cc: kieran.bingham@ideasonboard.com, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20251101052651.6197-1-opensource206@gmail.com> <959ac74b-a8b7-4d4e-9d34-3b3d971f9f8a@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/6/25 22:02, opensource india wrote: > On Fri, Nov 7, 2025 at 5:41 AM Shuah Khan wrote: >> >> On 11/5/25 22:03, opensource india wrote: >>> Hi Shuah, >>> >>> On Wed, Nov 5, 2025 at 10:43 PM Shuah Khan wrote: >>>> >>>> On 10/31/25 23:26, Pavan Bobba wrote: >>>>> Introduce a new vimc-input entity to simulate a color frame source in the >>>>> Virtual Media Controller (VIMC) pipeline. This entity outputs RGB888 frames >>>>> and allows testing of pipelines that start from a pre-processed RGB/YUV >>>>> source instead of a raw Bayer sensor. >>>>> >>>>> The patch adds vimc-input.c with basic pad operations for format >>>>> enumeration, get/set, and stream enable/disable handlers. The entity is >>>>> registered in the VIMC core configuration, replacing the previous temporary >>>>> use of vimc-sensor. Frame generation is not yet implemented and remains a >>>>> TODO for future work. >>>>> >>>>> This change enables link validation and format negotiation for the >>>>> RGB/YUV input path, paving the way for software frame injection and >>>>> test-pattern generation. >>>>> >>>>> Signed-off-by: Pavan Bobba >>>> >>>> I see 4 patches - are they dependent then gerenrate a sries >>>> with cover letter explaining the changes you are making. >>>> >>>> thanks, >>>> -- Shuah >>> >>> even though all 4 patches are part of vimc driver, >>> these are independent patches >> >> Independent in the sense that they can be applied and tested >> independently? > > Yes. all 4 patches can be applied and test independently > Sorry for the delay - these four patches especially this one add new features/functionality to to vimc. These require updates - Documentation/admin-guide/media/vimc.rst Please include the documentation patch - please send these as series 4 patches + doc patch as a series. The changes look okay to me. thanks, -- Shuah