From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D54C7EE24 for ; Mon, 8 May 2023 17:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230414AbjEHRTG (ORCPT ); Mon, 8 May 2023 13:19:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233235AbjEHRS7 (ORCPT ); Mon, 8 May 2023 13:18:59 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B485B1BE9 for ; Mon, 8 May 2023 10:18:36 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-760dff4b701so29762239f.0 for ; Mon, 08 May 2023 10:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1683566316; x=1686158316; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FPp2h4EDEYJ2YkjNK6Cz8A2OUZJ0t46AiKfKnDtxUn8=; b=MVqaHBGWzrfD00BXHCzkU7L4rPa8Z4ZtNfxO+vupCgS5WRXclzYBRUU/918dVqHyL/ LMhWXLaI5V9OVsio8TIK6chz1W4i1uQv2AFJeFOQnQNvp2zAKc8g7e6qd/HDMhbZzZO7 75vVkJfoR3aJO0XaNjwz01VK8Wh1t8VVzFX4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683566316; x=1686158316; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FPp2h4EDEYJ2YkjNK6Cz8A2OUZJ0t46AiKfKnDtxUn8=; b=Wm9mELxBpiX0A8AQ83G3xHKsDxT/3ft/eC7kCp1id6GQnFOwBkQqjau3pDbKYMsEPT 3yhziBNfamYvwcUPelIU7bNRIBu4MeUg3jgyyQWh4r2RwLxWzo3wsAB0VavGtriMPDxi 6VYBqCvltoI3N3OKoYL35tVPiN4tkDNW4oEBxrOSOnsUNhp/k88DAEXNZXBUNAiVc1wb 8k52HVJookjkzWroQp4RNx0rIJUDetnEG4+4bI45hv77kJSlk2B3H2gyvgRjjnPiN0z7 KRf/vQ7BngBuWO3Ik3PKP7P0K++zBog+i0AqMOiSQLH6wW5rQQqnfzxwJYBtaQoNHjtb ApeA== X-Gm-Message-State: AC+VfDxSTRazw15zq6eL3+xnu+1i4nm6bSuIV+xxOTx4QgKuFujoR2vP OPUgDFMgwBTAvalBVIW/HuRcr5a5VlJxj453Wns= X-Google-Smtp-Source: ACHHUZ4meZeYyiPjUYlS9Zz76Hx/oG9htRP5jlKCsxRVY5RgaJ+4a0Rw/zsqyBGS+z7rLws6KtyR9g== X-Received: by 2002:a05:6e02:582:b0:332:fcce:c26d with SMTP id c2-20020a056e02058200b00332fccec26dmr4949876ils.0.1683566316035; Mon, 08 May 2023 10:18:36 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id q1-20020a920501000000b0033181097e9esm2474757ile.51.2023.05.08.10.18.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 10:18:35 -0700 (PDT) Message-ID: <31510739-c069-56fc-a1d2-43a0c86aeb2c@linuxfoundation.org> Date: Mon, 8 May 2023 11:18:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] tools/nolibc: Fix build of stdio.h due to header ordering Content-Language: en-US To: Mark Brown , Willy Tarreau , "Paul E. McKenney" , =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= Cc: Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20230413-nolibc-stdio-fix-v2-1-6b6bbb045a80@kernel.org> From: Shuah Khan In-Reply-To: <20230413-nolibc-stdio-fix-v2-1-6b6bbb045a80@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/8/23 07:30, Mark Brown wrote: > When we added fd based file streams we created references to STx_FILENO in > stdio.h but these constants are declared in unistd.h which is the last file > included by the top level nolibc.h meaning those constants are not defined > when we try to build stdio.h. This causes programs using nolibc.h to fail > to build. > > Reorder the headers to avoid this issue. > > Fixes: d449546c957f ("tools/nolibc: implement fd-based FILE streams") > Acked-by: Willy Tarreau > Signed-off-by: Mark Brown > --- Applied now to linux-kselftest fixes for 6.4-rc2 thanks, -- Shuah