From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mihai Sain <mihai.sain@microchip.com>,
robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/13] ARM: dts: microchip: sama7g5ek: Remove the empty line 50
Date: Thu, 11 Apr 2024 09:46:11 +0200 [thread overview]
Message-ID: <31557c2c-0fe5-4b7d-b323-ffc5973270b2@linaro.org> (raw)
In-Reply-To: <20240411073353.3831-2-mihai.sain@microchip.com>
On 11/04/2024 09:33, Mihai Sain wrote:
> Remove the empty line 50 from gpio-keys node.
Why? Commit msg *must* say why you are doing this.
I don't see any reason for this. You do not make code readable, you do
not explain the issue being addressed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-11 7:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 7:33 [PATCH 00/13] Remove the empty lines from sama5 and sama7 DT files Mihai Sain
2024-04-11 7:33 ` [PATCH 01/13] ARM: dts: microchip: sama7g5ek: Remove the empty line 50 Mihai Sain
2024-04-11 7:46 ` Krzysztof Kozlowski [this message]
2024-04-11 7:33 ` [PATCH 02/13] ARM: dts: microchip: sama7g5: Remove the empty line 139 Mihai Sain
2024-04-11 7:33 ` [PATCH 03/13] ARM: dts: microchip: sama5d2: Remove the empty lines 47 and 63 Mihai Sain
2024-04-11 7:45 ` Krzysztof Kozlowski
2024-04-11 7:33 ` [PATCH 04/13] ARM: dts: microchip: sama5d27_som1_ek: Remove the empty lines Mihai Sain
2024-04-11 7:33 ` [PATCH 05/13] ARM: dts: microchip: sama5d27_wlsom1_ek: Remove the empty line 31 Mihai Sain
2024-04-11 7:33 ` [PATCH 06/13] ARM: dts: microchip: sama5d29_curiosity: Remove the empty line 48 Mihai Sain
2024-04-11 7:33 ` [PATCH 07/13] ARM: dts: microchip: sama5d2_icp: Remove the empty line 47 Mihai Sain
2024-04-11 7:33 ` [PATCH 08/13] ARM: dts: microchip: sama5d2_ptc_ek: Remove the empty line 401 Mihai Sain
2024-04-11 7:33 ` [PATCH 09/13] ARM: dts: microchip: sama5d2_xplained: Remove the empty line 710 Mihai Sain
2024-04-11 7:33 ` [PATCH 10/13] ARM: dts: microchip: sama5d3_eds: Remove the empty line 24 Mihai Sain
2024-04-11 7:33 ` [PATCH 11/13] ARM: dts: microchip: sama5d3_xplained: Remove the empty line 377 Mihai Sain
2024-04-11 7:33 ` [PATCH 12/13] ARM: dts: microchip: sama5d4_xplained: Remove the empty line 247 Mihai Sain
2024-04-11 7:33 ` [PATCH 13/13] ARM: dts: microchip: sama5d4ek: Remove the empty line 274 Mihai Sain
2024-04-11 7:46 ` [PATCH 00/13] Remove the empty lines from sama5 and sama7 DT files Krzysztof Kozlowski
2024-04-11 9:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31557c2c-0fe5-4b7d-b323-ffc5973270b2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.sain@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®