From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbdALJoe (ORCPT ); Thu, 12 Jan 2017 04:44:34 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:54955 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbdALJoc (ORCPT ); Thu, 12 Jan 2017 04:44:32 -0500 From: Arnd Bergmann To: Johannes Berg Cc: linux-wireless@vger.kernel.org, "David S. Miller" , Networking , linux-kernel@vger.kernel.org Subject: Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better Date: Thu, 12 Jan 2017 10:44:16 +0100 Message-ID: <3158205.0GkzbOcZ01@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1484212560.5391.3.camel@sipsolutions.net> References: <20170111143532.485827-1-arnd@arndb.de> <3292373.oxnXTOSWCQ@wuerfel> <1484212560.5391.3.camel@sipsolutions.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:zL5brnYkIaWfZRDumRUqBTtRcUFh0GH6RpC1/cH0H8F92N5s8Sw txUtsCHkUjFDkRYGC1IMCVZRK+O94Af0kLQpGIBygSRP7tp2MhKtq5t5SvWygcs88WecYis fg8c/Uy/Ueb4TiKQOIqZVRYMf7RDgQGjVGLdpr5HoSXnFoUSIrPIex49DML5nETRddW0yRU BSoLssOsTadylFdxiPPUA== X-UI-Out-Filterresults: notjunk:1;V01:K0:na5emI6xpSc=:9PkWsad1c+yMJfXz8ze7Oi XnspkxeKjfz97WJbka/a13tTfZfuKcUOyOf/1TVSKFKvjv3jLKt5L13WWGJTlgmCkHrtB4VHI 2tr3JhuVYax9IBjSo0EzhN9FuOdPaoDjRjayZzEjUJ/U8eP4WSIhBU5E7gUNih0axmzdSAUvb 9BX+mycaA7DmepeCA+k06q1DeFEaIuSe0Ajh32bhEFAMhtl+5w/3I4Sb6cRRBcxKK2TSiMZaF yIfly+NwZ8zm8Ak1GcSllLD5uLGr925NqBw82AADBngk1lGujusiwwyNPJ4To5zX98MpnMX/a DemV9039rTXpeN0FJIhUePYl7mLoTWKZadS8FJeVuszNdTU+QrQjL87Tlsmq2gLaXanmCKDjN c0MTHCnrhxJ5AWzySaUFINCQ2Q539jODSHpOq0A4cNXNH9wmkLc7Jjd2PvI/bvKowqKI+/a51 QsSYwyMBtuiEjygzc7okgHYMQ0Gy6UYtHoxxECNpi9zvTc5j6QyhOzrCITCQj7UojG8Egysqq g9K1AAGXOBUhboA6dwnZYkc4yAP3zlwcd2XR6gr8vVGnc5zcAFCanVdOvY45INlZ39Y4acaj0 V9IMdOQi1YuYbPMsDFaZxi0Rl9ful6xl3ZrfJnS8bEwSvX7JCwaPIjlYkH47veme1gjnnkrCN zZHf5pbOxqu148kJycCWadGz0dQfEREuMVcX0AJP5n7PPdnoeCHoyoq6zxdzH/D9BM83LiN5T AsS5HJmBAllY2oWI Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, January 12, 2017 10:16:00 AM CET Johannes Berg wrote: > And I realized only now that this was a different place ... Right, it was a few hundred randconfigs later after I had confirmed that the first patch fixed all the configurations that were broken at first. > I've just added the check you suggested - spent way too much time > already on this old crap Ok, thanks! Let's hope it doesn't come back once more. I'm still trying to categorize the newly added warnings in gcc-7, there a number of very useful warnings that got added, but some of them are rather noisy and find both a number of real bugs and false positives. The NULL check had only a few findings that all seemed worth fixing. Arnd