From: Kees Cook <kees@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Yue Haibing <yuehaibing@huawei.com>,
Marc Zyngier <maz@kernel.org>, Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Ryan Roberts <ryan.roberts@arm.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Joey Gouly <joey.gouly@arm.com>,
Yeoreum Yun <yeoreum.yun@arm.com>,
James Morse <james.morse@arm.com>,
Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Zhenhua Huang <quic_zhenhuah@quicinc.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Dev Jain <dev.jain@arm.com>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] arm64: mm: Fix CFI failure due to kpti_ng_pgd_alloc function signature
Date: Fri, 29 Aug 2025 12:41:07 -0400 [thread overview]
Message-ID: <315CE055-A886-4322-9683-AFE7003B1664@kernel.org> (raw)
In-Reply-To: <aLHP-TG3a1Im3kpa@J2N7QTR9R3>
On August 29, 2025 12:06:17 PM EDT, Mark Rutland <mark.rutland@arm.com> wrote:
>On Fri, Aug 29, 2025 at 08:49:21AM -0700, Kees Cook wrote:
>> Fixes: 47546a1912fc ("arm64: mm: install KPTI nG mappings with MMU enabled")
>
>That doesn't look right; that commit is from June 2022, and we only
>introduced enum pgtable_type in May 2025 in commit:
>
> c64f46ee13779616 ("arm64: mm: use enum to identify pgtable level instead of *_SHIFT")
>
>... which landed in v6.16.
>
>AFAICT, that's the commit which broke things.
Oops, yes, I didn't look close enough. Want a v2 with that fixed up?
--
Kees Cook
next prev parent reply other threads:[~2025-08-29 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 15:49 Kees Cook
2025-08-29 15:59 ` Ard Biesheuvel
2025-08-29 16:06 ` Ryan Roberts
2025-08-29 16:06 ` Mark Rutland
2025-08-29 16:41 ` Kees Cook [this message]
2025-09-01 7:33 ` Kevin Brodsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=315CE055-A886-4322-9683-AFE7003B1664@kernel.org \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=quic_zhenhuah@quicinc.com \
--cc=ryan.roberts@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yeoreum.yun@arm.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®