From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 133461E6321; Tue, 15 Oct 2024 10:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728989734; cv=none; b=R8ilEgsTTTac4MDYHKV8CXcoWiXSVJnRkvCgOY8AlrSaEC4lND7R4bK+v+T3hWoEaI+9Wg2vvfq+ilKC/CW18xXrm8ONFzaVRYooP0aJY2n2XhjIEv7kLPnK4qQi8XYqWrwRQUxOKWWqdUwgIo+k6IjhgytD70Quk3k2yOxhraY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728989734; c=relaxed/simple; bh=qUWmUQcV9kHfpVCjSVGXIRAYN1rjZxOdfnWp1+SFr6E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j/bp/wTESDvjsPzhFc/5ks6n0Jyjb4vQMAj4jv5PAuXqMISPbiHgdzZgJ7SEmou4xNHimvX2g4+sZ4B1lY8dmu6IqZiYdTnOs/LUY2cufYPNV+vJeVA1UIHLR5NpSZ4U8t8skM1nNX0jUh+6EDL/HSoozWFrtZUqUcxoZsWLHFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E91261007; Tue, 15 Oct 2024 03:56:01 -0700 (PDT) Received: from [10.57.86.207] (unknown [10.57.86.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D9CC3F51B; Tue, 15 Oct 2024 03:55:28 -0700 (PDT) Message-ID: <315d4258-ea96-4008-8781-9205f41cec6c@arm.com> Date: Tue, 15 Oct 2024 11:55:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 03/57] mm/memcontrol: Fix seq_buf size to save memory when PAGE_SIZE is large Content-Language: en-GB To: Shakeel Butt Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Johannes Weiner , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Michal Hocko , Miroslav Benes , Roman Gushchin , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-3-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/10/2024 20:59, Shakeel Butt wrote: > On Mon, Oct 14, 2024 at 11:58:10AM GMT, Ryan Roberts wrote: >> Previously the seq_buf used for accumulating the memory.stat output was >> sized at PAGE_SIZE. But the amount of output is invariant to PAGE_SIZE; >> If 4K is enough on a 4K page system, then it should also be enough on a >> 64K page system, so we can save 60K om the static buffer used in >> mem_cgroup_print_oom_meminfo(). Let's make it so. >> >> This also has the beneficial side effect of removing a place in the code >> that assumed PAGE_SIZE is a compile-time constant. So this helps our >> quest towards supporting boot-time page size selection. >> >> Signed-off-by: Ryan Roberts > > Acked-by: Shakeel Butt Thanks Shakeel and Johannes, for the acks. Given this patch is totally independent, I'll plan to resubmit it on its own and hopefully we can get it in independently of the rest of the series. Thanks, Ryan