From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1894E3F8EBA for ; Mon, 18 May 2026 12:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105874; cv=fail; b=OjaSasG6Jx+wLe/P3A9cr2Fc/DKQMobFVgEpndF/ZgJdhPFBjwgtLlR4TqvctPlip1LE/lJHRgiuR+CJ1OG8pXjexIPaHFPTiIf3olBQofoQ0lZa3laRuTwB3ILWpW/NFAOHaUQEp35AxWjaoX3iv+TgQs3lU11PjkgqiCjAzOY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105874; c=relaxed/simple; bh=xPKrvNwuUklm3j4HFUs1wB1mKK5fU+IBd77JELyC4aA=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=oOVlpnZ8Y4fM26d5UIEgQZ6fS90kUc5yFDTqHQf9AuiiKNHJCt+vpEHaNpmFSQ7Y1zfhPRizYa5rTTC8RB1sEgsVopCpMV5hZfET1W1qxTfcxBsxS7byiJDI4czQLFV51i566uHtRdZynpN/z6/QENtJFP6fAvzr51duBw8J4fg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VP3cXwXW; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VP3cXwXW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779105873; x=1810641873; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=xPKrvNwuUklm3j4HFUs1wB1mKK5fU+IBd77JELyC4aA=; b=VP3cXwXWPLL2Ly82msFH2SFEXYHvdnpJEQ68cQkike7et041KUyWMvUD sphev8y9B4x5P9H/ZoZapCyiOrj8a+oXKXLAvUAyfT5NethLa5fuSiQlB k3Yx2lTgNU+uc9i17ulYhMY0n/uHtsMVkDYRHd6I1igxSEPMkFb1k94ku mX4JvLf1DY9VY0kt8ezO5eovOUCMMoYipNdCacY7c6UNlHVV9B9UtXrHV GMMxRrphtNZowtL3d3AOnrE+nVX+MJopTZq/FZJ1+qj+dxDtEMsPv0yC+ C5BNhCnr/3fTyV2/0YQQ+zQaGfzd3Z0OX0nOQNvRbNwX5k47q9Kfwhioe g==; X-CSE-ConnectionGUID: 9cZBUEiVQPGmVIG5DeoCDw== X-CSE-MsgGUID: V2jUc0jyRnaViiXHaytU2Q== X-IronPort-AV: E=McAfee;i="6800,10657,11789"; a="90536941" X-IronPort-AV: E=Sophos;i="6.23,241,1770624000"; d="scan'208";a="90536941" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 05:04:32 -0700 X-CSE-ConnectionGUID: uZHao09ARWSp9vRUu4dJcg== X-CSE-MsgGUID: s2YAm9uvQFiGw7LAtjkSJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,241,1770624000"; d="scan'208";a="236402892" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 05:04:32 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 18 May 2026 05:04:31 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 18 May 2026 05:04:31 -0700 Received: from SN4PR2101CU001.outbound.protection.outlook.com (40.93.195.30) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 18 May 2026 05:04:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HfcvrLoW6fJ0ISffvrUjLeCQe5qRGfro0BZ20n0+GTfp9U5Xe9mUq077j9wduw0+R2bgynOyl4CFYA8+tM19jHv7ECpd6yHd/P4iLXp/0QPLsMYvLNsyhJ5cU1VJgEXOXiIgymUjndq64H640YfW8P/YPVkcF2kYcQ4p6Ruu08d4HSbcLSbSae7mEzYwc3EOUAS44u+53rjXaZ06TVZ4XcV2lwAy7IDDpCAj4mGnDYLdWjwzi31BgABn3NOyf1kiLUfT9niOzenrZxkg8D4xm9atT1GEM1OmuQgJ+WqotdZ65VZB5LvqDtJtTTG9gg7K3ubWZYDevYj/w11nWHHnnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f8pKio2JehPMIPaYXGS889PtX9bIpBGGqhDdWcAausg=; b=aJWXyRL1vjr19Q1pXJlwjR1BH2gZNI5p9tgurjaL2idY4atTSMW85cJaWEK3zuO3jTqe/gqD5NfbZ+qVpSCe9LW1ucke532YgmjzvUoJBKFrdb4XgGl4OGtmyjGdsz+1AmqCpZdmzRoIV80cjQnzOwzllgOroSNbuX7zFsNMj6ZLA2V2Us3wxFAxSCoRBOZvSR41WMJDhaOFu4qu9VimderNzbVhdaoz9hZDFj74OyDOykoobtot/ur8hetQpfQfU7nryUnvMj0aKHshoy6zyFyHflDPciCq73IaVMlSyN8veIr7QekxJO8bpYHKmhD3PpqE5j4ZxKNr5ufabCjP8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) by PH0PR11MB5125.namprd11.prod.outlook.com (2603:10b6:510:3e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.24; Mon, 18 May 2026 12:04:28 +0000 Received: from IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456]) by IA1PR11MB7198.namprd11.prod.outlook.com ([fe80::2c4e:e92a:4fa:a456%3]) with mapi id 15.20.9913.009; Mon, 18 May 2026 12:04:28 +0000 Message-ID: <316208bc-f430-4f04-b81b-6fbabce3adcc@intel.com> Date: Mon, 18 May 2026 15:04:22 +0300 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] i3c: master: Defer new-device registration out of DAA caller context To: =?UTF-8?Q?David_Nystr=C3=B6m?= CC: Frank Li , , , References: <20260512121732.406009-1-adrian.hunter@intel.com> <20260512121732.406009-7-adrian.hunter@intel.com> <01df8e0e-9041-401b-ab73-634701c4acdc@intel.com> Content-Language: en-US From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZP191CA0052.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4fa::15) To IA1PR11MB7198.namprd11.prod.outlook.com (2603:10b6:208:419::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB7198:EE_|PH0PR11MB5125:EE_ X-MS-Office365-Filtering-Correlation-Id: de5dfa60-b716-4556-b9f7-08deb4d59c56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|22082099003|56012099003|18002099003|11063799003|4143699003; X-Microsoft-Antispam-Message-Info: UuCHO71WnumGv0XAm9+vMD4RaGBv1IGyygSA6zDsZ/4K2CT7R0KoTxap6AidHV5j7Ax+EUPbBJwioqJcS7I5BWCGc0jxoR0Bc3fScasB76ZuhVu4AH4YumJhaWTj8mEu+QzRy48Fs2H0WgbtqQaBzCNfITcggVNxEcoN1G0uM9wkgy56JYswPcj51TdLh99H9JUE07j25JkjzKWVyV7nipQPdJu7YCYD6Wua+El0frzubtCeGijvQW9Fgv/UD8Q0gDWoiAAN//kuO5batADFRfvvTuVAz5HK0kk5jt/3vtFaWalmpbgi12/7URugjxYR3e7RBKxJnXK6ZrsoWjz6vFvCWwDMxPyjdEnDII2hiH9PkspYoH3ub4BINTL5wnIeVs9iJhPCRsy8O6cEqayT1g5nFabzhEsdazjuutsBhnuUyBUj5UoR+eq9AAi9KtbIOHw/DOEWMz8w3frUyM6t1WumhHlVnVIrII8bkpvvRYp71ncpzEYgkmSdxtYrqs3FgXzARVyLLUlfHwPGHNvy3LX3gBbjxTNEyF32AKcD4YN7JxPWRIj5YCwGqwrNVsE0pIhY8RznBh9v9Ndbqi3iNziY1Xymtz0r6i091jFiDKVuLHQZ8qZjpc1zCY78jLwXouOMx9jw7zsj1by9ZM2CH9ffHRPr7MLqosHifGDRLvLxRvkAr4/UBwyPG+jmRSDI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB7198.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(56012099003)(18002099003)(11063799003)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0RhTDljYWZQZDR3Si9uOEFCTnJIZEs1VDYyYitjc2JyMjZTa0JNZTBuOWo1?= =?utf-8?B?MGlnQks5QytZRDB4R1UySTJSeHAxcUxwODFpS2hVNzVCcXNHQS9YNGpzOFJ4?= =?utf-8?B?SU04emkzNDRpd1p4OWpVRnNJbkdJeFdKSVpRa2MrQzduTytDc1RVRHU2cUVz?= =?utf-8?B?UFZUc05sYUVwSnlURE5hWHZIYXdGTjc1eVpsR0RzSHd6N3ZFZEhRcHQvUSt6?= =?utf-8?B?akgzSUhUeStvYW1Da0FlQkMxZlZZYnhWdEFjcG5mUHY5OFAwVlo0VHZIaS9B?= =?utf-8?B?bTY0SlNMOGRYcmVmMlFMNzJKTURJdHV1blZvUWsybGhPUHQ1RzlmQi85OVp6?= =?utf-8?B?RDIvYTJjaW12dHZyaXJ6OUVwRnZzbk1Sdk5MSlducGlwSFp1NmlycDJTVkhk?= =?utf-8?B?VXF0cnRMTEw1cElaUUhoTTB5b1pLb3l4VVN6amJFT25UNW5qT252THhpYmxa?= =?utf-8?B?NmRwWXZEL3VubGJhcXdaVWswM3Mrb2dBNDlLdEQ2SzlGeUswUFFJbXhCemVr?= =?utf-8?B?N29xUGF6dzJQN1haTERSdjRBN3FzdS85dTRaUjlJbXdkdEhTRUhaNnNFT3dt?= =?utf-8?B?SnB5Y3hmZFRKb1E2UmttcjE3TUJRNExtUTFNUHpmalpscmJrQlRiV04xanF0?= =?utf-8?B?dTNQaWV4dU43OGl0c1RNM3Z6dlRGM2lOL25aYVBOVjRkTUp3ZFJpZTlHK0t6?= =?utf-8?B?cDdxei9uZmNKak02SVgveVlFam1QZ2lqSmxTRXVqZ1RGVDdqdFQxai9XZzd1?= =?utf-8?B?eDZLSEMwaTk4YnVLK2pOVTkxcE9LTFFMVUZTcFlFckFZR29CU3ZNK0p1dFZN?= =?utf-8?B?M0JWQ0srTXJkUkhKWEI3Szg1Q2YzUlVIQ2xNdVJCS2gydFhhSkxwM3NXRDFl?= =?utf-8?B?bTJZZEdrV2ZCSHQ1OWRCYVZIQTQwTmN5L1FKWGhReDlaNFpzUzR2VVZZcHMv?= =?utf-8?B?NFU1Q2lTOXJCZ3IvNEdRdGNkSUFRSXBWZnJLTzB4TUtoM1FrTnVDZEVhV2hx?= =?utf-8?B?bmM3c3JqenRlWWxEdHlNeURrLzI4Nlk2ampsQjRCeEFMdVI2NHVCSXE1QTdN?= =?utf-8?B?NUh5UHJ3eDZrUXlCeVNJSWVNUW9LZStVWnhzZkRYNjA4bzBOb2tHbW4xZE9D?= =?utf-8?B?ZzQzS2UxTFJ0d0lSQmsrclpvUHpOT0U2V25sY3ExYzd2a2Q1MUNmY0lPUlNv?= =?utf-8?B?VjdGWW90cUVsa1JRVXBmZHhhNk1lb3ZMN1lBZHNyR0QxOVA4OCtEM201TGJ0?= =?utf-8?B?dlI3cy90U2czRkNQN1JtNFVqa3dBVTQzMy9WZ3NINkJUL2xmdWZwSklpLzFT?= =?utf-8?B?SW5qdERxZ2YyQ0dGa2tZMUt5VjhnTFREWTRIaWd2M2FSRnlFQmRvdEt4TFVs?= =?utf-8?B?cWdETExCQ0ZDc2lHMUdoOGV2YzB1d1FiZXFkSWRVVkxRYkt0QTFucHNwekVp?= =?utf-8?B?R3k2dWFPTkVaNnF5Sy9hN1hsZUgvY2ZndWNUMHdIVEpDSG1zeW0yWGRDdHlO?= =?utf-8?B?ZXBEbzVqWE4zcXJkbCtKenFnMWgyOHVIU2JwNnR0TTdndU9WeEd3THVFVWpD?= =?utf-8?B?eU1DQXJDVGxacE42QWFvbUpmZjhRbFlvS2lremNFSFgwTmpETVRWZnkrVXJI?= =?utf-8?B?NFBTQUQ3dzgxUFNKNm1nSzlXYUt6OGJYL2UrZnYvZ2x0Sm83cmQ4MGNPRC9s?= =?utf-8?B?N1FRSkhKYUNMZUY2dWJucC9KWHV0dWgvL0V3QmVYQWt4Q1M5WDJwSzdiQ2ps?= =?utf-8?B?bWZOZzdXNjN4Q1VXcE4xK0RmNnM4Q3hJeVRLVWZvcEFYT08rbkVPUThYUnY2?= =?utf-8?B?amNtWU9nWDdTUURYZ3p3YXBRUHZ0RTFITmtDRDhMTmwzZzNSK2tMU0ZUTnJw?= =?utf-8?B?K1dUUHBZUzFPZG9JNXRsUUU5ZWt2T2liRi9vTkdCanZVMHJhRnAvbE9FM0Nn?= =?utf-8?B?MmNtcDNWdzhyaTQwQWl6T28wNDl5cFJZdWc2TytVMzgwUllMWldLVmxobllr?= =?utf-8?B?WWJIV2UraTV4WDNXeGtaOUhtTXdEL09LMFZKN0l1N2tsNFMvR1BZTlFwSldt?= =?utf-8?B?QVpTcjBuVjY4b3MrTENwZ1ZVdTd2Tmo1SEhBM0xZZnMzSnRkZjdGT0NiWitG?= =?utf-8?B?M2ZGSHJZdUVuOGlTazFodXpLOUFsUTEwcEpleXE5aFp0c1N6bkZIWjFDTWpk?= =?utf-8?B?WTI3ck9xUWZpenNSck5oUHBYWHNJSkx3MFliNnkxbGprN3BZYytERTBOYjBk?= =?utf-8?B?eFErcEp0TjZ5VnNRSDV2dURCM2VjZWtuYVJzTmxDUCtxRVM3TXlzQ1BtalBp?= =?utf-8?B?cEFlSjllVnRxa0RuOWlZZjNDVXhlaXJ0QzF0cmR3aTFXbG9wNWNmUEZUQ2FV?= =?utf-8?Q?1UtAMQ9IvzZh0tyc=3D?= X-Exchange-RoutingPolicyChecked: iEQp4VdJXzqO7LsXlLLP9nWBZuioFIWks26uvLQH9sRCIYE+p4E7l4uHVK8PXz3lFfA4AEt9lAE3LLmx5ffRbb5peIR82s6uFa4WSKgULMZsQnIdd3qNqhpD7yy4HXfzZxre15784A16rztE1KZrAAUJWNfuw7McGEW5Rec+TOrhn7RkAJMOPqug3T12ytpkzmtvLPPSXgU696ywc0xO+sLYIXiECcdBRTiZaT22sbxeAowQLqWUZ8enNXKBXNgZdJpOm5l9qIfOxUTpQ0LTtGds4XBa23mz5vijUgkUyJYmH3JQTaCs+TvnMBTO3t/OqI2m8O8Ew7AH+goz3EM0PA== X-MS-Exchange-CrossTenant-Network-Message-Id: de5dfa60-b716-4556-b9f7-08deb4d59c56 X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7198.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2026 12:04:28.0695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RroZYixUqrMEkfSidi4oeUDyxDdshaDHDCvBVjBlDvNQuQHtaCYXYGCxSApuX59boUUaFeO/csPG+LRh8nFqJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5125 X-OriginatorOrg: intel.com On 13/05/2026 13:20, David Nyström wrote: > > > On Wed, 13 May 2026, Adrian Hunter wrote: > >> On 12/05/2026 19:39, Frank Li wrote: >>> On Tue, May 12, 2026 at 03:17:30PM +0300, Adrian Hunter wrote: >>>> Master drivers may invoke i3c_master_do_daa_ext() during resume to >>>> re-run Dynamic Address Assignment.  As well as assigning addresses to >>>> any newly arrived devices, this restores the dynamic address of devices >>>> that lost it across system suspend, so it has to run as part of the >>>> controller's resume path. >>>> >>>> A side effect of i3c_master_do_daa_ext() today is that it also >>>> registers any newly discovered I3C devices with the driver model >>>> inline, via i3c_master_register_new_i3c_devs().  Doing that from the >>>> resume path is problematic: a hot-join-capable device may join the bus >>>> during this same DAA, and registering it immediately would push driver >>>> model work (probing, sysfs, etc.) into the controller's resume context, >>>> where the rest of the system is not yet fully resumed and the >>>> controller driver is still partway through its own resume sequence. >>>> >>>> Decouple discovery from registration: add a reg_work work item to >>>> struct i3c_master_controller and have i3c_master_do_daa_ext() queue it >>>> on master->wq (the freezable workqueue) instead of calling >>>> i3c_master_register_new_i3c_devs() directly.  The worker performs the >>>> registration only when the controller is not shutting_down, and is >>>> cancelled alongside hj_work in i3c_master_shutdown().  Because wq is >>>> freezable, any newly observed devices end up being registered after >>>> the system has finished resuming. >>>> >>>> i3c_master_register() also routes its initial post-bus-init registration >>>> through reg_work, using flush_work() to keep probe-time behavior >>>> synchronous.  This keeps a single registration code path and ensures the >>>> worker is the only writer of desc->dev. >>> >>> why not direct use hj_work? >> >> i3c_master_register_new_i3c_devs() use of desc->dev is racy, so >> i3c_master_register_new_i3c_devs() must not be allowed to race >> with itself.  Having it only ever run via reg_work achieves that. > > This race was introduced in > 3a379bbcea0a ("i3c: Add core I3C infrastructure") > > But since this path was exposed via sysfs in latest 7.1-rc via: > 8ea0b60bc00d ("i3c: master: Add sysfs option to rescan bus via entdaa") > > I would argue that we should revert the sysfs addition from 7.1-rc until this fix is in place. I guess it is up to you. A couple of options: - submit a revert patch, or - wait until 7.2-rc1 and backport fixes to 7.1