From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759312AbcILNGF (ORCPT ); Mon, 12 Sep 2016 09:06:05 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34201 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932923AbcILNEE (ORCPT ); Mon, 12 Sep 2016 09:04:04 -0400 Subject: Re: [PATCH] net: r6040: add in missing white space in error message text To: Colin King , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160912120857.31600-1-colin.king@canonical.com> From: Sergei Shtylyov Message-ID: <3167d502-bbcc-34db-02d6-8b95ff0a294e@cogentembedded.com> Date: Mon, 12 Sep 2016 16:04:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160912120857.31600-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/12/2016 3:08 PM, Colin King wrote: > From: Colin Ian King > > A couple of dev_err messages span two lines and the literal > string is missing a white space between words. Add the white > space. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/rdc/r6040.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c > index cb29ee2..5dc655b 100644 > --- a/drivers/net/ethernet/rdc/r6040.c > +++ b/drivers/net/ethernet/rdc/r6040.c > @@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > /* this should always be supported */ > err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); > if (err) { > - dev_err(&pdev->dev, "32-bit PCI DMA addresses" > + dev_err(&pdev->dev, "32-bit PCI DMA addresses " > "not supported by the card\n"); > goto err_out_disable_dev; > } > err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); > if (err) { > - dev_err(&pdev->dev, "32-bit PCI DMA addresses" > + dev_err(&pdev->dev, "32-bit PCI DMA addresses " > "not supported by the card\n"); > goto err_out_disable_dev; > } The message strings simply shouldn't be broken up, and checkpatch.pl knows about that. MBR, Sergei