From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B67C5519F for ; Fri, 27 Nov 2020 18:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29626221EB for ; Fri, 27 Nov 2020 18:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733026AbgK0SL1 (ORCPT ); Fri, 27 Nov 2020 13:11:27 -0500 Received: from smtprelay0139.hostedemail.com ([216.40.44.139]:49898 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732323AbgK0SL1 (ORCPT ); Fri, 27 Nov 2020 13:11:27 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 152EB1801E323; Fri, 27 Nov 2020 18:11:26 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: town85_4e036de2738a X-Filterd-Recvd-Size: 1466 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Fri, 27 Nov 2020 18:11:24 +0000 (UTC) Message-ID: <3168a3aa5c4ac564340cba2a151359e8cd3dee5f.camel@perches.com> Subject: Re: [PATCH] eCryptfs: add a semicolon From: Joe Perches To: trix@redhat.com, code@tyhicks.com, hannes@cmpxchg.org, mhocko@suse.com, longman@redhat.com, herbert@gondor.apana.org.au, ebiggers@google.com Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 27 Nov 2020 10:11:23 -0800 In-Reply-To: <20201127160513.2619747-1-trix@redhat.com> References: <20201127160513.2619747-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-11-27 at 08:05 -0800, trix@redhat.com wrote: > Function like macros should have a semicolon. [] > diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c [] > @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok, >   rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code); >   if (rc) { >   ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n", > - cipher_code) > + cipher_code); As this is the only use that does not have a semicolon, it'd be good to add the removal of the semicolon from the #define at the same time.