From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbdLLDbn (ORCPT ); Mon, 11 Dec 2017 22:31:43 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2279 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751281AbdLLDbm (ORCPT ); Mon, 11 Dec 2017 22:31:42 -0500 Subject: Re: [RESEND PATCH V2] arm64: fault: avoid send SIGBUS two times To: Dongjiu Geng , , , , , , , , References: <20171211160536.11600-1-gengdongjiu@huawei.com> From: Xie XiuQi Message-ID: <316b5416-1268-1e9b-ae07-aa6cd31db8a8@huawei.com> Date: Tue, 12 Dec 2017 11:31:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171211160536.11600-1-gengdongjiu@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.210] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dongjiu, On 2017/12/12 0:05, Dongjiu Geng wrote: > do_sea() calls arm64_notify_die() which will always signal > user-space. It also returns whether APEI claimed the external > abort as a RAS notification. If it returns failure do_mem_abort() > will signal user-space too. > > do_mem_abort() wants to know if we handled the error, we always > call arm64_notify_die() so can always return success. > > Signed-off-by: Dongjiu Geng > --- > 1. Address James's comments to update the commit messages > 2. Address James's comments to not change the si_code for SIGBUS > --- > arch/arm64/mm/fault.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > index b64958b..38b9f3e 100644 > --- a/arch/arm64/mm/fault.c > +++ b/arch/arm64/mm/fault.c > @@ -610,7 +610,6 @@ static int do_sea(unsigned long addr, unsigned int esr, struct pt_regs *regs) > { > struct siginfo info; > const struct fault_info *inf; > - int ret = 0; > > inf = esr_to_fault_info(esr); > pr_err("Synchronous External Abort: %s (0x%08x) at 0x%016lx\n", > @@ -625,7 +624,7 @@ static int do_sea(unsigned long addr, unsigned int esr, struct pt_regs *regs) > if (interrupts_enabled(regs)) > nmi_enter(); > > - ret = ghes_notify_sea(); > + ghes_notify_sea(); > > if (interrupts_enabled(regs)) > nmi_exit(); > @@ -640,7 +639,7 @@ static int do_sea(unsigned long addr, unsigned int esr, struct pt_regs *regs) > info.si_addr = (void __user *)addr; > arm64_notify_die("", regs, &info, esr); > > - return ret; > + return 0; It looks good to me. do_sea() has done all necessary action for SEA, so it should always return 0, no matter ghes_notify_sea() return true or false. Reviewed-by: Xie XiuQi > } > > static const struct fault_info fault_info[] = { > -- > 2.10.1 > -- Thanks, Xie XiuQi