From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A1AC433DF for ; Wed, 14 Oct 2020 06:02:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BD7C21582 for ; Wed, 14 Oct 2020 06:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbgJNGCB (ORCPT ); Wed, 14 Oct 2020 02:02:01 -0400 Received: from smtprelay0222.hostedemail.com ([216.40.44.222]:50432 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725983AbgJNGCB (ORCPT ); Wed, 14 Oct 2020 02:02:01 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 810FD180A7FDE; Wed, 14 Oct 2020 06:02:00 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: camp63_4004aec27209 X-Filterd-Recvd-Size: 1769 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Wed, 14 Oct 2020 06:01:59 +0000 (UTC) Message-ID: <316d5a53351d10cd1a26ce0c54883da05642c898.camel@perches.com> Subject: Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS From: Joe Perches To: Lukas Bulwahn , Ujjwal Kumar Cc: linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Date: Tue, 13 Oct 2020 23:01:58 -0700 In-Reply-To: References: <20201013120129.1304101-1-ujjwalkumar0501@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-10-14 at 07:46 +0200, Lukas Bulwahn wrote: > Just one bigger project example: Comparing clang-format suggestions on > patches against checkpatch.pl suggestions are fine-tuning both of them to fit to > the actual kernel style. Eek no. Mindless use of either tool isn't a great thing. Linux source code has generally be created with human readability in mind by humans, not scripts. Please don't try to replace human readable code with mindless tools. If there's something inappropriate in checkpatch, please mention it. There is a _lot_ of relatively inappropriate output in how clang-format changes existing code in the kernel. Try it and look at the results. Improving how .clang-format is created and its mechanisms (for example: continually out of date ForEachMacros lists) could be reasonably be done.