From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8D574156DD for ; Thu, 16 Jul 2026 11:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784200346; cv=none; b=Z4pGNtAsbuYdg2ejroKVSqErofpD8iFuU/O7t+Th7WbpGXlyRH+T3kmPlTbKpAgxRxs48HPsmRk2fQ97WwMgFNKEQgjSAIlY6SfzeeAvj3+V/TgJQI5UEdJbXp4wr6+o0LacMMyd4TkEsWaDjRp8oM6OKDyUvYCYcJHosIqlHGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784200346; c=relaxed/simple; bh=yzH3rj1qE1iSUDcLNaIAmbiWve6bqP2OJ+u3kW2gTLo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fbdrpNTt3EQZrFaso3xquhGx71b6tyV/qpjCukD/MeClWsK3tY+r5tsw2ldT6e5jq2Dvu5kUTX5iNIUwcYjy2fFl7v1l5ePJBMrUwSPEDWAtK8s2GQlwKCXk7lZpwNiF2NjCMzWMYgWh7PUJnLO7FMG7mACSS/mUpXuJsDvVjQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lXs5bHMJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LcbAR4Ys; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lXs5bHMJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LcbAR4Ys" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G9rJmD2259693 for ; Thu, 16 Jul 2026 11:12:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hhRDmVLt+j+++2qCqj2WWEzcP52HQCdEmO997P4JbPo=; b=lXs5bHMJOg36IFTw YHeHq0C1sRqamoqaV9r98QJULx1ZLHC3GM2/avlZ6k0pAmyz0y4rqRY8SeQzprIY Mm+SK0oh+jPzsuH20YT7DRxT4JjLAr3i+WCWrQpc2vxBpOMOdy0GWwF2mHrKxKhF rmVL+qLbdFb8AhwxOLjQSYbm5bSPL+4kp/l3/rklj2i98pFu1BaENR+oebUccaDa vBGnMmdCt8k7uLUsMGJA3lCdijiuHM5d/HW632TxxvW9TvAkYk7v/88DqYdWDiId FHVqIG6jYR+7AW4qQj9DZ5AqGjgIhFQJh1R+KpKTipc+Cp1kO3nRgVkw/1JtyJdv b7nisA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fevkv0ffy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 11:12:21 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8482fd61e83so12361936b3a.1 for ; Thu, 16 Jul 2026 04:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784200341; x=1784805141; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hhRDmVLt+j+++2qCqj2WWEzcP52HQCdEmO997P4JbPo=; b=LcbAR4YsIFGB2ZF/Ma6ir4k1P/ITidnyiGZblwsCG1DZ2HmJ9s9R9p1ghEHQFyBjoJ OneaZehxJui+/UD3+GryrBXvCefzq4SEHMy05QR4k2ueQgWimX7YUgTT/H/Cna4jNcpn ONBHj2nC6Qi/zwi+B4eYVubM/8Q6sjjOQjcYHwB8RK1O76uW0Quut+RIloajO3+47gZU I/0ODK+yjAC+Z9yeCGC6UIB9yLOo0YDP+eaQMmTJwkYhL5IOetytp8rVyHLznaMUGHOK 5tY7vmTnB/xyfkygaqbCxliBkMQiDaMkfv/9ti8Xq/jaxWNmDx80Kvwe3MaJzNMzzZvr c7fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784200341; x=1784805141; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hhRDmVLt+j+++2qCqj2WWEzcP52HQCdEmO997P4JbPo=; b=kbOd1tQgnMX7bWXkV4rXKQ/8LjFewhaPET7OHkMZqajWl9xQtYfNug4fGiZODYoCaH OXJRFs4REJZEdJbgLNhcapiumLgBJ2anEpW7Mb18nG6x1ZDCwOXJVOumrG8m0ZKS8Vfh U0+qGHzqCbv0sb7U3hg1cmc9T5UJlUN4mobqObxDEgKOMDGuJdK7QfKi4celGUK0AKiN D1Kh6zGnCM/bM6ypTBxdFYgECetC2jpOqtUZQ6KLp4DB0fucYj67nI0dAoXiO7zbd0k5 q18CrqOqMG4rMyksKkq2PM0CXpJDEZf3MBO8bCcryzRUdhstVDZ4HGImFbFM2MBea+XJ 0w2Q== X-Forwarded-Encrypted: i=1; AHgh+Rodlw+OAhuzYqifF2y//1qv8EHYWJFc40aVCJekpPKPTif2CxEpmlZSa9dcaZfEnjrqvhUa4zhiaHVh0Ok=@vger.kernel.org X-Gm-Message-State: AOJu0YyoPy8mw/zgCQBeHQgcbY5OF83hxZX7Z24Bo5AOTcO5ZmWb4VJU 2ipgNt1D9iXv4SPLh1iSXO6Y6MqrgdsWcUnX38xRF53qVHpLStncdfsA5287CLHLzRtbvDFvTit 1FHesxlMMMBzk2FjuhzBQy2989Gn5PpJXp3aFgZLoZYszEVs5V2allern21fFNYvVsQg= X-Gm-Gg: AfdE7cl627JMNgCy9wc1PRPjYGmhXWUY+r/l2pkkROF6Uh0ocnrHMpnzvvkq+sxcNU1 doZ/piVBTlmuZ0V2gwXKhHd8D5ZK/pQ/6S6qJlawEVhSkFGBUtW/W2S46RKem8iOjzdDyF6PlHW 9l81sMz4dspi4qbfQ+Ejb3+SCh4e2jaKbynkNjoxPTXe+x0JA7FNvBXYQVXtPe16F3NqKXJFFvp uQa8BMxN9zKDP7wHZhliH0eRVfW/y/uxhNFGSasQh1YhuQGA5BLlqoJrmS9NJK0tAmZw3HiKbVJ QHrB3m0PTRIXtAEIOo+KZka9lT3nOhaoyffUu22WfWdLCu7UobErCFHtKjh6ZXqRglOaMDYuuL2 fLD+Mr/JKiIMRI6W3TueiJE67sqc= X-Received: by 2002:a05:6a00:301a:b0:847:968d:b101 with SMTP id d2e1a72fcca58-84a51442e0cmr10682693b3a.21.1784200340754; Thu, 16 Jul 2026 04:12:20 -0700 (PDT) X-Received: by 2002:a05:6a00:301a:b0:847:968d:b101 with SMTP id d2e1a72fcca58-84a51442e0cmr10682655b3a.21.1784200340258; Thu, 16 Jul 2026 04:12:20 -0700 (PDT) Received: from [10.217.216.90] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f23a5f3sm4578248b3a.5.2026.07.16.04.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 04:12:19 -0700 (PDT) Message-ID: <316fd37b-9936-4bca-8521-9a11ee65cbd6@oss.qualcomm.com> Date: Thu, 16 Jul 2026 16:42:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: clock: qcom: glymur-gcc: Add missing CX power domain To: Abel Vesa Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Maulik Shah , Dmitry Baryshkov , Jyothi Kumar Seerapu , Konrad Dybcio , Brian Masney , Krzysztof Kozlowski , Sibi Sankar , Pankaj Patil , Akhil P Oommen , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jishnu Prakash , Raviteja Laggyshetty , Kamal Wadhwa , Qiang Yu , Manaf Meethalavalappu Pallikunhi , Abel Vesa References: <20260715-glymur-fix-gcc-cx-scaling-v3-0-72eb5adad156@oss.qualcomm.com> <20260715-glymur-fix-gcc-cx-scaling-v3-1-72eb5adad156@oss.qualcomm.com> <4b543abe-2482-4381-b41e-623cdf5be9a2@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDExNSBTYWx0ZWRfX1OIkWg5b1het +ox9HQ4t26bKewRNl9EdpxZ8lUHpsWJOgFszaTt7QT6TzHnRiIATD41j232QOkvfbzJHlvY0SX2 tcbc1/eY7znrmzv3IKaeRNA8WUt0WjP8vSnLAR2+fSkQhGnO3uXSSp8Sg6hETh92pYPTI0ZHsVo p9QSbPGaupzAeDVBX9V8pUwPn59ytdqswa35ATHcTD7smYKDRgoJFtPgUDk27NHBD19c4+jVLYc ztcqi30NicRNfiTqHVkWugmDYVG5B2lxoyJx4weqw5nkKkOYmGoyEbCjVxDogc/puMQlMlDcXdO BqmpjoguOTN9t0n9V4V26szQPz9JQX9lNZAfMEPHWExj9qDgQHmXZaLXE0mMP3+iceEG/xfs8EU PQt0SYDPd7nQULVa5rfrk8FH/YTH2/qVqgSdfOIvVFNA/3RM2ze5ZkHoaAZoy5EAnWfUxOi6dXp uY+KhRRz6qEZ3JLSd6w== X-Authority-Analysis: v=2.4 cv=WrEb99fv c=1 sm=1 tr=0 ts=6a58bc95 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=1U0sEZR_6ltlo9pre54A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: og7pUdXoliu6JvCv071GGb3JmvKNWUsN X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDExNSBTYWx0ZWRfX3AVKA1U7XHw7 EniqhDAAsUsgQKo/oJoUyXISayS+HtyPvyNUDrGM1QWMgBZKKN1Wc73RnVmV2xWxMp6PEJh5BoK 1g1ZPoqQVx7h8cuvl9IKz9YQWUzWQbQ= X-Proofpoint-ORIG-GUID: og7pUdXoliu6JvCv071GGb3JmvKNWUsN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_04,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160115 On 7/16/2026 12:52 PM, Abel Vesa wrote: > On 26-07-16 10:13:48, Taniya Das wrote: >> >> >> On 7/15/2026 6:59 PM, Abel Vesa wrote: >>> The GDSCs provided by the Glymur GCC are supplied by the RPMh CX power >>> domain. Model that parent domain in the GCC binding so the provider can >>> describe the dependency in devicetree. >>> >>> Add a single CX power-domain entry to the binding and make it required, >>> matching the hardware description needed by the GCC node. >>> >>> Fixes: ee2d967030fe ("dt-bindings: clock: qcom: document the Glymur Global Clock Controller") >>> Signed-off-by: Abel Vesa >>> --- >>> Documentation/devicetree/bindings/clock/qcom,glymur-gcc.yaml | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >> >> >> Abel, I feel we should add the 'required-opps' as well which will ensure >> the clock controllers minimum voltage requirement. > > But it was agreed in v1 that we should not add the required-opps. So we > dropped it in v2. > Okay, sorry, may be I missed that comment. > Can you give more details to why you think it is needed ? My reasoning is that if a clock controller requires a rail, it is preferable to explicitly specify the required operating level rather than rely on system/client vote. This makes the dependency self-contained and easier to reason about. Clients that require a higher operating level than the clock controller's minimum requirement remain free to vote for a higher level as needed. -- Thanks, Taniya Das