From: Brendan Shanks <bshanks@codeweavers.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] x86/umip: Add emulation for 64-bit processes
Date: Mon, 9 Sep 2019 15:34:28 -0700 [thread overview]
Message-ID: <317243DA-3BAE-4620-8E31-5F23145DD992@codeweavers.com> (raw)
In-Reply-To: <20190907212610.GA30930@ranerica-svr.sc.intel.com>
> On Sep 7, 2019, at 2:26 PM, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
>
> On Thu, Sep 05, 2019 at 04:22:21PM -0700, Brendan Shanks wrote:
>>
>> if (umip_inst == UMIP_INST_SGDT || umip_inst == UMIP_INST_SIDT) {
>> + u64 dummy_base_addr;
>> + u16 dummy_limit = 0;
>> +
>> /* SGDT and SIDT do not use registers operands. */
>> if (X86_MODRM_MOD(insn->modrm.value) == 3)
>> return -EINVAL;
>> @@ -228,13 +228,24 @@ static int emulate_umip_insn(struct insn *insn, int umip_inst,
>> else
>> dummy_base_addr = UMIP_DUMMY_IDT_BASE;
>>
>> - *data_size = UMIP_GDT_IDT_LIMIT_SIZE + UMIP_GDT_IDT_BASE_SIZE;
>
> Maybe a blank line here?
Adding a blank line in place of the removed line? I’m not sure I see the need for it, there’s already a blank line above, and it's followed by the block comment.
Brendan
next prev parent reply other threads:[~2019-09-09 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 23:22 Brendan Shanks
2019-09-07 21:26 ` Ricardo Neri
2019-09-08 7:22 ` Borislav Petkov
2019-09-09 11:56 ` hpa
2019-09-09 22:34 ` Brendan Shanks [this message]
2019-09-09 12:04 ` hpa
2019-09-10 6:28 ` Ingo Molnar
2019-09-10 6:32 ` hpa
2019-09-10 6:37 ` [PATCH v2] " Ingo Molnar
2019-09-10 6:41 ` [tip: x86/asm] x86/umip: Add emulation (spoofing) for UMIP covered instructions in 64-bit processes as well tip-bot2 for Brendan Shanks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=317243DA-3BAE-4620-8E31-5F23145DD992@codeweavers.com \
--to=bshanks@codeweavers.com \
--cc=bp@alien8.de \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome