From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / hibernate: Mark expected switch fall-through
Date: Sun, 12 Aug 2018 13:20:25 +0200 [thread overview]
Message-ID: <3172480.Efgj8VWSCo@aspire.rjw.lan> (raw)
In-Reply-To: <20180805021200.GA10911@embeddedor.com>
On Sunday, August 5, 2018 4:12:00 AM CEST Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 114713 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> kernel/power/hibernate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> index 9c85c78..38f3f96 100644
> --- a/kernel/power/hibernate.c
> +++ b/kernel/power/hibernate.c
> @@ -638,6 +638,7 @@ static void power_down(void)
> break;
> case HIBERNATION_PLATFORM:
> hibernation_platform_enter();
> + /* Fall through */
> case HIBERNATION_SHUTDOWN:
> if (pm_power_off)
> kernel_power_off();
>
Applied, thanks!
prev parent reply other threads:[~2018-08-12 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 2:12 Gustavo A. R. Silva
2018-08-05 9:34 ` Pavel Machek
2018-08-12 11:20 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3172480.Efgj8VWSCo@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=gustavo@embeddedor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®