mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peter Rosin <peda@axentia.se>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Andrew Davis <afd@ti.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Heiner Kallweit <hkallweit1@gmail.com>
Cc: kernel test robot <lkp@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Samuel Holland <samuel@sholland.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] mux: mmio: Fix missing CONFIG_REGMAP_MMIO
Date: Fri, 16 May 2025 10:58:38 +0200	[thread overview]
Message-ID: <3172aba1-77f8-46a7-a967-14fae37f66ea@linaro.org> (raw)
In-Reply-To: <bfe991fa-f54c-4d58-b2e0-34c4e4eb48f4@linaro.org>

On 16/05/2025 10:26, Krzysztof Kozlowski wrote:
> On 16/05/2025 10:16, Krzysztof Kozlowski wrote:
>>
>> On Thu, 15 May 2025 16:05:56 +0200, Krzysztof Kozlowski wrote:
>>> MMIO mux uses now regmap_init_mmio(), so one way or another
>>> CONFIG_REGMAP_MMIO should be enabled, because there are no stubs for
>>> !REGMAP_MMIO case:
>>>
>>>   ERROR: modpost: "__regmap_init_mmio_clk" [drivers/mux/mux-mmio.ko] undefined!
>>>
>>> REGMAP_MMIO should be, because it is a non-visible symbol, but this
>>> causes a circular dependency:
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] mux: mmio: Fix missing CONFIG_REGMAP_MMIO
>>       https://git.kernel.org/krzk/linux/c/39bff565b40d26cc51f6e85b3b224c86a563367e
>>
> And dropped. More recursive dependencies are detected, so my fix here is
> incomplete.
> 
> error: recursive dependency detected!
> 	symbol REGMAP default is visible depending on REGMAP_MMIO
> 	symbol REGMAP_MMIO is selected by MUX_MMIO
> 	symbol MUX_MMIO depends on MULTIPLEXER
> 	symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER
> 	symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_BUS
> 	symbol MDIO_BUS is selected by REGMAP
> 
> https://krzk.eu/#/builders/43/builds/4855
> 
> That's a mess, I need work on this a bit more.


My branch fails with above error because I do not have Heiner's commit
a3e1c0ad8357 ("net: phy: factor out provider part from mdio_bus.c").
Will it reach current RC (rc7) at some point? I could merge the tag to
my next branch to solve it.


Best regards,
Krzysztof

  reply	other threads:[~2025-05-16  8:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 14:05 Krzysztof Kozlowski
2025-05-15 14:14 ` Krzysztof Kozlowski
2025-05-16  0:46   ` Jakub Kicinski
2025-05-15 15:30 ` Arnd Bergmann
2025-05-16  8:16 ` Krzysztof Kozlowski
2025-05-16  8:26   ` Krzysztof Kozlowski
2025-05-16  8:58     ` Krzysztof Kozlowski [this message]
2025-05-16 14:30       ` Andrew Davis
2025-05-16 15:55       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3172aba1-77f8-46a7-a967-14fae37f66ea@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=afd@ti.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peda@axentia.se \
    --cc=samuel@sholland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®