From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, wim@linux-watchdog.org,
linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
quic_saipraka@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT
Date: Tue, 15 Aug 2023 16:40:15 +0200 [thread overview]
Message-ID: <3174c398-a19a-3b59-c2fc-3ec9a5e1a9df@linaro.org> (raw)
In-Reply-To: <20230815141908.1084893-2-robimarko@gmail.com>
On 15/08/2023 16:17, Robert Marko wrote:
> Add the required DT node for WDT operation.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index 3285c86824cf..168322bfb11c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> @@ -182,6 +182,13 @@ v2m1: v2m@1000 {
> };
> };
>
> + watchdog: watchdog@b017000 {
> + compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt";
> + interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;
I think all GIC_SPI interrupts are level high.
> + reg = <0x0b017000 0x40>;
Keep the reg as second property.
> + clocks = <&sleep_clk>;
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-15 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 14:17 [PATCH 1/2] dt-bindings: watchdog: qcom-wdt: document IPQ5018 Robert Marko
2023-08-15 14:17 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT Robert Marko
2023-08-15 14:40 ` Krzysztof Kozlowski [this message]
2023-08-15 15:38 ` Robert Marko
2023-08-15 21:33 ` Krzysztof Kozlowski
2023-08-15 21:37 ` Robert Marko
2023-08-15 14:34 ` [PATCH 1/2] dt-bindings: watchdog: qcom-wdt: document IPQ5018 Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3174c398-a19a-3b59-c2fc-3ec9a5e1a9df@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=quic_saipraka@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®