From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: "André Draszik" <andre.draszik@linaro.org>,
peter.griffin@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
willmcvicker@google.com, semen.protsenko@linaro.org,
alim.akhtar@samsung.com, s.nawrocki@samsung.com,
tomasz.figa@gmail.com, cw00.choi@samsung.com,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on
Date: Sat, 27 Jan 2024 03:51:22 +0000 [thread overview]
Message-ID: <3178cde5-32bb-4294-873e-44a993aef31b@linaro.org> (raw)
In-Reply-To: <20240127003607.501086-2-andre.draszik@linaro.org>
On 1/27/24 00:35, André Draszik wrote:
> This pclk clock is required any time we access the pinctrl registers of
> this block.
>
> Since pinctrl-samsung doesn't support a clock at the moment, we just
> keep the kernel from disabling it at boot, until we have an update for
> pinctrl-samsung to handle this required clock, at which point we'll be
> able to drop the flag again.
>
> Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0")
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/clk/samsung/clk-gs101.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
> index 4a0520e825b6..61bb0dcf84ee 100644
> --- a/drivers/clk/samsung/clk-gs101.c
> +++ b/drivers/clk/samsung/clk-gs101.c
> @@ -2848,7 +2848,7 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = {
> GATE(CLK_GOUT_PERIC0_GPIO_PERIC0_PCLK,
> "gout_peric0_gpio_peric0_pclk", "mout_peric0_bus_user",
> CLK_CON_GAT_GOUT_BLK_PERIC0_UID_GPIO_PERIC0_IPCLKPORT_PCLK,
> - 21, 0, 0),
> + 21, CLK_IGNORE_UNUSED, 0),
> /* Disabling this clock makes the system hang. Mark the clock as critical. */
> GATE(CLK_GOUT_PERIC0_LHM_AXI_P_PERIC0_I_CLK,
> "gout_peric0_lhm_axi_p_peric0_i_clk", "mout_peric0_bus_user",
next prev parent reply other threads:[~2024-01-27 3:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 0:35 gs101 oriole: peripheral block 0 (peric0) fixes André Draszik
2024-01-27 0:35 ` [PATCH 1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on André Draszik
2024-01-27 3:06 ` Sam Protsenko
2024-01-27 3:51 ` Tudor Ambarus [this message]
2024-01-29 12:54 ` Peter Griffin
2024-01-27 0:35 ` [PATCH 2/5] arm64: dts: exynos: gs101: fix usi8 default mode André Draszik
2024-01-27 3:05 ` Sam Protsenko
2024-01-27 3:48 ` Tudor Ambarus
2024-01-29 9:48 ` Peter Griffin
2024-01-27 0:35 ` [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8 André Draszik
2024-01-27 3:22 ` Sam Protsenko
2024-01-27 4:00 ` Tudor Ambarus
2024-01-29 16:33 ` Tudor Ambarus
2024-01-29 14:01 ` André Draszik
2024-01-27 0:35 ` [PATCH 4/5] arm64: dts: exynos: gs101: use correct clocks for usi_uart André Draszik
2024-01-27 1:37 ` André Draszik
2024-01-27 3:23 ` Sam Protsenko
2024-01-27 4:03 ` Tudor Ambarus
2024-01-29 16:39 ` Tudor Ambarus
2024-01-27 0:35 ` [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical André Draszik
2024-01-27 1:38 ` André Draszik
2024-01-27 3:30 ` Sam Protsenko
2024-01-29 14:37 ` André Draszik
2024-01-29 19:16 ` Sam Protsenko
2024-01-30 9:31 ` André Draszik
2024-01-30 9:39 ` Tudor Ambarus
2024-01-29 16:44 ` Tudor Ambarus
2024-01-27 3:01 ` gs101 oriole: peripheral block 0 (peric0) fixes Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3178cde5-32bb-4294-873e-44a993aef31b@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®