From: Scott Branden <scott.branden@broadcom.com>
To: Desmond Yan <desmond.yan@broadcom.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] misc: bcm-vk: Remove viper from device id table
Date: Wed, 2 Mar 2022 10:09:43 -0800 [thread overview]
Message-ID: <317b176b-e045-20ce-6092-f93e4b6ef5ad@broadcom.com> (raw)
In-Reply-To: <20220302025340.25602-1-desmond.yan@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
Looks fine - Viper not officially supported by this driver.
On 2022-03-01 18:53, Desmond Yan wrote:
> As bcm_vk driver is not the production driver for viper, remove
> its pci device id from table.
>
> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> Changes since v1:
> - remove Kconfig option and simply remove viper pci id completely
> ---
> drivers/misc/bcm-vk/bcm_vk_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
> index ad639ee85b2a..a16b99bdaa13 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c
> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
> @@ -1633,7 +1633,6 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
>
> static const struct pci_device_id bcm_vk_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
> - { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
> { }
> };
> MODULE_DEVICE_TABLE(pci, bcm_vk_ids);
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
prev parent reply other threads:[~2022-03-02 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 2:53 Desmond Yan
2022-03-02 18:09 ` Scott Branden [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=317b176b-e045-20ce-6092-f93e4b6ef5ad@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=desmond.yan@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®