From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S971077AbdAERON (ORCPT ); Thu, 5 Jan 2017 12:14:13 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:44887 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968778AbdAERLp (ORCPT ); Thu, 5 Jan 2017 12:11:45 -0500 Subject: Re: [PATCH v2 4/4] ARM: dts: keystone: Add "ti,da830-uart" compatible string To: Sekhar Nori , David Lechner , Greg Kroah-Hartman , Santosh Shilimkar References: <1483561814-21953-1-git-send-email-david@lechnology.com> <1483561814-21953-5-git-send-email-david@lechnology.com> <93c4aed0-6faa-2c27-7931-454fc1f48e79@oracle.com> <824238e0-b710-7146-b67b-b2135c2a8bd2@ti.com> Cc: Franklin S Cooper Jr , Rob Herring , Mark Rutland , Kevin Hilman , Axel Haslam , Alexandre Bailon , Bartosz Golaszewski , Jiri Slaby , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <317f1f81-74da-68ae-200f-42a969774ae8@oracle.com> Date: Thu, 5 Jan 2017 09:10:35 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <824238e0-b710-7146-b67b-b2135c2a8bd2@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/2017 1:04 AM, Sekhar Nori wrote: > Hi Santosh, > > On Thursday 05 January 2017 03:30 AM, Santosh Shilimkar wrote: >> On 1/4/2017 12:30 PM, David Lechner wrote: >>> The TI Keystone SoCs have extra UART registers beyond the standard 8250 >>> registers, so we need a new compatible string to indicate this. Also, at >>> least one of these registers uses the full 32 bits, so we need to specify >>> reg-io-width in addition to reg-shift. >>> >>> "ns16550a" is left in the compatible specification since it does work as >>> long as the bootloader configures the SoC UART power management >>> registers. >>> >> NAK!! >> We can't break the booting boards with existing boot loaders. > > Sorry, but it not clear to me how this breaks booting with older > bootloaders? If older DTB is ROM'ed, it will continue to work because of > match with ns16550a. > > I just verified boot on K2E with these patches applied and using 2016.05 > based U-Boot from a TI release. > > http://pastebin.ubuntu.com/23744719/ > Thanks for test. As long as it doesn't break the boot, am fine with it. >> I suggest you to first get the driver updated to take care of >> the UART PM register and then enable the support for it. > > Isn't that what patch 2/4 is doing? > I see that now. Thanks for clarifying. Serial patch needs to go via Greg's tree. I will pick up the DTS bits. Regards, Santosh