From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992734AbcB1B3h (ORCPT ); Sat, 27 Feb 2016 20:29:37 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:48900 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S2992640AbcB1B3f (ORCPT ); Sat, 27 Feb 2016 20:29:35 -0500 From: "Rafael J. Wysocki" To: Derek Basehore Cc: linux-pm@vger.kernel.org, Len Brown , Pavel Machek , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH v2 2/3] PM / sleep: try to runtime suspend for direct complete Date: Sun, 28 Feb 2016 02:31:11 +0100 Message-ID: <3183435.BG93qPHVgS@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1456359748-22838-2-git-send-email-dbasehore@chromium.org> References: <1456359748-22838-1-git-send-email-dbasehore@chromium.org> <1456359748-22838-2-git-send-email-dbasehore@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, February 24, 2016 04:22:27 PM Derek Basehore wrote: > This tries to runtime suspend devices that are still active for direct > complete. This is for cases such as autosuspend delays which leaves > devices able to runtime suspend but still active. It's beneficial in > this case to runtime suspend the device to take advantage of direct > complete when possible. > > Signed-off-by: Derek Basehore > Reviewed-by: Eric Caruso > --- > drivers/base/power/main.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > index e0017d9..9693032 100644 > --- a/drivers/base/power/main.c > +++ b/drivers/base/power/main.c > @@ -1380,7 +1380,12 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) > goto Complete; > > if (dev->power.direct_complete) { > - if (pm_runtime_status_suspended(dev)) { > + /* > + * Check if we're runtime suspended. If not, try to runtime > + * suspend for autosuspend cases. > + */ > + if (pm_runtime_status_suspended(dev) || > + !pm_runtime_suspend(dev)) { > pm_runtime_disable(dev); > if (pm_runtime_status_suspended(dev)) > goto Complete; > This can be done somewhat simpler, because pm_runtime_suspend() will check if the device has already been suspended: ret = pm_runtime_suspend(dev); if (ret >= 0) { and you don't need the extra pm_runtime_status_suspended(dev) check. Thanks, Rafael