From: Damien Le Moal <dlemoal@kernel.org>
To: shao.mingyin@zte.com.cn, cassel@kernel.org, hansg@kernel.org,
linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ata: libahci_platform: drop the dead error check
Date: Thu, 5 Nov 2026 12:12:47 +0900 [thread overview]
Message-ID: <3183b7c5-a461-4816-8f5a-0783c29e274a@kernel.org> (raw)
In-Reply-To: <20261104211439250EftPg5v8hldkC4dnKtOxA@zte.com.cn>
On 11/4/26 22:14, shao.mingyin@zte.com.cn wrote:
> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>
> IS_ERR(hpriv->ahci_regulator) is true here, so PTR_ERR() is negative
> and "rc != 0" is always true. Jump to the error path directly.
>
> No functional change.
>
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
Looks OK.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-11-05 3:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 13:14 [PATCH 0/3] ata: remove dead checks and redundant code shao.mingyin
2026-11-04 13:14 ` [PATCH 1/3] ata: libata-transport: drop the dead GSCR newline check shao.mingyin
2026-11-05 3:12 ` Damien Le Moal
2026-11-04 13:14 ` [PATCH 2/3] ata: libahci_platform: drop the dead error check shao.mingyin
2026-11-05 3:12 ` Damien Le Moal [this message]
2026-11-04 13:14 ` [PATCH 3/3] ata: libata-zpodd: use a single exit in zpodd_get_mech_type() shao.mingyin
2026-11-05 3:13 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3183b7c5-a461-4816-8f5a-0783c29e274a@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hansg@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shao.mingyin@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®