From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com [63.178.143.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A899633ADA9; Fri, 16 Jan 2026 17:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.178.143.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768584514; cv=none; b=RMNHdtfb1sm9DrLySK1WpYJBlYNL0oGKO4BjTlWAsTc4TdacWOXHlVTErZORSKe2NR3O9CZoqUESayYGsM8whzrxyMrApe14U2q5g+7oAOskUhatIW1qq7O8f0bG/ZBn6tYZqwOSlbXSIbmBx2gM/SKTZrVpKsrz/nS8mY3Jji0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768584514; c=relaxed/simple; bh=4v4BzucaIF1lo4RO/U0n/TNkpEdnblnTY4xoTJ1ZwN4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=pWt7ST1CU8m0yro3SbEuqlS8rd0Tw9ZzjuI3JheJuXmmfnMRuC9S2Z23zqeh1yCHeOe13Jt/Tbyje0Mh4rpJ2MKXr5z2TMElEAqA7E46p9qVY+E57pR8K5JBlSsBfNmYMVcFoeRswUg65XYJhcNC8JXdL8PftJlYetscUJftwtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=ZLRsFVDj; arc=none smtp.client-ip=63.178.143.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="ZLRsFVDj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1768584512; x=1800120512; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=iixAuY6QcleXCDLiS0osecYXCL2wD+IcnkmdhMNMceE=; b=ZLRsFVDjzKyBWAmAa9raNcUxUdC3DS4qoix1Ox/WxUWZ+Xc73vJBkpQu K+6Hq8H+N9Et1PLf0A+jOAU2uZg04cgglcjqROJ9rvBG7R+u7PyxFA5mS 3E3F1h99dHlf85Q+APayS1FpOFl2Z67EjkGdpdyexCuM9UnrZ+wjUN80x zI8mKFTLPsEQP3sYG3K0wQrpRR/IPLeXwy9652Ik3lv4YOgCBZNSCHYL8 1wr8+bV/ShsSeUzP2sEAFSc3HZSJkpS7Jyc/6xC/Kq9+UzZgC9lQYE7ed DNRx4jjFSXWabspNKcowIW7g/QqIHj56QzIWKctqDqqxqmKy4T7RSKA/M Q==; X-CSE-ConnectionGUID: Qy9RLilmSb6mwlMCH/r26Q== X-CSE-MsgGUID: FqlFUMb2T4mzbA9VY5PHdA== X-IronPort-AV: E=Sophos;i="6.21,231,1763424000"; d="scan'208";a="7924510" Received: from ip-10-6-6-97.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.6.97]) by internal-fra-out-010.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2026 17:28:13 +0000 Received: from EX19MTAEUC002.ant.amazon.com [54.240.197.236:17818] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.21.80:2525] with esmtp (Farcaster) id 2ee969a8-f047-4c24-83b9-0d6192b592bb; Fri, 16 Jan 2026 17:28:13 +0000 (UTC) X-Farcaster-Flow-ID: 2ee969a8-f047-4c24-83b9-0d6192b592bb Received: from EX19D005EUB003.ant.amazon.com (10.252.51.31) by EX19MTAEUC002.ant.amazon.com (10.252.51.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Fri, 16 Jan 2026 17:28:13 +0000 Received: from [192.168.12.13] (10.106.82.9) by EX19D005EUB003.ant.amazon.com (10.252.51.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Fri, 16 Jan 2026 17:28:08 +0000 Message-ID: <318407ba-ecb6-4691-8911-645fb8c20250@amazon.com> Date: Fri, 16 Jan 2026 17:28:06 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v9 07/13] KVM: guest_memfd: Add flag to remove from direct map To: "Edgecombe, Rick P" , "kalyazin@amazon.co.uk" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "kernel@xen0n.name" , "kvmarm@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "bpf@vger.kernel.org" , "loongarch@lists.linux.dev" , "linux-doc@vger.kernel.org" CC: "david@kernel.org" , "svens@linux.ibm.com" , "catalin.marinas@arm.com" , "palmer@dabbelt.com" , "jgross@suse.com" , "surenb@google.com" , "vbabka@suse.cz" , "riel@surriel.com" , "pfalcato@suse.de" , "x86@kernel.org" , "rppt@kernel.org" , "thuth@redhat.com" , "borntraeger@linux.ibm.com" , "maz@kernel.org" , "peterx@redhat.com" , "ast@kernel.org" , "Annapurve, Vishal" , "pjw@kernel.org" , "alex@ghiti.fr" , "dave.hansen@linux.intel.com" , "tglx@linutronix.de" , "hca@linux.ibm.com" , "willy@infradead.org" , "wyihan@google.com" , "ryan.roberts@arm.com" , "yang@os.amperecomputing.com" , "jolsa@kernel.org" , "jmattson@google.com" , "luto@kernel.org" , "aneesh.kumar@kernel.org" , "haoluo@google.com" , "patrick.roy@linux.dev" , "akpm@linux-foundation.org" , "coxu@redhat.com" , "mhocko@suse.com" , "mlevitsk@redhat.com" , "jgg@ziepe.ca" , "hpa@zytor.com" , "song@kernel.org" , "Liam.Howlett@oracle.com" , "maobibo@loongson.cn" , "peterz@infradead.org" , "oupton@kernel.org" , "lorenzo.stoakes@oracle.com" , "jhubbard@nvidia.com" , "martin.lau@linux.dev" , "jthoughton@google.com" , "Jonathan.Cameron@huawei.com" , "Yu, Yu-cheng" , "eddyz87@gmail.com" , "yonghong.song@linux.dev" , "chenhuacai@kernel.org" , "shuah@kernel.org" , "prsampat@amd.com" , "kevin.brodsky@arm.com" , "shijie@os.amperecomputing.com" , "itazur@amazon.co.uk" , "suzuki.poulose@arm.com" , "pbonzini@redhat.com" , "dev.jain@arm.com" , "yuzenghui@huawei.com" , "gor@linux.ibm.com" , "jackabt@amazon.co.uk" , "daniel@iogearbox.net" , "agordeev@linux.ibm.com" , "andrii@kernel.org" , "mingo@redhat.com" , "aou@eecs.berkeley.edu" , "joey.gouly@arm.com" , "derekmn@amazon.com" , "xmarcalx@amazon.co.uk" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "jackmanb@google.com" , "bp@alien8.de" , "corbet@lwn.net" , "ackerleytng@google.com" , "jannh@google.com" , "john.fastabend@gmail.com" , "kas@kernel.org" , "will@kernel.org" , "seanjc@google.com" References: <20260114134510.1835-1-kalyazin@amazon.com> <20260114134510.1835-8-kalyazin@amazon.com> <294bca75-2f3e-46db-bb24-7c471a779cc1@amazon.com> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJnrNfABQkFps9DAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPOpfgD/exazh4C2Z8fNEz54YLJ6tuFEgQrVQPX6nQ/PfQi2+dwBAMGTpZcj9Z9NvSe1 CmmKYnYjhzGxzjBs8itSUvWIcMsFzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmes18AFCQWmz0MCGwwACgkQr5LKIKmaZPNTlQEA+q+rGFn7273rOAg+rxPty0M8lJbT i2kGo8RmPPLu650A/1kWgz1AnenQUYzTAFnZrKSsXAw5WoHaDLBz9kiO5pAK In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D004EUC001.ant.amazon.com (10.252.51.190) To EX19D005EUB003.ant.amazon.com (10.252.51.31) On 16/01/2026 15:34, Edgecombe, Rick P wrote: > On Fri, 2026-01-16 at 15:00 +0000, Nikita Kalyazin wrote: >>> Does this assume the folio would not have been split after it was >>> zapped? As in, if it was zapped at 2MB granularity (no 4KB direct >>> map split required) but then restored at 4KB (split required)? Or >>> it gets merged somehow before this? >> >> AFAIK it can't be zapped at 2MB granularity as the zapping code will >> inevitably cause splitting because guest_memfd faults occur at the >> base page granularity as of now. > > Ah, right since there are no huge pages currently. Then the huge page > series will need to keep this in mind and figure out some solution. > Probably worth a comment on that assumption to help anyone that changes > it. Makes sense. I'll leave a comment. > > I imagine this feature is really targeted towards machines running a > bunch of untrusted VMs, so cloud hypervisors really. In that case the > direct map will probably be carved up pretty quick. Did you consider > just breaking the full direct map to 4k at the start when it's in use? That's an interesting point, I haven't thought about it from this perspective. We should run some tests internally to see if it'd help. This will likely change with support for huge pages coming in though.