From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751458AbeA2Rip (ORCPT ); Mon, 29 Jan 2018 12:38:45 -0500 Received: from mail-db5eur01on0049.outbound.protection.outlook.com ([104.47.2.49]:30560 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbeA2Rin (ORCPT ); Mon, 29 Jan 2018 12:38:43 -0500 Authentication-Results: spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cern.ch; Subject: Re: [RFC PATCH 0/2] check I2C device id for pca984x chips To: Peter Rosin CC: Wolfram Sang , , References: <20180122113657.32094-1-peda@axentia.se> <04535e9d-9ba4-2f27-e94c-12d877d26cda@cern.ch> <8549b310-ecfe-e60b-c7fc-fab7db2fd2f2@axentia.se> From: Adrian Fiergolski Organization: CERN Message-ID: <318dc907-c091-a883-bf0c-346f32a66723@cern.ch> Date: Mon, 29 Jan 2018 18:38:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <8549b310-ecfe-e60b-c7fc-fab7db2fd2f2@axentia.se> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [128.141.234.113] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:188.184.36.48;IPV:NLI;CTRY:CH;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(396003)(346002)(39860400002)(39380400002)(2980300002)(438002)(377424004)(199004)(189003)(59450400001)(2950100002)(6246003)(6306002)(336011)(956003)(186003)(16526019)(58126008)(26005)(65956001)(229853002)(66066001)(65806001)(53546011)(6706004)(74482002)(6916009)(786003)(16576012)(316002)(54906003)(47776003)(31686004)(83506002)(106002)(31696002)(50466002)(246002)(8936002)(64126003)(230700001)(2906002)(4326008)(106466001)(2486003)(36916002)(8676002)(478600001)(7636002)(23676004)(5660300001)(65826007)(76176011)(6116002)(3846002)(356003)(36756003)(305945005)(72206003)(966005)(7736002)(86362001)(3940600001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0601MB1908;H:cernmxgwlb4.cern.ch;FPR:;SPF:Pass;PTR:cernmx12.cern.ch;A:1;MX:1;LANG:en; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b27738fa-86d6-441e-328d-08d5673f2235 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307)(7153060)(7193020);SRVR:AM4PR0601MB1908; X-MS-TrafficTypeDiagnostic: AM4PR0601MB1908: X-Microsoft-Exchange-Diagnostics: 1;AM4PR0601MB1908;20:d0wbNlMn2492clEkh0c+BpZPoiQ78ysZ41HC/PICTcioTfOKNA92ZCh02o2Ha0ZU97SAdWYwREvqYh0k8KojmRJN5HBtHf6OIEzeohbLAWi3qCVWpXxo6YnvbzCkDBa5HPPYqDzpRmKDAnOfKGOTsTnpyS6jHBtyaLjGxPMv7NMvVY51MaeEhzvIONL63xGKd37wzY4tD8622QXeCkCnKGXFgGb2HGcxBhAPer5/LWftTagKastIafmisZlOryMQqh5+8lucOHyRn2vNHDpZpnXCWFF7z0GG/e1x7Bvpmr7xNRDxSkNmIA+RZXVwWEj7Oz9TuMVwX0xUCDDbHKlk+5bJCsjvzz4jO2Ilu3HWy9FsSXMBNzw9BrjYF79AtechH6VXxrtIoSvYRCUOW4opuKAwhsOLWOyEAg93PRcB/CyfzZlcPaWuCxaUROeXwN2aesuHRhBVmZ2FXCtmiWRACuTgfQzb0gE8icwvuL7ls3Lly+IiHtyPoSQ9g0NCK7H7;4:cD+ZoWf5LymVjb/SWsmXjG4jsDP+DmrXusXLifDCCGgRC+YWkMpyo+9bieAlgiMSnlUqe/e6GFnYUhTYN+H7I1KUj+p/ctSEL/p57lcQwgHS1XlwEcNu30Mk2wbj/tB0x6XQ9cwu5oEuvEzZR9r+XtCFtfSlZZQt6iUYYbpytq4lwNdqucP1KtSvQqyl+2b1C/55EQWkiGFQkXEZvlQOqDSTjT9yKwUYSNlk4sbe/003xbWz+nDmvTlMQ1xl9md/cgz7cgygeOKT5d8uyA47+8dNqVYWqH7WIuIKhPdISxgpdIOZsGGdnE5ceUM591li X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93004095)(3002001)(3231101)(944501161)(10201501046)(6041288)(20161123560045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:AM4PR0601MB1908;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0601MB1908; X-Forefront-PRVS: 0567A15835 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjA2MDFNQjE5MDg7MjM6TUtaRDVuRUdwaDhCUWJmejQxT3o0Njg2?= =?utf-8?B?RHlvWTlmVW14dCs2SmkrbHVBeGVWdVJDQTJBVDlRM3FYeU4yUmMyY3dRZjZD?= =?utf-8?B?Vko0V0FmMWtwZ28wNTV6cWhpWUZOb1poOTg1QkFubjVJZ3FCOFFlekJmMkRJ?= =?utf-8?B?ZGZrY1VRMVhiUnAxWUlNZWxJSDIxTk5DbW9JQ2o3L1hVOGhDNC80SmNTbi9Z?= =?utf-8?B?ajhnektTSmlmaitqZkhIUVBpcXhveHptUmVhVTk4YzJ0Y2Z4RUN2a1RRU3JQ?= =?utf-8?B?ZmpGVmU1RzRHL3Urc0xSdXp1MTM3T2pnM0lBUFhDU0hEbm1IbmZtQzZmY3lj?= =?utf-8?B?UDdOYnpsSUQvdDM4a01rM3BBZ21IeHoyMUtmb1J3OVhXTnF5SDA0ZzkyTC9H?= =?utf-8?B?cnRsZ3BVd3lldUhCYlo5Q2tta2tVckxMWjloa2ZyTnJYUVgwSGorWDcxR1cy?= =?utf-8?B?M2ZQODRuRENZVlcrVzE0YkJmZHY1V25TQXJwY3MyS0pyYlJqc1MxaWlMOExv?= =?utf-8?B?MmZHT0Q0WlVKK1ZZNDRBM25yYjQ4QUE5ZWRBMzZrR3RZclU0R3lyeC9aS2xp?= =?utf-8?B?M2lKZjl2d0pySjl1Y3ZNSjNCVDExOGhHbGREWWN3NUEyOUExVWcrbTFVSXZk?= =?utf-8?B?Skswd1diT1VpTmR2STYzSlJhcjVrQjdZS0dXa01BOTdYODIyaHZCL3FHVlFz?= =?utf-8?B?R0dXd1pNVFdIV0dTL0xjWkFLWVFWeFVnRjlmcWV0Z2h1OWk5RzNueFlwYkFU?= =?utf-8?B?Q2JML1ZDWUFZZ2UxdjFDYTVHWHV0ZmY4aG1qNnFHblBIUjgwMXVMMEh6ZVRt?= =?utf-8?B?UXdjOWdJQlZMSHNldDdJM0pqeHBqcFNzcCtBWExqQWRPTngwRTEvQmJTUzNq?= =?utf-8?B?NmNlT09WNU05ZDdianF2enQ1WXBYeUFNQ3hUMDlzQy9wcC8wUys3cTZTeHlH?= =?utf-8?B?WTlXdjVoQnoveEdhRGs4cWlmcGhyYThYemJvbTFVOC80TGI4c0MwVW1jbkd0?= =?utf-8?B?RTd6M3BmaXd2U2ZGVDRSM2lTU1gyVmdYdXltUFVZR3RsYWg4SlE0V1FQMXBS?= =?utf-8?B?blVCS2NPR0FuSHBNYVpZZHFSVTFoVytGVW9UZGU1a3hLRFk2VnVOS1pQeEhj?= =?utf-8?B?OGRVdlVEUEhPQ3phbWJ4a1U1R3VEbUY1Zkc4RHllNkpQQTJTNVZrTjFOaW53?= =?utf-8?B?NTVJb1hoTE5uRUVoRUltN09wNDlZN3VNcitqNEh0Z0tzZFpNdTdNSk50WXd2?= =?utf-8?B?L1Vqc05iQUdrSEduS0NqeVpzT2ZRbU4zMXJia3JzZTNqTVE2UWhUMVlHQmNz?= =?utf-8?B?Z2pSWDJaeWZWSjE0TU1xbitVRkpLYXZkUmpZNHpFQUNLOWx6WGYzYWVCSFAy?= =?utf-8?B?cjVidlRCdlVjdkZSblhiOTk1aGp6QVZOUzF3TUhodys3UlBSdWNwWTZOdHVU?= =?utf-8?B?ZHl3cjByZCt5Zk1VSUp5SnQ2R1hCOFRWNm5LVzVZdFV6NU91aWdXQnlVWUNF?= =?utf-8?B?a0NLaVJxV3M3U0FuZjJ5YXc0aGRLbGREUUNtd1ZQeVdLTnYzNnhWYjFqT1NR?= =?utf-8?B?VEVaKzkySXZqWXlBaXdzMndkUVdhYnBqZnE1U1F3ZHQ4b0tpTGYxS2ZEMUZH?= =?utf-8?B?V3FIb3AzWDN4WHphaVBGZXlxdE9pVytDUE5IcVhxSzhtL20xK0VaOE9ISlpn?= =?utf-8?B?S3ArLzRaT2VlRXFtdE1CVUsveE9LOXRQVkdvSkh3SWF3L3Q1QWxLSUhlRzdh?= =?utf-8?B?cjYzdk9qOGpYbFFxR2xBc3N0ancvNVNrMmZ0UXBnTmZnSG50YXQybnJjVWNs?= =?utf-8?B?K0s5SUtuWmQ2TFlURi81a0VKK3hBS2NOd2Y5eE9rcTNGMEovS3o2b3oyTXov?= =?utf-8?B?c2pQUWg1bGp4bnpKQW8yeUpMbm02T2w5cDdtREFKVlgvb1NjN2FsOXl4ekdh?= =?utf-8?Q?t60+yl2dg00ZTlyCd1fXg28JKZhCDpRc=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0601MB1908;6:MJMdWd5wXF+5MtXi5gxs8/Bu31WL5j9DuzftZflzcTL41F6y6hm7bSsN9ImNIbV4qt8hRnXSalA0lJmxSS5NvdOVuNmuB4kRO2Q9x7agJ1sBA+1OBl9iJ//NiN92FdWroyoKA9gnBA+nHtvIJ3DNLx0DQsTyuGsTp6toyvZGtrqN4n57Qjg59kS+EaAkBBvJZs2zch/DC0xGIB373ngJsazdIdPJErwnMy4jgBP8HJF8X28l7beS5pe2UHykXIZenWCgdm/r7jft2bpegrnlxQHOm8zx+igJAvBxKkB8pEaFR4EKO+958o+Ml9ARxnS9eQFBwuKwablkQz+vklcVWhZ8ekFVIvvu+3C86AGOyR8=;5:lCW69LH2Dj7BWaum/rltFhJQ4bTDInQZs4GTavKav5+9Ai9us9iwKrI64TqMXC8pbACtS6lSb/hWiHttuk51V6T64Chjzn/I/cTJX/eLbt9IbEJFyxACQ0tQjWiaRIVDfPkvze2ptipI1gKK786CJRVW6XniJwge4r2vnfy1Wag=;24:1soQunp+ZFmnc3lz1sKvS2q5tFALTKGxmEYQ/L7dZpBpugHiepcCCWcxqKUzoyJb0CN1+eyLskeRu5YCJEoxDX36tKT5/AMiPxsw25Z7QBU=;7:vA3qy3/1D6zPLrpxIMNmQN2EStqnoeTho1yagrypnw6go2M6FZ4cGvgwUvgI3+0BHiyZDHGmEOq+pOcFo9XY9wxf3TzadBGPU3P25l1t8L998zD6AuMMaruS0CaQmSW9Hf9WXgjdeEb06tXgssL6DuJQpV9ufpmsMSnqiCdtZiUCrgLi1AV6bZg3XfyypeUUxzwTHbFG53+Su0aOJM9dA86BnADvJ9yshJyfA5t700zpxbD5KGosG9pci4Tdszkg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cern.ch X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2018 17:38:39.4336 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b27738fa-86d6-441e-328d-08d5673f2235 X-MS-Exchange-CrossTenant-Id: c80d3499-4a40-4a8c-986e-abce017d6b19 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c80d3499-4a40-4a8c-986e-abce017d6b19;Ip=[188.184.36.48];Helo=[cernmxgwlb4.cern.ch] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0601MB1908 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.01.2018 at 09:37, Peter Rosin wrote: > On 2018-01-26 17:33, Adrian Fiergolski wrote: >> Hi Peter, >> >> Sorry for the late reply. > No problem. > >> Yes, it's true I have one of the chip. However, my yocto based build system >> depends on https://github.com/Xilinx/linux-xlnx and it's in version >> 4.9.0-xilinx-v2017.3. >> Apparently, there were some bigger changes in i2c core between this >> version and >> upstream, thus your patches don't apply. > I think the core changes fail to apply mostly because of the file renaming > that has been going on, and that it should be fairly trivial to adapt. > But I don't know for certain... > >> Next week I will try to align only me i2c subdirectory with upstream. >> Provided it compiles, I will >> try then to apply and confirm your patches. > I'm looking forward to feedback, thanks! > > Cheers, > Peter > >> Regards, >> Adrian >> >> On 22.01.2018 at 12:36, Peter Rosin wrote: >>> Hi! >>> >>> This series tries to check the I2C device id, but instead of open >>> coding the check in the pca954x driver, I have a new function in >>> the core doing the work. >>> >>> The code is only compile-tested, hence the RFC, and I would really >>> like a Tested-by: tag from Adrian who presumably have one of these >>> chips. >>> >>> Also, I'm not sure if I should list all manufacturers that I know >>> about in the header, or if I should settle for the one that is >>> actually used and leave the others to be added by whomever needs >>> them... >>> >>> Cheers, >>> peda >>> >>> Peter Rosin (2): >>> i2c: add i2c_get_device_id() to get the standard i2c device id >>> i2c: mux: pca954x: verify the device id of the pca984x chips >>> >>> drivers/i2c/i2c-core-base.c | 33 ++++++++++++++++++++++++++++ >>> drivers/i2c/muxes/i2c-mux-pca954x.c | 43 +++++++++++++++++++++++++++++++++++++ >>> include/linux/i2c.h | 30 ++++++++++++++++++++++++++ >>> 3 files changed, 106 insertions(+) >>> Hi Peter, I have tested your patch with the pca9846 device and I confirm it works. Moreover, after short debugging, I can confirm that all read ids (manufacture, part and die) seem to be correct. Moreover, in case of misconfiguration, the probe function return a proper message and fails as expected. Regards, Adrian