From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96E93F8714 for ; Fri, 10 Jul 2026 09:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783677015; cv=none; b=nFLmhil6uQCMbRrIcM5EoFaW9aMkV3wRBKggKoELttnIBrnK5n8vci8fy8cQeySCqtZpAXD2WEs4BG++u4iSfMFkSL9N0kshg8ZJ/hLp/3GntWNA/5yfrVHKTma3DSVD6NrHZ1byBCiJcPH9KPJR2kl59u00Lo8i2X/mUxRz5mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783677015; c=relaxed/simple; bh=QKMu5NmGaOO2W0KX69/PxFjkByiQoEj+2qxAeN2oiLg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NrdwHjYuzLp4Yn/LFmxfn4OuqnzvVEZvg5PTwirI5+rMlbt9aJclD/xXqCeTe3f/BrwKVWMFoaaTWnv/OodEy5VlNKG6fquZb4OGLaEU2wG3OFc1qbT/qQ9VwTgd50nGPOdG5TElrskQKfytfnO5BZ4xeqgOULOg3uFMXmiq9LQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TCjeYyxt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A/eGUARl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TCjeYyxt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A/eGUARl" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A7dYrf056517 for ; Fri, 10 Jul 2026 09:50:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yLjfNKn8LnSz2XFrVVI8/j3tvyUWqMbqdwNr8lAk6oE=; b=TCjeYyxt2uUJ2vtw /UbmyqltkiGL0af9Zu9Gy6NDi2J8vmczKisc4AlHagWo7sIUOB+wwEu536JCwyGy LrQ/fFVJ3zj0XCvYkkFxvkMOwQMQyR50Lx5JZF+kJJvw8yEuB++TxqAvWDNaszJa Bh9Z7+8DQdSQX3UZ3Z8jU15d3RFkJWp99Cy84Qq8/9hLDWJaHhyiS6wo1G+AgdC0 F/mCRQfN2Y1iu2m+5H5mU3INESUf7p4cMR6io2edev+3qc7N/9GKROOEVIfObAJZ M9Mv2JhXitdeNmyrPzKK11X307epV6K7F9HhoLG6b+qzk6AYYXuo2U8rEB19McZk rCoeQA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fajwtaeu0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 09:50:13 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-903694fd3bfso406816d6.1 for ; Fri, 10 Jul 2026 02:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783677012; x=1784281812; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yLjfNKn8LnSz2XFrVVI8/j3tvyUWqMbqdwNr8lAk6oE=; b=A/eGUARlR8mZ5XolISG2ul4HPqND5iIor56MjEOxA6lTNTcRGHhmq9/nq7FDErjL2G OYYKKj+jDmjV3FtkH2XX4jGXoxkX70/YpNMACZYqm2ISjHCqPu5TttnsaTGsDvG72vuq AfH66hgP9ywqshZ2s3XjdKbRCRXYak7nRIBrq3hOmI+hnG2L2XdwMBFdozV0TAgsc+BG bDHdI77xaBaJ+zIwyP1wPYt9lkWGfvoF0o+MtH8YZu2uEWRycUXahEiiezLkX3CbRr8c eXuGH4qFC9e0KiM2EkXmMFjYU84MihgQ5MSmn1r4ABT06xXtz0pYva0xu9TvGZn35E4m wMWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783677012; x=1784281812; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yLjfNKn8LnSz2XFrVVI8/j3tvyUWqMbqdwNr8lAk6oE=; b=NVX3sa9vN1HA21bbblSYfskTORbLN0xuzkZuY/taNZxarXMs82UmDWl4pFL7rFF4Qa cSrWUTzGlUmJ1JvDhsWWI659EE/O27lpngULenVgA3m5rUmn1KIv2skKwvojqLfE1iox ix4QQSM2z1n2M7HI1VfmmBFhl8v/aqjWPsgpvWBEVSJcPoTatKBH0bqUUVKsNhwhvAIp 28wubG1zdAWHNaLUWtnwGK+iGYeopSorUXETairb6xJmI1v4c0+Ak+kWDLqDmKaRubt7 vNsyXVOuhuf8f8spSu95Dtg3j8ExLl5ZrZ2IpJmzkXZ7dvuVw2G3jUguArthGIA3OFft cZtw== X-Forwarded-Encrypted: i=1; AHgh+RovEqAyJb453BxHKkk/cw5MuGUoiWnFesRrDnzldYJYLu6GEpc3AFVUMaFDtr7fBFfYBEKA6f+nL5oEoKY=@vger.kernel.org X-Gm-Message-State: AOJu0YzPiXvGxvk3UfzsRaUzUZY5GyvYQjVucJjgLVxElunQGPjnQFYo zfr3UwV3urYmuaJXjdQv9zGu++rfWP4FOcmJqV3Bh5p/sh0w/zi9i0EVm9dKqQuiePHH/NtUaiS oe4tcH1HZHd7kpc/5tybRvn7EmQislCkcBnsBaTl+5JQJF0SGCJ9Ts+qyDgALb7ih7cc= X-Gm-Gg: AfdE7clqIfCyv+g48lhFS2r5H3cZf3uXmUij2PiQG88yGlzl1xLcg5w6grk2c4lhGdc Qr9gTwB5HMJxU3llPCEZWuIjdDuXeqzaBVgK6wn41PoWTUo36poWf/zNaC9iQDaHciBXGk4+EqW hWUJgYjkxdg2Z19Vr38oMKab/hUwKZh7CyWWzTBAIeR9WaLCUjSxDsC1VhLjEqoKqmayCNHz5l1 jPjkg6So7jfcTGAy5Wie6wIVhd4VXSMU9Uo8bs6a7LhByyGzFm5wvrVoWf5/igazzzmGpqafbPM TSQKPZhkJX1jWPU/7JQepGVO79tvy0sDOg2OSEC7lqfNcNK+4jjGEqtoLyDYBKlk3FiVr2jMaI3 +oc5E3wGS1FRPn3vKcxwbu+FLizJOlcaPsT8= X-Received: by 2002:a05:6214:40e:b0:8cb:e65c:e527 with SMTP id 6a1803df08f44-8fec5b45e37mr97535846d6.1.1783677012137; Fri, 10 Jul 2026 02:50:12 -0700 (PDT) X-Received: by 2002:a05:6214:40e:b0:8cb:e65c:e527 with SMTP id 6a1803df08f44-8fec5b45e37mr97535656d6.1.1783677011733; Fri, 10 Jul 2026 02:50:11 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19ce4b4fsm10518512a12.10.2026.07.10.02.50.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 02:50:10 -0700 (PDT) Message-ID: <31905a48-54eb-4693-8725-71f065a8bc92@oss.qualcomm.com> Date: Fri, 10 Jul 2026 11:50:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] arm64: dts: qcom: glymur: use Aggregator TNOC compatible To: Jie Gan , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260710-fix-tracenoc-probe-issue-v6-0-41eb36fef8d9@oss.qualcomm.com> <20260710-fix-tracenoc-probe-issue-v6-5-41eb36fef8d9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260710-fix-tracenoc-probe-issue-v6-5-41eb36fef8d9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XOYAjwhE c=1 sm=1 tr=0 ts=6a50c055 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=HHMlELgPwHXHAMwrrFEA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: FgtHESi4R3iKMNlYo2_YLPznZtfb9Ygh X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA5NiBTYWx0ZWRfX9P+UaHdT+g9W kphmPPZc+sYuKMSfMAW5ljeGBZOP2QYlnXYOq6kk9/QnfL2WHOMM7vwELumZGAy7Taa05q5uniV 0v8XQGJGcTbP+XbhEq/c3DW/BDskv54= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA5NiBTYWx0ZWRfXzTOBaGMxz2nz uoNaLwLuaCGpSF8YvTVzbMk0D7a9V9PvmYAjO1x/EHPNpC5ZIcmW+zlp3whyEsbwFEYYrgcVVCe 50lNiCrhK/ifavNLXRJU+EI5SEu+BEKahsuiIyumw8986MCG0Ott7wdtVeHZqJ97SkA/uLWD/9q 97vhK+Z1s2e9Cx6OCWh6GRIs/DSt92dkA+/rjWpN6/V13DTCdUWqH4bKP4ct+YDys7+dPg+Z0jb 8mHAeDkkTd2RJnLSXs2y3Db82RFnJ8iiHYiTBw6vGbXmRxFNCLd2dsB0qUT4sZXlV+hBeNigc3W jDLz357cJtTdvjJV0DPBYHtmAakEeeZF/NTxScD12qFMRE/L9iRKlXDJ34Xfnacr2grE0enS75n sB7b9Uv8eYBGw8AvcSE6oebaG2ycOEip6O0ww4HbxuN49z5a1f+N9K1DNZ8+9Iklxv8npJDy+nv CfdMV6uq8Od9FUf5Zag== X-Proofpoint-ORIG-GUID: FgtHESi4R3iKMNlYo2_YLPznZtfb9Ygh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_02,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 priorityscore=1501 clxscore=1015 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100096 On 7/10/26 4:39 AM, Jie Gan wrote: > The traceNoC node is the system-level Aggregator TNOC, so it must own a > valid ATID that tags the whole aggregation path. It was marked compatible > with "qcom,coresight-itnoc", an Interconnect TNOC, which is never assigned > an ATID. As a result the aggregator had no trace ID and could not tag the > merged trace. > > An Interconnect TNOC is a subsystem-level aggregator: it merges trace from > the ATB sources within its subsystem (TPDMs and other ATB masters) and > forwards the combined stream to the system-level Aggregator TNOC. It > carries no ATID of its own, because the Aggregator TNOC downstream in the > path already owns the ATID. > > Switch the node to "qcom,coresight-tnoc" so it is described as the > Aggregator TNOC it is and is assigned a system trace ID. Rename the node > to "tn" and use the "apb_pclk" clock name as required by the Aggregator > TNOC binding. > > Fixes: 1f7d0c42a08d ("arm64: dts: qcom: glymur: add coresight nodes") > Signed-off-by: Jie Gan > --- Reviewed-by: Konrad Dybcio Konrad