From: David Howells <dhowells@redhat.com>
To: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn,
kjlu@umn.edu, Xin Tan <tanxin.ctf@gmail.com>
Subject: Re: [PATCH] afs: Fix afs_cb_interest refcnt leak in afs_select_fileserver()
Date: Tue, 26 May 2020 17:18:59 +0100 [thread overview]
Message-ID: <3193793.1590509939@warthog.procyon.org.uk> (raw)
In-Reply-To: <1590415886-52353-1-git-send-email-xiyuyang19@fudan.edu.cn>
Xiyu Yang <xiyuyang19@fudan.edu.cn> wrote:
> error = afs_wait_for_fs_probes(fc->server_list, fc->untried);
> - if (error < 0)
> + if (error < 0) {
> + afs_put_cb_interest(afs_v2net(vnode), fc->cbi);
> goto failed_set_error;
> + }
Ummm... Did you try this? afs_end_vnode_operation() should then cause a
double free because you don't clear fc->cbi.
You can try it by installing the kafs-client package if your distribution has
it available and starting the afs.mount service or doing:
mount -t afs none /afs -o dyn
and then:
ls /afs/grand.central.org/
David
prev parent reply other threads:[~2020-05-26 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 14:11 Xiyu Yang
2020-05-26 16:18 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3193793.1590509939@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=kjlu@umn.edu \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tanxin.ctf@gmail.com \
--cc=xiyuyang19@fudan.edu.cn \
--cc=yuanxzhang@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®