From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00CA022A7E4 for ; Mon, 22 Dec 2025 17:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766425524; cv=none; b=PZj3HKNPBT7HyvWzGmrZ80qSLvoGkHDS4TA/VGG7Ii14rrkdi6pKt9YgKzmOZrC7MqVZyppCKZMMyrE/mpBLtQ3uY8BMz8hsBnwaiwg17+U9bPgKiquSEg9NoaLVKlsQo471GgOfh2xs0nfTz4hESdRa3ZT/uuQ559QClUJLxMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766425524; c=relaxed/simple; bh=mDcYHWWDFCZ8abX9mVhTIcxFXGToPYmyE1T1wNNsIEM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CluvaR5cr1iqiXeqevKqaYfmEU7PtSIDinpX9iDptdVCiSLahPmRhEZSl6I2rt11f7s41JBAtfTny43MdOQ2fixfTcHfE0FO+hSmTJkh3KeCdbJrSJDQHIChqr9G5yPtL6Z3g0+5s4IyWFmMMtpNKyV6vPXM5aJHGdncsitlnb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XCiVEhEQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hQ1Bg4o7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XCiVEhEQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hQ1Bg4o7" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BMGqrhG1901863 for ; Mon, 22 Dec 2025 17:45:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xNreFgwKVVrMQp9bKV36Cv+4AeGfdYFXYCSfOTeRS/Y=; b=XCiVEhEQBzgMg1Td p/ZesAYpTQDZLgHUW+dBDIz6/9OMx2eBGLwTwAO5APTppzX5K++RMNAhyKpM9REX N+UINCelzSrq3uQT+tfy7wK/SYT160zat1fIWxh9hLmBS9fDdLhPaUAQHm+FiIQs JWKUa5hjFS0jZ4ksXjIB8vpOfCBKlnbmEl0HupChADqHL58JmzENyy9FMWiyS23s ufRj5E8m0WzY6LOB7pHsI/9H6Nu/BZWqN8EVPtqQETh2lWFSbm6LVXhqjgg6EQVi picuDhsurkVN8fPS88TxlpYBtbXyIdDKRoT+I0WHJRDrc+krAWrHAPDu7VWpeuC9 2Me4xA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b79w8g4mq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 17:45:21 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7b952a966d7so8736401b3a.3 for ; Mon, 22 Dec 2025 09:45:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766425521; x=1767030321; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xNreFgwKVVrMQp9bKV36Cv+4AeGfdYFXYCSfOTeRS/Y=; b=hQ1Bg4o7LliVbiCq6e6zFe8GkRad4CamgR4ZVAN9gPBy35/3FkNs/na4Ydkdlp4EX6 8Utr3C/R3xnXUGy1WuXalciOq5cY2WlnlqKCNuu8NKVwClyLdU7XSEQCDD8aM+fBySES +Qc7dhhBudyN2sB0Dw1dtT+o7vwhBgMtymrdnWI09C7bovPV+UeqvtM9mzj3f+DqCKuU lcicagcHROX8XBsJciiFMZCKrE7oZts7tBRlpHNXTYHp5B1e+TPnUkIMg369nWP6HERr Dcc3k602NUK+oJxzwagn5zoiaivgJRcjdGFa34MyK5kE8C5ugghs2Ur8uTrMjo/M+vAe bq8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766425521; x=1767030321; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xNreFgwKVVrMQp9bKV36Cv+4AeGfdYFXYCSfOTeRS/Y=; b=m+yglkdHQvIF3RzBir8ccLbBJXbdo54R3Vx6HDFRKoBNRZmD5oy/njxEHmHaMlr8t7 OscnOdAQo6+ZKDFMIXXZomnhy+v7qpKfBoBBVycIAww7W8hAz6rfBM/KUDmYqGrbdFaH D6XC/synEB8+VuHffSFgwfOEKZfSZ1/kcbs9ocH/sqoFZioT7daGYTEAbEvwe//0U9TU 1IFD0N29wguTnQybjmN78RbesJIFkRmsFOolrL0IyiajT7+ISVuXgPb6bFbawqUqEkMf qBXd3fBi15jmPiFZuVmNE5v6ozrAIRyzBGpFDkLeBqRL/DcBf/zHfFhp1qiVstbaRNQW Zhtg== X-Forwarded-Encrypted: i=1; AJvYcCWj4eaFQk+xwgNVkiC2vcwQK1xpCl3GFZ14pMSdL3LYoi6t0OGq9TzynF0qxWEGYdIxLU+LHG1vOwCjIH4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7ddLu3xOg5a54n3W+QI232odvYV2Gbn5hU6qzAYwCn5bH8GfX X2tDvOGrVsbAU4LRkIZx1wHB+Ye0xf+QCicJBa1vGiL/XVy5Y0jkOKfPcWtPCOZCu6o//BZ7gsf AZwZTVw9b9xx0qV4elsHhx8aP/3cjxWDQLzS7IFKGJ80pLXpqy5u9mdmgbBEk3xOqGVI= X-Gm-Gg: AY/fxX6+lybNI6hMLa7HeW2ybVdgDdr7uxZzazaMkXO3uyPiGKFrzy1xQ4fjW2KRxfF fNaBnOxsXg8M7KW7RaMTcqJNHYfpNjZIa+SzqpIG8/2d78CHFXug7NgY1H/PxdA4/GBQMr3Bslf Vg7k86uM9yFaRo1bxbhtUsFg/Al3QI9ya3he7n3fo8aiZhT6AZxEYCONhG3hmHR3dMBRPpg9srE jAYwAxDvpqwA9i4J+0gnP0HN5Lx5GbIqUeBEg71QL72NRbg92+lEk73XV3KUneBBBzyHN+6dQQr EQWvpGamWitQhJS87bL0KX83k19jacvDLtPinr50C8wk8Mdge4+ALUUKgOzl7FNLe/G9PzDTw4d 7JBK2jfqZzMXH+dFNDqEaMiYtYEv57Qh19Ks6 X-Received: by 2002:a05:6a00:3c8e:b0:7ff:ce33:e6b0 with SMTP id d2e1a72fcca58-7ffce33f6f9mr10410975b3a.10.1766425520799; Mon, 22 Dec 2025 09:45:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGSjEA9ajFMNhJnx1qyt2wsBG0dEQR3s7oZFVNUtpfNlBwxwsb7uE5zp34TNadcX7aJYIR1sg== X-Received: by 2002:a05:6a00:3c8e:b0:7ff:ce33:e6b0 with SMTP id d2e1a72fcca58-7ffce33f6f9mr10410942b3a.10.1766425520287; Mon, 22 Dec 2025 09:45:20 -0800 (PST) Received: from [192.168.1.5] ([27.57.93.98]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7a843ee4sm11188529b3a.10.2025.12.22.09.45.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 09:45:20 -0800 (PST) Message-ID: <3193e3e2-2b00-4c7e-a84f-86616c3666d3@oss.qualcomm.com> Date: Mon, 22 Dec 2025 23:15:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on qcs8300 To: Krzysztof Kozlowski , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Raviteja Laggyshetty , Dmitry Baryshkov , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20251128150106.13849-1-odelu.kukatla@oss.qualcomm.com> <20251128150106.13849-2-odelu.kukatla@oss.qualcomm.com> <4930a0ad-258c-45ea-99a0-753cb3c3ba6b@kernel.org> Content-Language: en-US From: Odelu Kukatla In-Reply-To: <4930a0ad-258c-45ea-99a0-753cb3c3ba6b@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDE2MiBTYWx0ZWRfX88dg9BnWuLzZ pH/78qaecP2D6OdWFveCA2S+Y3r5rpSrDaiX5uDCpzlrrW5GGkdwzG9au1GEHuq4gHFsEo7VSkx X5mGZ7aLRevL6CZ2hjBl9OuQukfGPxDBfDu5WP0r4v7oIEmzokyWucgIZXOVKibG5PndiapbZ8n Fwp6lAgcJrg/zZ8lcSR6WlMc3GT8pTDQ6cEhaAmum835yoiK7PR5uYQ+WDAIBNX+GOKM5+MBx/u OLis6YCV2V0nz7PJbcQkjqhL7DpiGY2fnCQipQnrM01AHhuPQIGuqmXJ39RDMZE96YMn3qxh2cz tmgvnUWdEUu68co85XmjdIo1ox4O/4PKv6d4T4gJAG50H8m7ukVcIQ+NCn6H6mXy7IJE4qU8tWe emhqjo3oBHSv0PlRdQGKnfqfmxHc+yIFTVSsOpNwX9C6nVo3WflWNDb/gfM9E9a8TH+Fiow77Vf qVF5G5jKRM7RkB2DDbw== X-Proofpoint-GUID: m2tZzeuDe4OLNeHehGXdsfDSmAxxNo34 X-Proofpoint-ORIG-GUID: m2tZzeuDe4OLNeHehGXdsfDSmAxxNo34 X-Authority-Analysis: v=2.4 cv=T/eBjvKQ c=1 sm=1 tr=0 ts=694983b1 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=luqpl2TCSyK2LuNNAmtdDg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=izIGmOzjKg6u1_hBuywA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=i6qsmYmKKdoA:10 a=csto0wWSG80A:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-22_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 bulkscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220162 On 11/29/2025 3:15 PM, Krzysztof Kozlowski wrote: > On 28/11/2025 16:01, Odelu Kukatla wrote: >> Add 'clocks' property to enable QoS configuration. This property >> enables the necessary clocks for QoS configuration. >> >> QoS configuration is essential for ensuring that latency sensitive >> components such as CPUs and multimedia engines receive prioritized >> access to memory and interconnect resources. This helps to manage >> bandwidth and latency across subsystems, improving system responsiveness >> and performance in concurrent workloads. > > > Same problems with your previous and other commits: > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > "on qcs8300" is redundant. Prefix defines that, so use proper prefixes. > You do not add clocks for every interconnect... > Thanks for the review and providing pointers, I’ll address the prefix issue in v2. > Best regards, > Krzysztof