From: Randy Dunlap <rdunlap@infradead.org>
To: Steven Lung <1030steven@gmail.com>, mingo@redhat.com
Cc: peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/pelt: Fix bracket typo
Date: Wed, 8 Jun 2022 08:33:40 -0700 [thread overview]
Message-ID: <3193fcc9-c672-19d9-a2e2-ad67809dd20b@infradead.org> (raw)
In-Reply-To: <20220608150008.57629-1-1030steven@gmail.com>
On 6/8/22 08:00, Steven Lung wrote:
> The second bracket describing the range is inverted, this patch
> will fix it.
>
> Signed-off-by: Steven Lung <1030steven@gmail.com>
> ---
> kernel/sched/pelt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c
> index 0f3107682..ed82cfba9 100644
> --- a/kernel/sched/pelt.c
> +++ b/kernel/sched/pelt.c
> @@ -233,7 +233,7 @@ ___update_load_sum(u64 now, struct sched_avg *sa,
> * When syncing *_avg with *_sum, we must take into account the current
> * position in the PELT segment otherwise the remaining part of the segment
> * will be considered as idle time whereas it's not yet elapsed and this will
> - * generate unwanted oscillation in the range [1002..1024[.
Is the above the same as range [1002..1024).
? I.e. 1002-1023 inclusive (or 1024 excluded)?
> + * generate unwanted oscillation in the range [1002..1024].
> *
> * The max value of *_sum varies with the position in the time segment and is
> * equals to :
--
~Randy
next prev parent reply other threads:[~2022-06-08 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 15:00 Steven Lung
2022-06-08 15:33 ` Randy Dunlap [this message]
2022-06-08 17:24 ` 龍帆軒
2022-06-08 19:27 ` Peter Zijlstra
[not found] ` <F0C192DB-6043-4629-A009-DCB4BA33A9A9@gmail.com>
2022-06-08 18:41 ` Randy Dunlap
2022-06-08 20:14 ` Vincent Guittot
2022-06-08 23:12 ` Steven Lung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3193fcc9-c672-19d9-a2e2-ad67809dd20b@infradead.org \
--to=rdunlap@infradead.org \
--cc=1030steven@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®