From: Keith Owens <kaos@ocs.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org
Subject: Re: 2.6.16-rc5-mm2 - kzalloc() considered harmful for debugging.
Date: Thu, 22 Dec 2005 16:05:42 +1100 [thread overview]
Message-ID: <31970.1135227942@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Mon, 19 Dec 2005 02:20:59 -0800." <20051219022059.36443421.akpm@osdl.org>
On Mon, 19 Dec 2005 02:20:59 -0800,
Andrew Morton <akpm@osdl.org> wrote:
>Or we could special-case kzalloc() and kstrdup() in slab.c - use
>builtin_return_address(1) if builtin_return_address(0) is within those
>functions. Dunno if that's worth the fuss though.
builtin_return_address(1) on i386 only works with stack frame pointers.
Without stack frame pointers, builtin_return_address(1) gets garbage.
builtin_return_address(0) is the only value that is guaranteed to work
with and without stack frame pointers.
Even with frame pointers, tail recursion confuses builtin_return_address(1)
on i386.
prev parent reply other threads:[~2005-12-22 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 12:58 Valdis.Kletnieks
2005-12-18 20:41 ` Pekka Enberg
2005-12-19 10:20 ` Andrew Morton
2005-12-22 5:05 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31970.1135227942@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®