From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Kees Cook <kees@kernel.org>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>, <oleg@redhat.com>,
<tglx@linutronix.de>, <peterz@infradead.org>, <luto@kernel.org>,
<wad@chromium.org>, <rostedt@goodmis.org>, <arnd@arndb.de>,
<ardb@kernel.org>, <broonie@kernel.org>, <mark.rutland@arm.com>,
<rick.p.edgecombe@intel.com>, <leobras@redhat.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/3] arm64: entry: Convert to generic entry
Date: Thu, 27 Jun 2024 14:58:53 +0800 [thread overview]
Message-ID: <319b42b3-271f-2e29-0171-a6f1a8b090d9@huawei.com> (raw)
In-Reply-To: <202406261550.2AD733291D@keescook>
On 2024/6/27 6:52, Kees Cook wrote:
> On Tue, Jun 25, 2024 at 05:27:56PM +0800, Jinjie Ruan wrote:
>> Currently, x86, Riscv, Loongarch use the generic entry. Convert arm64
>> to use the generic entry infrastructure from kernel/entry/*. The generic
>> entry makes maintainers' work easier and codes more elegant, which aslo
>> removed a lot of duplicate code.
>>
>> Jinjie Ruan (3):
>> entry: Add some arch funcs to support arm64 to use generic entry
>> arm64: Prepare to switch to generic entry
>> arm64: entry: Convert to generic entry
>>
>> arch/arm64/Kconfig | 1 +
>> arch/arm64/include/asm/entry-common.h | 60 +++++
>> arch/arm64/include/asm/ptrace.h | 5 +
>> arch/arm64/include/asm/stacktrace.h | 5 +-
>> arch/arm64/include/asm/syscall.h | 6 +-
>> arch/arm64/include/asm/thread_info.h | 23 +-
>> arch/arm64/kernel/entry-common.c | 355 ++++++--------------------
>> arch/arm64/kernel/ptrace.c | 78 +++---
>> arch/arm64/kernel/signal.c | 3 +-
>> arch/arm64/kernel/syscall.c | 18 +-
>> include/linux/entry-common.h | 51 ++++
>> kernel/entry/common.c | 49 +++-
>> 12 files changed, 294 insertions(+), 360 deletions(-)
>> create mode 100644 arch/arm64/include/asm/entry-common.h
>
> This is very cool! While the arm64 maintainers need to review it, I at
> least built and ran tests using the seccomp selftests which tends to be
> pretty sensitive to corner cases around syscall exit/entry things, and
> it passed just fine.
Kees, thank you for helping to test the code.
>
> Tested-by: Kees Cook <kees@kernel.org>
>
prev parent reply other threads:[~2024-06-27 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 9:27 Jinjie Ruan
2024-06-25 9:27 ` [PATCH 1/3] entry: Add some arch funcs to support arm64 to use " Jinjie Ruan
2024-06-25 9:27 ` [PATCH 2/3] arm64: Prepare to switch to " Jinjie Ruan
2024-06-25 9:27 ` [PATCH 3/3] arm64: entry: Convert " Jinjie Ruan
2024-06-26 22:52 ` [PATCH 0/3] " Kees Cook
2024-06-27 6:58 ` Jinjie Ruan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=319b42b3-271f-2e29-0171-a6f1a8b090d9@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kees@kernel.org \
--cc=leobras@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wad@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®