mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: 于佼良 <yujiaoliang@vivo.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	opensource.kernel <opensource.kernel@vivo.com>
Subject: Re: [PATCH v1] pinctrl: nomadik: Use kmemdup_array instead of kmemdup for multiple allocation
Date: Mon, 26 Aug 2024 07:42:18 +0000	[thread overview]
Message-ID: <319dc757-2182-431a-8e60-bc37f640971a@vivo.com> (raw)
In-Reply-To: <ZsiqasBNAdVWKrjf@black.fi.intel.com>

在 2024/8/23 23:27, Andy Shevchenko 写道:
> [Some people who received this message don't often get email from andriy.shevchenko@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Wed, Aug 21, 2024 at 02:49:58PM +0800, Yu Jiaoliang wrote:
>> Let the kememdup_array() take care about multiplication and possible
> kmemdup_array()
>
>> overflows.
> ...
>
>> +     dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs),
>> +                                 GFP_KERNEL);
> I would even make this a single line.
>
> ...
>
>> +     dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs),
>> +                                 GFP_KERNEL);
>
> Ditto.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Hi Andy,

I have reformatted the code and submitted patch v2. Thank you.

Best Regards,

Yu


      reply	other threads:[~2024-08-26  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21  6:49 Yu Jiaoliang
2024-08-23 15:27 ` Andy Shevchenko
2024-08-26  7:42   ` 于佼良 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=319dc757-2182-431a-8e60-bc37f640971a@vivo.com \
    --to=yujiaoliang@vivo.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opensource.kernel@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®