From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC89C63797 for ; Wed, 1 Feb 2023 23:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231705AbjBAXTQ (ORCPT ); Wed, 1 Feb 2023 18:19:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjBAXTN (ORCPT ); Wed, 1 Feb 2023 18:19:13 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 303C35264; Wed, 1 Feb 2023 15:19:13 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id z1so10721008pfg.12; Wed, 01 Feb 2023 15:19:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZCpAfT76lyu9WSQ8sHNsBdoZYA3P4hVoZekbvfvR1LI=; b=DKHC7S+NYDvR4NW+8PEjb/MU79hC8oKcJFX6OpxY7ehBmP2ocp7y+KJg7cqy0SHCZv omO9170g0ssDa4dEFGw1TN2wgFzAbkyhFtiqFSIpIE5ixMKn79/wN9ptKO2su2NwXmvC P/bT5nT6WZNvOiFUSBe+V2hkWA24bU3UoB4SqpXoggFtdWlz2q6ZsA+/vfu9DPs4wKVF na8a78DjHv9JlpoU8b2tdm1avKm9NRm7+jM8YSt/1oTMZ4W/WpIK5liGa7dMYN5vdkoA R5b8WQFNNkd40WVX2IchxWbP59iflE9VcoOM4dL1E+y37eF12tjyS7B7PZE1rxVmMcYB ymvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZCpAfT76lyu9WSQ8sHNsBdoZYA3P4hVoZekbvfvR1LI=; b=wIoU4jESJPlWJGv2T/dQdw8AcMy6KmLWZ3cX7tAtjz7r5np+pTnUeUQXgdXaMd8/mq cAB6RTr+RsetQiXm8BVE7KStnLddievraIChn6HuNecA8gzAqxIMzpJzbNhJul1O9jGc 812bh4s6WUnZuONxcT+k6yruCboKkfuZVG+vMj9gWsnKcI8lOgJmtXw60UZYHYpy0U8W AEWn77AWc/xMc6b2aulWTJPUe6iFAnZm9jdGkCJQ+yxCB5QsrNmyl7j+hpix7gy9I81N gAPXEqRb92mc+DEqmXsH38bnoylAieChzGAS7nBk3serjSlsWQAuey7HXYz4QnMuTXdh UDxA== X-Gm-Message-State: AO0yUKU3DwdKU+QPejThRox861YbX684TFi4fvVVsk7GJXdyMrssqJ7E Ic3M7DU23g+wn5tR4KGTII3naXRZj77++g== X-Google-Smtp-Source: AK7set/IcQBUvBSZs+t3KuIOdX+M9J7f1R/17y/44RT9X902YXrEf+YxcSqNcfX5+eeMHnFaOhVb5g== X-Received: by 2002:a05:6a00:1818:b0:58d:b8f8:5e2f with SMTP id y24-20020a056a00181800b0058db8f85e2fmr5249624pfa.10.1675293552489; Wed, 01 Feb 2023 15:19:12 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id g62-20020a625241000000b00580fb018e4bsm6336137pfb.211.2023.02.01.15.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 15:19:10 -0800 (PST) Message-ID: <319ebea0-61dc-2e08-f48b-4555b8fb894a@gmail.com> Date: Wed, 1 Feb 2023 15:19:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH stable 5.4] usb: host: xhci-plat: add wakeup entry at sysfs Content-Language: en-US To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Matthias Kaehlcke , Mathias Nyman , Mathias Nyman , "open list:USB XHCI DRIVER" References: <20230201174404.32777-1-f.fainelli@gmail.com> <20230201174404.32777-3-f.fainelli@gmail.com> From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/1/23 10:16, Greg Kroah-Hartman wrote: > On Wed, Feb 01, 2023 at 09:44:04AM -0800, Florian Fainelli wrote: >> From: Peter Chen >> >> commit 4bb4fc0dbfa23acab9b762949b91ffd52106fe4b upstream >> >> With this change, there will be a wakeup entry at /sys/../power/wakeup, >> and the user could use this entry to choose whether enable xhci wakeup >> features (wake up system from suspend) or not. >> >> Tested-by: Matthias Kaehlcke >> Reviewed-by: Matthias Kaehlcke >> Signed-off-by: Peter Chen >> Signed-off-by: Mathias Nyman >> Link: https://lore.kernel.org/r/20200918131752.16488-6-mathias.nyman@linux.intel.com >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Florian Fainelli >> --- >> drivers/usb/host/xhci-plat.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Why is this new feature needed on these older kernels? What does it fix > that is broken? It fixes the inability to make the XHCI controller a wake-up device since there is no /sys/*/*xhci/power/wakeup sysfs entry to manipulate unless this patch is applied. > > And why not just use a newer kernel release if you want to use this > feature? Because I maintain multiple version streams so I have always have a way to compare an older with a newer kernel and ensure they all behave properly. This should have been flagged with a Fixes: tag IMHO in the first place. -- Florian