From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CD482749D6; Fri, 6 Feb 2026 21:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770413457; cv=pass; b=ACrR8l+iaQm87JjGkY62fBygwC5I3N/z3XVXsZjXfGSESxSs2Bh1Hix31JcpvJbDChQhkoNV88GqXBmxd8wC/tc2snHNEUo2JyL2JAbvVvn/wi+2T8AegMIo7MavJMsSePD0GuJOjX12PD4uQBu/bgX0iQSXkIS5TsZnLWKlsgE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770413457; c=relaxed/simple; bh=dHk/uf5/R0o1Pb5W9VHPvuhr+RUwzmWTYbA59LNhJ9M=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=lE1YLQtZGZ2jupd2Gq+wXEVjSdjXDEQ2meZojRABoozVqgnGV0vieeafQqvSda2TGh8RGd+vWFAtQBOgnF3tBSg68CwVk8r3GmbeJsljRo/gB9b1JF1Jnyh30LWod95CEjRkPuIrM+NI8bGqgZgwRRp0kUyqfT8hrB3tDndyPD4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=PgOuGqgD; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="PgOuGqgD" ARC-Seal: i=1; a=rsa-sha256; t=1770413432; cv=none; d=zohomail.com; s=zohoarc; b=TkGT/rcpJE5Vm/RPC/OLo0/DqSafIQP4dRJ9DS5V9ztK6Ke3kRltQ9h4WbEj57/jfaJLtvCMwnIh6yWLQnTLqDq48jerNv6XpjWF8X5j97XVpzK18xlVRoDnSTTu4fuy2JeuB3KoZ9Jr22UoO/dl//sTGhvEt0MSiVFamYw0wkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770413432; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=dHk/uf5/R0o1Pb5W9VHPvuhr+RUwzmWTYbA59LNhJ9M=; b=L6YzZ4DJDJPYpSP3wIFwYXu65xdUaNah/57hxFQLAxsKteOXGvzUi2ZgeyUSNPkqsRX5PCNEeD0pA1KNmjXk/uIjTznAWfAcsE6x4AC4GK7YyMpd37JDrNLheEQ9Kb5ODTN63I2H+AkFaDlr/VMeIiBVHKX+ERmLTM+fLtJjDA8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1770413432; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=dHk/uf5/R0o1Pb5W9VHPvuhr+RUwzmWTYbA59LNhJ9M=; b=PgOuGqgDm2r+bre0v+IcQ1LH7g7YFthyDqz3hqjJrYgXp9ck0UIVNlgNR+4ogr8B zu3HbqxQq8nl4tD3M6w2uHxQnQ/DbcuSufmz8XsD8pxovUabdXl98yfhOsYX48rwuYk LwfLOpDCV3saDkZIIa+RtC+Uut/J+35pmJ8yGMJg= Received: by mx.zohomail.com with SMTPS id 1770413430954879.3535008602513; Fri, 6 Feb 2026 13:30:30 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH -next v7 1/2] rust: clist: Add support to interface with C linked lists From: Daniel Almeida In-Reply-To: Date: Fri, 6 Feb 2026 18:30:07 -0300 Cc: Gary Guo , Joel Fernandes , linux-kernel@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alex Deucher , =?utf-8?Q?Christian_K=C3=B6nig?= , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Huang Rui , Matthew Auld , Matthew Brost , Lucas De Marchi , =?utf-8?Q?Thomas_Hellstr=C3=B6m?= , Helge Deller , Alice Ryhl , Miguel Ojeda , Alex Gaynor , Boqun Feng , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , John Hubbard , Alistair Popple , Timur Tabi , Edwin Peer , Alexandre Courbot , Andrea Righi , Andy Ritger , Zhi Wang , Balbir Singh , Philipp Stanner , Elle Rhumsaa , joel@joelfernandes.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-fbdev@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <31AAAF36-093A-46CF-AEEA-709CB1DE1E81@collabora.com> References: <20260206004110.1914814-1-joelagnelf@nvidia.com> <20260206004110.1914814-2-joelagnelf@nvidia.com> <77ac3274-a962-469d-a2f6-6ccc0670988a@nvidia.com> To: Danilo Krummrich X-Mailer: Apple Mail (2.3826.700.81) X-ZohoMailClient: External > On 6 Feb 2026, at 14:27, Danilo Krummrich wrote: >=20 > On Fri Feb 6, 2026 at 6:20 PM CET, Gary Guo wrote: >> I asked for this to be changed to `pub(crate)` because I think this = isn't >> something that should be used by drivers. >>=20 >> As you said, tt might be tricky to enforce that with new build system = when >> subsystems are inside different crates. But until then I think it's = better to >> limit visibility. >=20 > It should *usually* not be used by drivers, but there are exceptions. = For > instance, it is perfectly valid to be used by Rust drivers that = interact with C > drivers. I agree with what Danilo said here. I don=E2=80=99t see a reason to forbid drivers from using this. If the = reason is the unsafe bits, then isn=E2=80=99t it the same pattern used by = impl_has_work!() anyways? i.e.: a macro that implements an unsafe trait so long as the = driver gives it the right Work field. Seems equivalent in spirit to the = clist_create macro introduced by this patch. =E2=80=94 Daniel