From: Daniel Almeida <dwlsalmeida@gmail.com>
To: Jeongjun Park <aha310510@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+1d9c0edea5907af239e0@syzkaller.appspotmail.com
Subject: Re: [PATCH] media: vidtv: fix to initialize local pointers upon transfer of memory ownership
Date: Fri, 22 Aug 2025 12:35:18 -0300 [thread overview]
Message-ID: <31DCB1A0-22E8-4CBB-99B3-9392EB10CE13@gmail.com> (raw)
In-Reply-To: <CAO9qdTH=7qdR2KGQiAeKu11g8T9pPjYN0zjarLGGW_EPQ_nZ3w@mail.gmail.com>
[…]
>>> --
>>
>> The patch itself is ok, thanks a lot, however:
>>
>>> media: vidtv: fix to initialize local pointers upon transfer of memory ownership
>>
>> Can you please use imperative voice here? i.e.:
>>
>> "media: vidtv: initialize local pointers upon transfer of memory ownership”
>
> If I do that, the patch subject will change. Should I just change the
> subject and send it to you, or should I also send it with the v2 tag
> included?
Just change the subject and send it to the list with the v2 tag.
Also, I just realize that you should rewrite this further: “Set local
pointers to NULL upon transfer of memory ownership” or something around
these lines.
— Daniel
>
>>
>> — Daniel
>
> Regards,
> Jeongjun Park
prev parent reply other threads:[~2025-08-22 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 6:58 Jeongjun Park
2025-08-22 13:40 ` Daniel Almeida
2025-08-22 15:19 ` Jeongjun Park
2025-08-22 15:35 ` Daniel Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31DCB1A0-22E8-4CBB-99B3-9392EB10CE13@gmail.com \
--to=dwlsalmeida@gmail.com \
--cc=aha310510@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=syzbot+1d9c0edea5907af239e0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®