From: Florian Fainelli <f.fainelli@gmail.com>
To: matthias.bgg@kernel.org, mpm@selenic.com,
herbert@gondor.apana.org.au, rjui@broadcom.com,
sbranden@broadcom.com
Cc: linux-kernel@vger.kernel.org, Julia.Lawall@inria.fr,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-crypto@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.
Date: Fri, 18 Dec 2020 09:34:11 -0800 [thread overview]
Message-ID: <31aac1e5-e0de-c4e3-ebf1-13d682472083@gmail.com> (raw)
In-Reply-To: <20201218105708.28480-1-matthias.bgg@kernel.org>
On 12/18/20 2:57 AM, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> When trying to disable the block we bitwise or the control
> register with value zero. This is confusing as using bitwise or with
> value zero doesn't have any effect at all. Drop this as we already set
> the enable bit to zero by appling inverted RNG_RBGEN_MASK.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-12-18 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 10:57 matthias.bgg
2020-12-18 10:57 ` [PATCH v2 2/2] hwrng: iproc-rng200: Move enable/disable in separate function matthias.bgg
2020-12-18 17:32 ` Scott Branden
2021-01-02 22:08 ` Herbert Xu
2020-12-18 17:30 ` [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block Scott Branden
2020-12-18 17:34 ` Florian Fainelli [this message]
2021-01-02 22:08 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31aac1e5-e0de-c4e3-ebf1-13d682472083@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mpm@selenic.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®