From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
kernel@collabora.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: Allow setting readable driver names through kconfig
Date: Mon, 29 Jul 2024 17:21:12 -0400 [thread overview]
Message-ID: <31abcafc-67fc-4932-abf6-5ba64f09ba5d@notapiano> (raw)
In-Reply-To: <0b5f6fe0-fdb7-42d3-9c91-85a28b50526a@notapiano>
On Wed, Jun 26, 2024 at 08:44:14AM -0400, Nícolas F. R. A. Prado wrote:
> On Wed, Jun 26, 2024 at 09:49:55AM +0200, AngeloGioacchino Del Regno wrote:
> > Il 25/06/24 22:23, Nícolas F. R. A. Prado ha scritto:
> > > Commit c8d18e440225 ("ASoC: core: clarify the driver name
> > > initialization") introduced an error message when driver names are
> > > automatically generated and result in truncated names.
> > >
> > > For example, this error message is printed on mt8195-cherry-tomato-rev2:
> > >
> > > mt8195_mt6359 mt8195-sound: ASoC: driver name too long 'sof-mt8195_r1019_5682' -> 'sof-mt8195_r101'
> > >
> > > Since that truncated driver name is already used by userspace (eg UCM),
> > > it can't be unconditionally updated.
> > >
> > > As suggested by Jaroslav, update the driver name but hide it behind a
> > > kernel config option, which Linux distributions can enable once the
> > > corresponding support in userspace audio configuration software lands.
> > > This ensures that audio doesn't regress, while still allowing the error
> > > to be fixed.
> >
> > I can propose the following plan of action for such a rename:
> > 1. Temporarily have both UCMs
> > 2. Wait until distros update their packages
>
> It's not possible to monitor the package version for every single distro, so I
> guess you mean tracking only the big distros and hoping that no small distro
> still uses the old version.
>
> Also, is UCM the only userspace tool that might use this name? There might be
> others too that we would need to care about.
>
> > 3. Change the name in kernel without extra config options
> > 4. Remove the now deprecated UCMs
> >
> > ...that's requiring a bit of time, yes, but I think this is the best way to
> > ensure that no breakage happens in the meantime for any users.
>
> My worry is that we don't know how long it would take, if a small distro decides
> to keep using the old version. But even in the best case it might take years for
> the old version to be phased out, I'm not sure I'll be around for that, so maybe
> we'll just keep using the old name forever.
>
> The nice thing about the config is that distros and users can opt-in immediately
> to get rid of the error. For example KernelCI, which is monitoring such errors,
> can enable this config to fix this error right now.
Anyone has any thoughts on this?
Thanks,
Nícolas
prev parent reply other threads:[~2024-07-29 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 20:23 Nícolas F. R. A. Prado
2024-06-26 7:49 ` AngeloGioacchino Del Regno
2024-06-26 12:44 ` Nícolas F. R. A. Prado
2024-07-29 21:21 ` Nícolas F. R. A. Prado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31abcafc-67fc-4932-abf6-5ba64f09ba5d@notapiano \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®