From: Edward Cree <ecree.xilinx@gmail.com>
To: Yury Vostrikov <mon@unformed.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Martin Habets <habetsm.xilinx@gmail.com>
Subject: Re: [PATCH] net: sfc: Fix kernel panic introduced by commit 044588b96372 ("sfc: define inner/outer csum offload TXQ types")
Date: Wed, 21 Apr 2021 11:57:36 +0100 [thread overview]
Message-ID: <31ac7255-1c45-bb90-316d-751cb3186946@gmail.com> (raw)
In-Reply-To: <20210420194203.24759-1-mon@unformed.ru>
On 20/04/2021 20:42, Yury Vostrikov wrote:
> efx_get_tx_queue(efx, qid / EFX_MAX_TXQ_PER_CHANNEL,
> qid % EFX_MAX_TXQ_PER_CHANNEL);
>
> This uses qid / EFX_MAX_TXQ_PER_CHANNEL as index inside
> efx_nic->channels[] and qid % EFX_MAX_TXQ_PER_CHANNEL as index inside
> channel->tx_queue_be_type[].
>
> Indexing into bitset mapping with modulo operation seems to oversight
> from the previous refactoring.
This should be fixed by 5b1faa92289b ("sfc: farch: fix TX queue lookup
in TX flush done handling") and 83b09a180741 ("sfc: farch: fix TX queue
lookup in TX event handling"), which were applied to 'net' this morning.
Do you see any call sites that I've missed and that remain broken?
(The one in ef100_ev_tx() is technically incorrect, but qlabel is always
0 there so it shouldn't matter.)
-ed
prev parent reply other threads:[~2021-04-21 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 19:42 Yury Vostrikov
2021-04-21 10:57 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ac7255-1c45-bb90-316d-751cb3186946@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=habetsm.xilinx@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mon@unformed.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®