From: Bastien Curutchet <bastien.curutchet@bootlin.com>
To: Simon Horman <horms@kernel.org>
Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
richardcochran@gmail.com, linux@armlinux.org.uk,
maxime.chevallier@bootlin.com, pascal.eberhard@se.com,
miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 08/10] net: dsa: microchip: add KSZ8463 tail tag handling
Date: Mon, 27 Jul 2026 08:59:51 +0200 [thread overview]
Message-ID: <31ae45cc-9163-4117-a0ea-f57620f4c88e@bootlin.com> (raw)
In-Reply-To: <a04f0a2f-40b0-4391-a912-1205b83ee1e5@bootlin.com>
Hi Simon,
On 7/23/26 12:12 PM, Bastien Curutchet wrote:
> Hi Simon,
>
> On 7/20/26 4:07 PM, Simon Horman wrote:
>> This is an AI-generated review of your patch. The human sending this
>> email has considered the AI review valid, or at least plausible.
>> https://sashiko.dev/#/patchset/20260713-ksz-new-ptp-
>> v2-1-7209c05058ef@bootlin.com?part=8
>> ---
>> --- Patch [8]: [PATCH net-next v2 08/10] net: dsa: microchip: add
>> KSZ8463 tail tag handling ---
>> commit bc95662a9488a7827d30f83890008a818f0a5228
>> Author: Bastien Curutchet (Schneider Electric)
>> <bastien.curutchet@bootlin.com>
>>
>> net: dsa: microchip: add KSZ8463 tail tag handling
>>
>> KSZ8463 uses the KSZ9893 DSA TAG driver, but uses reserved fields in
>> the PTP
>> header for timestamps instead of the tail tag. This commit adds a
>> KSZ8463-specific DSA_TAG driver to handle KSZ8463 timestamps.
>>
>>> diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c
>>> index f8b40437c5fa4..477f2997c1a34 100644
>>> --- a/net/dsa/tag_ksz.c
>>> +++ b/net/dsa/tag_ksz.c
>>
>> [ ... ]
>>
>>> +static struct sk_buff *ksz8463_rcv(struct sk_buff *skb, struct
>>> net_device *dev)
>>> +{
>>> + unsigned int len = KSZ_EGRESS_TAG_LEN;
>>> + struct ptp_header *ptp_hdr;
>>> + unsigned int ptp_class;
>>> + unsigned int port;
>>> + ktime_t ts;
>>> + u8 *tag;
>>> +
>>> + if (skb_linearize(skb)) {
>>> + kfree_skb(skb);
>>> + return NULL;
>>> + }
>>> +
>>> + /* Tag decoding */
>>> + tag = skb_tail_pointer(skb) - KSZ_EGRESS_TAG_LEN;
>>> + port = tag[0] & KSZ8463_TAIL_TAG_EG_PORT_M;
>>> +
>>> + __skb_push(skb, ETH_HLEN);
>>> + ptp_class = ptp_classify_raw(skb);
>>> + __skb_pull(skb, ETH_HLEN);
>>> + if (ptp_class == PTP_CLASS_NONE)
>>> + goto common_rcv;
>>> +
>>> + ptp_hdr = ptp_parse_header(skb, ptp_class);
>>> + if (ptp_hdr) {
>>> + ts = ksz_decode_tstamp(get_unaligned_be32(&ptp_hdr-
>>> >reserved2));
>>> + KSZ_SKB_CB(skb)->tstamp = ts;
>>> + ptp_hdr->reserved2 = 0;
>>> + skb->ip_summed = CHECKSUM_NONE;
>>
>> [Severity: High]
>> Does this unconditionally modify the payload of all PTP packets?
>>
>> If a PTPv1 packet is received, ptp_classify_raw() identifies it as
>> PTP, but
>> the PTPv1 header structure is different. Blindly casting and zeroing
>> ptp_hdr->reserved2 aliases bytes 16-19, which corrupts the subdomain
>> string.
>> Should this check that ptp_class includes PTP_CLASS_V2?
>>
>
> I don't find in the code a different PTP header for the PTP_CLASS_V1. So
> my guess is that the reserved2 field is also reserved for V1, so setting
> it to zero shouldn't matter IMO.
>
>> Additionally, altering the UDP payload without updating the UDP
>> checksum and
>> setting skb->ip_summed = CHECKSUM_NONE forces the network stack to
>> verify the
>> now-invalid checksum, which causes the packet to be dropped.
>>
>
> I think I misunderstood Sashiko comment on the previous series and
> shouldn't have added the skb->ip_summed = CHECKSUM_NONE line in this one.
>
> The switch uses the reserved2 field to convey the frame timestamp.
> Datasheet doesn't say whether or not it updates the UDP checksum when
> doing so. What I'm sure of is that packets aren't dropped as the PTP
> synchronization is successful, so I think the UDP checksum isn't touched
> by the switch.
> I'm not sure to understand how the skb->ip_summed field is supposed to
> be used so any guideline here would be welcome.
>
I took another look at it. skb->ip_summed is only used by the IP layer,
this series only add support for the L2 layer so I'll simply remove this
'skb->ip_summed = CHECKSUM_NONE' in the next iteration.
Best regards,
Bastien
next prev parent reply other threads:[~2026-07-27 6:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 7:11 [PATCH net-next v2 00/10] net: dsa: microchip: add PTP support for KSZ8463 Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 01/10] net: dsa: microchip: implement ksz8463_setup() Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 02/10] net: dsa: microchip: split ksz8_config_cpu_port() Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 03/10] net: dsa: microchip: allow the use of other IRQ operations Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 04/10] net: dsa: microchip: add PTP interrupt handling for KSZ8463 Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 05/10] net: dsa: microchip: adapt port offset for KSZ8463's PTP register Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 06/10] net: dsa: tag_ksz: move the KSZ8795 tag handling below ksz_xmit_timestamp() Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 07/10] net: dsa: tag_ksz: share code for KSZ8795 and KSZ9893 xmit operations Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 08/10] net: dsa: microchip: add KSZ8463 tail tag handling Bastien Curutchet (Schneider Electric)
2026-07-20 14:07 ` Simon Horman
2026-07-23 10:12 ` Bastien Curutchet
2026-07-27 6:59 ` Bastien Curutchet [this message]
2026-07-13 7:11 ` [PATCH net-next v2 09/10] net: dsa: microchip: explicitly enable detection of L2 PTP frames Bastien Curutchet (Schneider Electric)
2026-07-13 7:11 ` [PATCH net-next v2 10/10] net: dsa: microchip: add two-steps PTP support for KSZ8463 Bastien Curutchet (Schneider Electric)
2026-07-20 14:07 ` Simon Horman
2026-07-23 13:13 ` Bastien Curutchet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ae45cc-9163-4117-a0ea-f57620f4c88e@bootlin.com \
--to=bastien.curutchet@bootlin.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®