From: Mimi Zohar <zohar@linux.ibm.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
Eric Biggers <ebiggers@kernel.org>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Dmitry Kasatkin <dmitry.kasatkin@nokia.com>,
James Morris <jmorris@namei.org>, Kangjie Lu <kjlu@umn.edu>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH v2] evm: Fix memory leak in init_desc
Date: Mon, 11 Jan 2021 08:46:40 -0500 [thread overview]
Message-ID: <31aed9f12482d1156c224c2cc5ac8afd81e8cb14.camel@linux.ibm.com> (raw)
In-Reply-To: <7288d0ce-e900-d942-fb6b-eabb63649591@web.de>
Hi Dinghao,
On Sun, 2021-01-10 at 11:50 +0100, Markus Elfring wrote:
> > When kmalloc() fails, tmp_tfm allocated by
> > crypto_alloc_shash() has not been freed, which
> > leads to memleak.
In the future, please conform to Documentation/process/submitting-
patches.rst:
- The body of the explanation, line wrapped at 75 columns, which will
be copied to the permanent changelog to describe this patch.
>
> Do any Linux developers care for the following aspects?
>
> * Imperative wordings for change descriptions
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=2ff90100ace886895e4fbb2850b8d5e49d931ed6#n89
>
> * Usage of the term “memory leak” (instead of an abbreviation)
In general I agree, but this is a really small, obvious bug fix.
Assuming Dinghao is fine with my updating the patch description, I'll
fix it.
Mimi
next prev parent reply other threads:[~2021-01-11 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 8:02 [PATCH] [v2] evm: Fix memleak " Dinghao Liu
[not found] ` <7288d0ce-e900-d942-fb6b-eabb63649591@web.de>
2021-01-11 13:46 ` Mimi Zohar [this message]
2021-01-13 15:16 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31aed9f12482d1156c224c2cc5ac8afd81e8cb14.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=Markus.Elfring@web.de \
--cc=dinghao.liu@zju.edu.cn \
--cc=dmitry.kasatkin@nokia.com \
--cc=ebiggers@kernel.org \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®