From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E8FC7EE23 for ; Wed, 10 May 2023 15:56:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237533AbjEJP4W (ORCPT ); Wed, 10 May 2023 11:56:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237192AbjEJP4T (ORCPT ); Wed, 10 May 2023 11:56:19 -0400 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6FF36EA1; Wed, 10 May 2023 08:56:18 -0700 (PDT) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-643a1656b79so5010738b3a.3; Wed, 10 May 2023 08:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683734178; x=1686326178; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XXBPb0T0axiCTL0oMtUP2eFXZZ+7E7iyDGsMoIo5xLg=; b=Z1KMFY+Uy2ParN7MmgohHDniiIX7Z7SrJ0E9sldzA+kDt34hT1GgwTqn5nplQTppO5 hyuOgEuWaecDCWoz/C44IShtSIkAii/b1A7yH+oKg9rF3h4p2eUT94ntZH2aq2Zpwzaz C1fcPQ+W3+OvwhdDL2uTltSJ1JQpWgbykfZjgZsQmxbp1kkEeny7aoIMpBf+JHb5lGBt NXigEirO0x/89y8pxGB1h9vT9H1DFX7ArBJujBe+NDzEzt8p4givboeEJM5RwfW7Cv9u v6RdPLMCAOFJx2cdTBqyMdFI4mOchBrAYGqKuwH8WXAR/CGZHu59nGnOmF/Qcd7xLs6G mYeQ== X-Gm-Message-State: AC+VfDwi1EDFZvWfUiirz4Ssxyrr4r81uZMnhZQ95jjiC9zZxECsqXvw KP9XpQiVPhTcGMvhgmyU0Fs= X-Google-Smtp-Source: ACHHUZ4jAmb3ZAKDgW/JSwT3hbLErDK8VFH/SqJrjFHj7Uk+rZBbni5StqhaUujw2nmb2aTyt4kfDA== X-Received: by 2002:a05:6a20:432a:b0:100:5a09:4524 with SMTP id h42-20020a056a20432a00b001005a094524mr13881691pzk.31.1683734177883; Wed, 10 May 2023 08:56:17 -0700 (PDT) Received: from ?IPV6:2001:4958:15a0:30:5242:f5e6:864f:4fb2? ([2001:4958:15a0:30:5242:f5e6:864f:4fb2]) by smtp.gmail.com with ESMTPSA id n1-20020aa78a41000000b0064550f76efesm3741316pfa.29.2023.05.10.08.56.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 08:56:17 -0700 (PDT) Message-ID: <31af3339-d90e-f0bd-4c9e-0da9f8728ce4@acm.org> Date: Wed, 10 May 2023 08:56:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/2] ufs: don't use the fair tag sharings Content-Language: en-US To: Avri Altman , Ed Tsai , "axboe@kernel.dk" Cc: "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "martin.petersen@oracle.com" , "stanley.chu@mediatek.com" , "peter.wang@mediatek.com" , "chun-hung.wu@mediatek.com" , "alice.chao@mediatek.com" , "powen.kao@mediatek.com" , "naomi.chu@mediatek.com" , "wsd_upstream@mediatek.com" References: <20230509065230.32552-1-ed.tsai@mediatek.com> <20230509065230.32552-3-ed.tsai@mediatek.com> <6192fa07-ec6f-0464-deb6-c3e9f69f6ebf@acm.org> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/9/23 22:21, Avri Altman wrote: > Why it was needed to invent a new flag instead of just clear > BLK_MQ_F_TAG_QUEUE_SHARED? Hi Avri, The meaning of BLK_MQ_F_TAG_QUEUE_SHARED is "the tag set is shared across multiple request queues". Clearing BLK_MQ_F_TAG_QUEUE_SHARED if the tag set is shared would be wrong: it would break all the code outside the tag allocation code that tests this flag. Thanks, Bart.