From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B474DD3B7 for ; Thu, 15 Oct 2026 09:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792055136; cv=none; b=uEeZ4AXLeVWm1D54bGMxrz7kxebRAFjdmxZ8SfuOvka3X+R6Zc38MuEmaYNQsBXiYlf6OyvwsaW5jHMUhhOfuK/DsdVJHhOcg/53zdtpM+DDmyy40JurKzzTlKtY5r8L8/ZGmV8MfScyV0WznhbMoV5G+KUrTUhyM2Ua1/fWTdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792055136; c=relaxed/simple; bh=OUqTwbkZvyiF4PoOq5Y73xoEFUcz7p6Iok5sZvcMJi4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=axuJgWDIZLwL5thETgnvYJhGiwWfjUDbU5Dpb5/nXDSEYRXyT8k4ze+pI0TycNSyPB/ANMTiSVg8+5UpRoi2xVDx94C5Cz0caVmpsHJ5CfKJWV/Ns5KRdNpyNAJZP86ig6j7v4PqZLXlTgYDkrQDEDt7FbNqWjy8rjgpjsyneR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bYM7+4SU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WStVywSa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bYM7+4SU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WStVywSa" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69F893oj3468844 for ; Thu, 15 Oct 2026 09:05:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6KhkIKXiGFzfMiy8Pf33B+AzaUwHeRu9kWddJRO8RNo=; b=bYM7+4SUef/10euO qfESKJxdw4GfDaurbPkcnInLrnnyUK7BSmh98VPX1069ENitHq/kMWsCK3klIoiI 1Pgp/5/juUwpHaEE2+wzfBkinHkQrP4rEmmTztfL0WrEkuq+PEEJ33NQWytHg3tL TKu+4sfoZPvZ/ZzXxKhIXBQ0FC4sUf7CDe1ekeZMPjSlxraVuxn1aYevbVp0NubF h4rki04hVozj0bjigBOfwGX/IeFEO5dNcyVc0S0x6vMW7Bhzo9PS1JBdPPWc0hjA NKuXP3VOSqEgKLU3bFY6bPlgybiCSVQtHLn0y6p3tSknx8rwePuwFxb7UkzqWA6X 2ovesQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hadd7bdxh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Oct 2026 09:05:34 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-533758f24f4so13228681cf.1 for ; Thu, 15 Oct 2026 02:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792055133; x=1792659933; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6KhkIKXiGFzfMiy8Pf33B+AzaUwHeRu9kWddJRO8RNo=; b=WStVywSa5SCbvNtV5kmAFAdBmR40DX/ULTE5wrL6FYceMCjgWntTJ5EbSTRJfnjCwd gMmixHdsuz5rGdW3kEjuzRRciNgT6ZcbD4GCPI4xkh9klzXz7tQlvv1qIBznx519H6nv mFCoS2bg+NUo6yULDZIZrOg8AnCiTZfwmsZL75/sKtx1EtWTvzGtzM0F5mEXPYWGQZ44 NK1mrbx21et96sT2QNXPYqZ974zpFBgeJei/Sq7+zE3dE2a8qMIDZp7aZqTaF6l8LHxY lfyykYwwaZHQ7p7x1M6V+38f10FDYuWWlJyTQ6TDxLCdZmYLg/lHTlQST5t8Gz+iTt90 AL9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792055133; x=1792659933; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6KhkIKXiGFzfMiy8Pf33B+AzaUwHeRu9kWddJRO8RNo=; b=A7COwraafQ+7OJddRyk5xKhTVmYGrYaFg0OWR9vrtsuCk8NFP+ah2wRXZnh2kCHl3b TDb6LZmhfiKGI6y0muFmPC/T1G9iiE17xE1mjQmgCYtlI13wSMuok1denspEsAz9X86Y UwPeAs2ht/rvDemmuL91Ct9sziOee1keKNHvm+5dDpCzc0/uQQRiGoMItfjCmu/YS1ps /eQE3Dmu3Nnqr12gMziEFErgsGEEF4zGYIRIIE1J1v5voi8cLdNqeC47bHZ1odOyYgVf 78e8iqfI8gqzY61gwfN3S7kvZ061VxHiPzr82grQ9XjXZVmOSMiHPpZcQhTxEUKAa/m+ 8wTA== X-Forwarded-Encrypted: i=1; AKwUvBy3K/VwisZuBgIgw2wOwSuOXKZv77Dikw4AYem1dHE0Y3YqtdxGVgz0UO8N+/wOx8BFbWTEvDVPv/hTYfw=@vger.kernel.org X-Gm-Message-State: AFq9FYIc4vgvuom76x19jy+jMwn/1zVxqBXQ5f/2rNiGpngEp219aFE1 O5HW6TkoSuAhvkvpympCYros+pM0FbPpnJvth2R4iuIRydVHSB6qyNbqJD54nl465tOg5s4bq4i 7DUg9KbF/EQcNVRcea83JxEYaPIMaYYoAtx4trpzvyyM6L5rPvCJbnn/AdaTZ8N4gAjk= X-Gm-Gg: AYBFou0jchzm6UZc/f7Ker4eW7OdjW6KpDu2hcrsZp5kloLjU9cNPHQifHeBqlAHPKn NV4QiT5uiiSrvmh7sby9rOTElvfcIxXDCKJZWgylLJnofztwEu8OHl7WU5O6hD01NpslLPdEx+j obKLlIBw4xrMRiVfYC+2Qtemz+6XC0a4glbg9TLXIal3Qr3kDfpr40mH6GU7R58PFTfk/o1L/B0 pF+HxQsM7WfG/XzxrpyWQB83vdorCbzFB2N3uuSosI5fheuhbc7bYx5GAc0UG6t6mVmTuaq3Mp4 dw6kZHa3uhMvLyxtLGg/9Dia91Su6CKxwvx7vVF5TLZMN3bbLjl1OwjT1o8yharangFU0Wu6zuj GgPsI8p+I8oi4/sHCvJ5wVw== X-Received: by 2002:ac8:7f53:0:b0:533:9739:f400 with SMTP id d75a77b69052e-5359fe05967mr342348331cf.5.1792055133134; Thu, 15 Oct 2026 02:05:33 -0700 (PDT) X-Received: by 2002:ac8:7f53:0:b0:533:9739:f400 with SMTP id d75a77b69052e-5359fe05967mr342347921cf.5.1792055132437; Thu, 15 Oct 2026 02:05:32 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c3f063cec41sm83079566b.16.2026.10.15.02.05.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 02:05:30 -0700 (PDT) Message-ID: <31afc73d-590e-4b15-9e70-0f577e02f448@oss.qualcomm.com> Date: Thu, 15 Oct 2026 11:05:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/5] arm64: dts: qcom: add device tree for SDM845-HDK To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Abel Vesa , Ulf Hansson Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20261015-sdm845-hdk-v4-0-b532b9f4029c@oss.qualcomm.com> <20261015-sdm845-hdk-v4-4-b532b9f4029c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20261015-sdm845-hdk-v4-4-b532b9f4029c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BaVNQbt2 c=1 sm=1 tr=0 ts=6ad0975e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=oI7WG5CdvwguPHJV7y0A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: tIjc7IxclqoW39vdlL09wlbLlCwmCtpN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE1MDAzNiBTYWx0ZWRfXx/hAgoJxOsuY eO/kZXr7Khf9zf5NtEWJbXSPerCFTsROFsz3FHhX7HG/lqnGUcbakWzsIzBAIiVRzOWLJ2sDTJV NvxiWWVDeW1N4Ib0ZCd7HRCerspr4cvO1F94V0+yuJ/WUNo3eqImk9YhVscAgLdbIZx25BHrsPk RnG9/L6bed+EyE7bcqWFrofO5wtPAM0pParyPdYWofgQUbMZHeOSRNBUzj4gHMKFx8vq4ud4hxd 6ROx0ida6vi1ELvMvjABs/wVzcQoOiPKfx3e5yJdPv2qyytu2LGzRcQE70rr71cgfkwUVFkowZe 4pX1jr/NBzx8jLVhKaEX9IoIs/UEZPI2uVHMijCwjpR8S1YcpcZXs53ADoHEA4IM/lnrngiSRAH vBpZ30t5hmywoXKJHmtHG9rxKEoV385wdEUZdlgUcL2tbPOr+3WVwmz1JMKRhjNcQASjB9GbWb0 x7+MDnPDrbS7Fh77AQg== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE1MDAzNiBTYWx0ZWRfX57IkPwmNCEYe j0XH7OftnddZ+kApct+4LZGXJvdswZ/71y96/s6tTrfGIghKjJYvGSwVHz4odKtwZGY5O//PT5p wDxTa97nBJPdcQI2W2qGMJxin4PATqw= X-Proofpoint-ORIG-GUID: tIjc7IxclqoW39vdlL09wlbLlCwmCtpN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610150036 On 10/15/26 10:39 AM, Dmitry Baryshkov wrote: > Add device tree for the Qualcomm / Lantronix SDM845 HDK. It is the > development platform using the modem-less (SDA845) SoC, optional onboard > DSI panel and a rich set of connectors. [...] > + gpio-keys { > + compatible = "gpio-keys"; > + autorepeat; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&home_pin_a>, <&vol_up_pin_a>; property-n property-names please [...] > +&cluster_sleep_0 { > + /* default, 0x4100c244, kills the board */ > + arm,psci-suspend-param = <0x41008244>; > +}; Really? [...] > +&mdss_dsi0 { > + status = "okay"; status last, with a \n before it, please [...] > +&pmi8998_wled { > + status = "disabled"; > +}; Is there a problem with leaving it as-is? [...] > +&tlmm { > + gpio-reserved-ranges = <0 4>, /* SPI (eSE - embedded Secure Element) */ > + <81 4>; /* SPI (fingerprint reader) */ > + > + lt9611_irq_pin: lt9611-irq-state { > + pins = "gpio113"; > + function = "gpio"; > + bias-disable; > + }; Sort by pin #, please [...] > +&venus { > + status = "okay"; firmware-name, please otherwise generally lg Konrad