From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B85B12FB962 for ; Mon, 24 Nov 2025 11:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763984570; cv=none; b=rQPmHvjUSgeTS17ZkE66GgcvsEo99xz3H2OAxSorn9+dmjjSfxLAEgkJMnMBRbI53gH0xGwGLa1l6a7ALorTzkvBOB4MGQ9EGahklFj14jithHiL5ESWn5TW4px1FjmQMAqqyvwnY6M+I6PgXm2ROBVci3Do5DH7jvzRxqIopFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763984570; c=relaxed/simple; bh=yxW+0hq+xdWaIvmIR13/79lwfDgz94e+THqjVqoR4yE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sCTQH+qJ2uajW3qD84dQShPN8LpLdfga1AvUX2ZxNau8vqBrw9/HJfZ75Cc9mmvUAtcH14DaagiC1H13cy4veTdLzSFMt6t+uJHsGz+3EaquqsEBSnq6wxkwtcP+B31uGDdl7j4G4B9wHiAiUuTXpZiK2JaKYEI1JUn/15JINgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JoHfhOMG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PPSklVGG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JoHfhOMG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PPSklVGG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AO8Vs3H2506426 for ; Mon, 24 Nov 2025 11:42:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vOwkRleX0/HPneuTZSuUXMIp11FuA1s/fb+Wlx7sHoU=; b=JoHfhOMGcbBjfxTh 1zKiq7cLwctkkTh5yt0xnh42UCAXUBAYIS3s672hOaC/lVMw49L0to1DFFyk/Ev2 QgyAPF2a9GgO1eVnK9m0J19R043YvPIMJazfBWyHZMEQLWhQg/YClwTieevfTCfS yxy5hT49LCuUgXLTTDxcYiqYAA6svRFz6OWLc5y2HhKmlNh2NfUiEeKHo285EPas dwmyRDL1nwjIKHDAt2zbaNUJ0X0PbW1067CbS8SUPlYGJAH0qxqe0MRwnsO1Y6sm vyCaB2+iMIc/ArfYvp408fiIoe7FXTj9Q8zNrDhjrTLUobxBnysWswD16vWWCOY5 gojg9Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak685vx2d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Nov 2025 11:42:46 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4edace8bc76so12937031cf.3 for ; Mon, 24 Nov 2025 03:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763984566; x=1764589366; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vOwkRleX0/HPneuTZSuUXMIp11FuA1s/fb+Wlx7sHoU=; b=PPSklVGGV3lSRqKmLjWrEfOonggJHoBi+xEKENFOiQNKpAOJJIqXin8ip18z2Vfuvs rVbFzJ5HwvjjUlFpbiktTpTppoTZZtQZkUNZQqCLBusWgi0qA03MmI8hrL9ZMCoseIpB eKFPPcO0zC438vM1kJH1eoTwFZq+xM26sZfvk9Bp1/AjCEp4hpj2zgzIn2Icr0RVQTRM 4eVm4Swqobr4v8XbBL7/LQeeAMctmyTrL03uu4k0Er16xY2z5/DMGh6fWMhzJbwlHdmZ 2bC4RzW9qc0LM97+jROObae7mIE6HabwSQru8WBBcsmZdJKgR748TyPKz2je4xvzpuIz R9oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763984566; x=1764589366; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vOwkRleX0/HPneuTZSuUXMIp11FuA1s/fb+Wlx7sHoU=; b=pDUZQq6UtxvdbISfgyXtr/AXovDfrwJSave7+2EZfjnsr723oWj4TPukorx6gQka0T WzXS7f8NUTvDej6NGMJZocsddEcbFWc/EoyFs7MbKTa2pbjyMlGzmplQkT23uWIOByca KDSxNNG3nEB0vaC6qkjYqmfPcVD/xydmvoCQjlR1qLyXOrq/FAtseiHXj7dwN1TKntVc wO9ibC+aZH5upOQOCETDxeDF/LLpeWZboFeLTjCmsMqnYJ+gDQmbTyGBySHue5rJ74LZ Mju7v64ntRjBYRtDeXxaRcNrmsA1FwXM/HcnYroKdgcWI3i2NF+/V/KAs1Ty7fw/DsfP KhAQ== X-Forwarded-Encrypted: i=1; AJvYcCULw0TrHy1UjPDOTe3ocEIZLjE+kf0NMotJV0fLA3ZSQ7FaHlyIwvHhM/ScKjeKhiEfAZ5lTytJevBT/qs=@vger.kernel.org X-Gm-Message-State: AOJu0YzaSCba5Tn7rN4ttDq+gAGAnKQRcwEKz32hWBGeQqY9w12/kUWy lX3T6br68AxJAj7+Re6A/HNbabv69gJeVQ/rNqb3I6tyYm1juTNm7WwTGtKPzHlDdTNE9xEd9Rb sIPu1DaoByeuAaiKpPo2OMt48HzKUFyVOlAMQiuO2shvIs6auI/6lKpqxbUgiEK/CkNA= X-Gm-Gg: ASbGnct+y/UiA5+5FxEiw2LkABJyvB5i/k6OkO5viQm1LlWBAhJdnTXsv56wNtEUbPt QfntLmm2rpwP842qkyAb8E9dYBsd/iLHIv+576oGtzEYdplKoCyWUSFIQfNLgmHMHW7m+OAEUnS SkEJIRYYS0DQbyLkuBX1TBmtFBiwCfhfcX6GpXeN8qdUN64hVqQ1dijxestFAQISFnMYP52z32z egagdqxZNLJ4Aceuc7WpkaC9V2WWbH4E2RLnxurhkZN7kr/pLdCqBSk2eJpPZqgabxdeFhDHwpi Lso0NNpWuCKsjQsZd4jbfeRUZuq2k+Jtfc77eVduBW2+ULd1w+/M0cb0gqjt2WnlAetothCoaiC /nrlzJ273SGcBHur43VLC0niIRnfAV0Ij3yGx5y8j6XnuhPHgVjBeaWr+OVO7u2oc/QA= X-Received: by 2002:ac8:7f47:0:b0:4ee:1367:8836 with SMTP id d75a77b69052e-4ee5b6fad57mr104481231cf.5.1763984566140; Mon, 24 Nov 2025 03:42:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOiv4g/u/e7x/GqCRfNkAnyc3/9hzMx8fvdYPjlkBHSJlkgo2NscmBHl0CkBVDbNGDKTEw6Q== X-Received: by 2002:ac8:7f47:0:b0:4ee:1367:8836 with SMTP id d75a77b69052e-4ee5b6fad57mr104481101cf.5.1763984565753; Mon, 24 Nov 2025 03:42:45 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64536443784sm11705733a12.28.2025.11.24.03.42.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 03:42:44 -0800 (PST) Message-ID: <31bbe640-b1ea-454b-9c9c-ed013022f07c@oss.qualcomm.com> Date: Mon, 24 Nov 2025 12:42:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs To: Manivannan Sadhasivam , bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam References: <20251120161253.189580-1-mani@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251120161253.189580-1-mani@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Woom8Nfv c=1 sm=1 tr=0 ts=692444b7 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=IPny-iXwT8bmEns2PIkA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: 4qnQENyFxhy-h3RWFSzWxYQqGsY0M3a2 X-Proofpoint-ORIG-GUID: 4qnQENyFxhy-h3RWFSzWxYQqGsY0M3a2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI0MDEwMyBTYWx0ZWRfX4069ful5q2g/ c1ErrgfULRZSrH+YT4WESH29rm3/PyOSDjgDRIaoDCDxRSPbKfua8PvWNgSE/qMGfrCtox+PYnT AUCc+yMAqsrL7ucd74dD0yavVp4+AMiNQx+e7Sd1bubbkKTSw9WC/LuOTT5qfzBiHohmw98P2za KpDkAzHQeSo5IVpugwBqTtZdYS11Orb0J1qwokRm5CjbMRRHvh2ok/X6rJbEu9oJzAUYyvf0EQW ULixuQQxLy7ZGZtkAUZOX4aybJSeVi6GGbhe/Ax19s4Mw01bsyirRapclP4SxqihkLcFRn7vXIy hNOHv08BI0ZNpN6vELziGWxS9ZSaR4uOnz4ZBJOY5GpGD1cbqP7omcTF63LVc7owQwn4gVSVxpp PsV631MDLKI9u7G2MXqizhVPy8BB4w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-24_04,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511240103 On 11/20/25 5:12 PM, Manivannan Sadhasivam wrote: > The Sandisk SN740 NVMe SSDs cause below AER errors on the upstream Root > Port of PCIe controller in Microsoft Surface Laptop 7, when ASPM L1 is > enabled: > > pcieport 0006:00:00.0: AER: Correctable error message received from 0006:01:00.0 > nvme 0006:01:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Receiver ID) > nvme 0006:01:00.0: device [15b7:5015] error status/mask=00000001/0000e000 > nvme 0006:01:00.0: [ 0] RxErr > > Hence, add a quirk to disable L1 by removing the ASPM_L1 CAP for this SSD. > > Reported-by: Konrad Dybcio > Signed-off-by: Manivannan Sadhasivam > --- This revision also works for me, thank you Tested-by: Konrad Dybcio # X1E80100 Romulus Konrad