From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 813EC3890EE for ; Fri, 24 Apr 2026 09:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023656; cv=none; b=hW0xV9dRznj7a5uSVWQ7XJq80yKrLryXsrl7FdpfMyq4PhXd26T8ZRbvzzY25H7Y9E5GtFrQ6vYw0q7pVb5/i7wqQN0TCp4NSTI8RLLI07NOQ74II95dKW8pPny+VB8kTybymmpN2KhGqHlJUrB1L/bv6FwU9GrfltYdFJ0mwbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023656; c=relaxed/simple; bh=Vf9H2UG05qoKr398eIXjoUC57YQbGM7DmdYxZ9Ef0Yg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u3P99CtFu38zbYdm6mqI+38lz6i+J7x+rO+sZhPcZdBr0P/SzkhUmS2l+Il0dW8fIK5LYT6u9A9qjZ2tYbg0RliIu1ll8G2VNAODQEhd0hqVEjcmAIGzPixG866IEgsmokvVYHm8B+4EZgMIALMExVLde28HDngI7MCajBbHE5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iU68V2J0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YQqcNEpR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iU68V2J0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YQqcNEpR" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63O9N9UV518493 for ; Fri, 24 Apr 2026 09:40:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TUhERKpJzC7ZYA/PnGzU9lEKyH7Mxyrhg7LHLvtN+QQ=; b=iU68V2J0hud5/fJy nuvb94oFVoUDgL7peYgVg3ExtzCV+kGhH/+iaNbTHa4CCtIV2bZxsaxaqriRbh4t PJ5BTc3jH7ybihihfQ0fAW7sjC8m94cNisCxHCTPkoQWqEGzNddAMA+3Zjg/Pp0F 1tghCwRagqdU3BCG8qxjQGxJGbzoMa+h6ZhsLCktXN5uXjj7lBUbQph0vTqHysRr 1slNLPgbnTDFYeUj6Kc4kMaItlFNy75CT+SFAYrb+negNIf5VrwJAnKxiCnGo9US 5FV+8Lm2hSwYU+KlA6ct0Ymy7MFXaYkPnbUxlE78qp/3AGE9TtWpRbzixFOOxkkQ DD36LA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dr0fnhdb2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Apr 2026 09:40:54 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8aca281aaa4so13285296d6.1 for ; Fri, 24 Apr 2026 02:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777023654; x=1777628454; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TUhERKpJzC7ZYA/PnGzU9lEKyH7Mxyrhg7LHLvtN+QQ=; b=YQqcNEpRoItbgZX95Oy4MwWuT60XpuDcklvr+9GNFbJCyP1nO36kc4XzqrTBS3tAAq TnzO3AnXo4b65Wb4gmW7vbSNDqwo9GnJy0TVSjDLvKYdqyJ63N3NuWnLRKitk3xWExgf 8R7BjWZMKITl224fh8T7AZ+158wVPrzgCrPBwjUVOxTT40eqmxzBNKZ4gy1aLW/5NXL/ NNJX0HuHzZ//G8jUCS5bJOH6yyNJuUWI1f13aeBBegEn9/B3b3STW55ZjSaaV01MQVuF oTSVw5u3k0+yeQpJQZYTA9Dfg3peEmiwUu70oO2vBCOQ+Mm970xJbf6U3DKEyOrBVu3m FStQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777023654; x=1777628454; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TUhERKpJzC7ZYA/PnGzU9lEKyH7Mxyrhg7LHLvtN+QQ=; b=Lq7DuEnUGue5yI7NHUySG1aRSOAk0d2BEOYGcMzqMitatI9oonA5dE2PnojllFzl45 xWCh92I62f9rp9H65T7nkIem5JBJQBgTymD8TALiewwg8mttm5TcRijJo/yUFbRfpq/R dKGI2kyuDXAe1+g25pNPP6YatpeBgbpd2g5b40Bap/V54s2n/0aEYXPNl8GIEOFR+dwp RzNVixjztkGTAFcd4wJeErPOgH1EKqEgWwVhUnr/LPZYyZzdUjLq/VHlnzhcCW5T6wqA NGX7A6FsKJHyXV8MF8MfRt+YIf5ZhD7ezGShyJumQeqaFMceh8WMUUv/XXXAKa0B42eu ybjA== X-Forwarded-Encrypted: i=1; AFNElJ/3awRxepmv+6Mn7OuvUkih4IHWu3uYXFFtU8CJ4VY4zOI51w/uzkf6fy/g2Eqg2lWvQ5SU5eErDqyNaJ0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz/LICkiJJKuLR8MU1gFRRhFC2lzvC5HkKY1SoJSAbLS0sA+bC /XTO3iEfwMbXSoyx1hoAtzGkCCpPsEkmRy1ZXRfCi4agt2UTsKum6zWzNh4UGpipvbxybZVqCIV ArrNyoWheIT0awDu3kR5j2pUeIx5rQP1eOaD3CpETY6PaxqSwN8XaEUIcOPTmWLU8BZ0= X-Gm-Gg: AeBDieuY/8nZUPIC4EvFU7mtchHsnYFnlcWpwSInZm7QgBfL8E4CqSZpObKgEscI9RY NyHD+zKX8C4qy6Vy4uaf/RSCFClCaOdBoqtZ5FIMGmgR+tqYfb106fSIsgXXKDB6kynQ5xet6KV lGSlkG7aIYNuC5vv/ynMfQOUO8UJQrYgi4nmH6yfO57bguy7arhZJwaMRcynGsZI8F8/CaImVqS rl1qsIn0pYDGXd+bFSjvnjTIrk/GJPjn2CXhx0SvGA+CAyt8dnm7at+PgXCqHBJ3piMUfRNfPaA WEOdp56uepR5zpWpT4W2oQbxqtMXEVv14UYqw66xah7NUMOCsPjGMiL1OtPQPApVGs4tbvr/zSl AdrrXHL16WHpjDf3iH4f/D5YlMOwrsjst/AVM+8soTmaI+6w46B1VssAhX2CehUNBdPC7DDIfUB ctRXzs5KrrJ7tNuA== X-Received: by 2002:a05:620a:4589:b0:8cd:8bfb:a4a with SMTP id af79cd13be357-8e78bee4fc9mr2868065385a.0.1777023653807; Fri, 24 Apr 2026 02:40:53 -0700 (PDT) X-Received: by 2002:a05:620a:4589:b0:8cd:8bfb:a4a with SMTP id af79cd13be357-8e78bee4fc9mr2868063185a.0.1777023653393; Fri, 24 Apr 2026 02:40:53 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c4d4561fsm5009428a12.16.2026.04.24.02.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 02:40:52 -0700 (PDT) Message-ID: <31c1a601-c249-426b-8f0e-30d729907a89@oss.qualcomm.com> Date: Fri, 24 Apr 2026 11:40:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v4 6/7] drm/msm/adreno: add Adreno 810 GPU support To: Alexander Koskovich Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Akhil P Oommen , Bjorn Andersson , Luca Weiss , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260416-adreno-810-v4-0-61676e073f8a@pm.me> <20260416-adreno-810-v4-6-61676e073f8a@pm.me> <23fbb36e-56b4-4ecf-94e9-4038c6311b31@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=LfYMLDfi c=1 sm=1 tr=0 ts=69eb3aa6 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=e5mUnYsNAAAA:8 a=EUspDBNiAAAA:8 a=aOPa8h4f5WR7Ygev7eEA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDA5MCBTYWx0ZWRfXwTmeBaH3882s uM6k/BtMrEaU1JcguiJ4vWwXbCyLta5Tame16hdqD5pFn3B+WFC/KM4g0xTRBYNQ6Gxs84b7FW9 1TB0MKkInRy9BbZDfHNonfzYAHD2WPPnwUV9Rz6PAV/2L2dhfSmgEhFBGqceM831NDSHefFLKDH 9n73Xd8u2icaRgH5dam/v/xCuTWhSghSq0mKDrmw0j4fWAQQ4fTfjXiqVfqmqrJzcgzcIxu0Nkd barOa2lOGt/xsxKeWrNiB+pHAv2Sgab7+trLxOMG/BniFmYZZ0ild/jBKaGCUBCSGWfgcBArCCt p6wY8BmJbtf2zdXj/tmLSS0la6DPV59XS9cM8vpzqPUPCS9rjfpZcq9oIjs5azXsRn7C97Sh6fM UMRiLh11SW6DdZRORATBv8IWcmzT7Zw5NBQ8Jge/1HRDSzeTDlZAMx/iCcJB1LryrY0gV0cAV7X 4rhsXjl0Flc6NNHrVZw== X-Proofpoint-ORIG-GUID: rf5ET8hwTzznnEPmNsLwKrdzm7MB_kSY X-Proofpoint-GUID: rf5ET8hwTzznnEPmNsLwKrdzm7MB_kSY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240090 On 4/23/26 10:34 PM, Alexander Koskovich wrote: > On Wednesday, April 22nd, 2026 at 9:04 AM, Konrad Dybcio wrote: > >> On 4/16/26 1:05 PM, Alexander Koskovich wrote: >>> Add catalog entry and register configuration for the Adreno 810 >>> found in Qualcomm SM7635 (Milos) based devices. >>> >>> Signed-off-by: Alexander Koskovich >>> --- [...] >>> +static const u32 a810_ifpc_reglist_regs[] = { >>> + REG_A8XX_RBBM_NC_MODE_CNTL, >>> + REG_A8XX_RBBM_PERFCTR_CNTL, >> >> This list matches the expectations, modulo this RBBM_PERFCTR_CNTL > > Note on this, added this shortly before submitting this series as requested by Akhil: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40613#note_3395308 Yes, I forgot about that bit. So it's OK. [...] >>> + .speedbins = ADRENO_SPEEDBINS( >>> + { 0, 0 }, >>> + { 242, 1 }, >>> + { 221, 2 }, >>> + ), >> >> The DTs I have all point to SMEM-based SKU checks. Did you find these >> numbers empirically? > > Yes, and I used speedbin instead as upstream doesn't support the SKU checks > downstream does. Utilizing GPU_CC_FREQ_LIMIT_VAL to serve as speedbin > on this platform. Hm, I'm not sure whether it's a stable identifier on this platform, or whether it just worked by change. Akhil? Konrad