From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
YH Huang <yh.huang@mediatek.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: mediatek: mt8173: Fix disp-pwm compatible string
Date: Thu, 9 Jan 2025 12:12:40 +0100 [thread overview]
Message-ID: <31cd9b95-21e0-44a0-9f60-cf84b2b66e6f@collabora.com> (raw)
In-Reply-To: <20250108083424.2732375-2-wenst@chromium.org>
Il 08/01/25 09:34, Chen-Yu Tsai ha scritto:
> The MT8173 disp-pwm device should have only one compatible string, based
> on the following DT validation error:
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtb: pwm@1401e000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['mediatek,mt8173-disp-pwm', 'mediatek,mt6595-disp-pwm'] is too long
> 'mediatek,mt8173-disp-pwm' is not one of ['mediatek,mt6795-disp-pwm', 'mediatek,mt8167-disp-pwm']
> 'mediatek,mt8173-disp-pwm' is not one of ['mediatek,mt8186-disp-pwm', 'mediatek,mt8188-disp-pwm', 'mediatek,mt8192-disp-pwm', 'mediatek,mt8195-disp-pwm', 'mediatek,mt8365-disp-pwm']
> 'mediatek,mt8173-disp-pwm' was expected
> 'mediatek,mt8183-disp-pwm' was expected
> from schema $id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtb: pwm@1401f000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['mediatek,mt8173-disp-pwm', 'mediatek,mt6595-disp-pwm'] is too long
> 'mediatek,mt8173-disp-pwm' is not one of ['mediatek,mt6795-disp-pwm', 'mediatek,mt8167-disp-pwm']
> 'mediatek,mt8173-disp-pwm' is not one of ['mediatek,mt8186-disp-pwm', 'mediatek,mt8188-disp-pwm', 'mediatek,mt8192-disp-pwm', 'mediatek,mt8195-disp-pwm', 'mediatek,mt8365-disp-pwm']
> 'mediatek,mt8173-disp-pwm' was expected
> 'mediatek,mt8183-disp-pwm' was expected
> from schema $id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
>
> Drop the extra "mediatek,mt6595-disp-pwm" compatible string.
>
> Fixes: 61aee9342514 ("arm64: dts: mt8173: add MT8173 display PWM driver support node")
> Cc: YH Huang <yh.huang@mediatek.com>
> Cc: <stable@vger.kernel.org> # v4.5+
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2025-01-09 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 8:34 [PATCH 1/3] arm64: dts: mediatek: mt8173-elm: Drop pmic's #address-cells and #size-cells Chen-Yu Tsai
2025-01-08 8:34 ` [PATCH 2/3] arm64: dts: mediatek: mt8173: Fix disp-pwm compatible string Chen-Yu Tsai
2025-01-09 11:12 ` AngeloGioacchino Del Regno [this message]
2025-01-08 8:34 ` [PATCH 3/3] arm64: dts: mediatek: mt8173: Fix some node names Chen-Yu Tsai
2025-01-09 11:12 ` AngeloGioacchino Del Regno
2025-01-09 11:12 ` [PATCH 1/3] arm64: dts: mediatek: mt8173-elm: Drop pmic's #address-cells and #size-cells AngeloGioacchino Del Regno
2025-02-06 11:08 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31cd9b95-21e0-44a0-9f60-cf84b2b66e6f@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=stable@vger.kernel.org \
--cc=wenst@chromium.org \
--cc=yh.huang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®