From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.152 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794779904; b=VyHNlzwXcchTG9gmIMHDF/WFS2KDslkP+tMbfuHkwTTVq3N8fnjS3uqs7xeFrIFKpCHr /OMxkTrnAsj4ls5eseD1gHqHFjW3yU17DuNbRg+FIWv601eloW/gKV3ZUL1XrBbrHKmmg anDkxke731CAyKqXMsU1/XyE1b4E0mtI3AYSq+/R2Sw43bpeXaKQnn49sFRLMmt8E72dS AKu2gCrXp3TFGrFEEeT73t8lqd/28p3u2LpKpKVIPPPQp1xnKJgU/gHZlenljT1xseacy oWKmnHZ+1jfzNyjWWcbDAFzL9c6DMZfy/rwRHDCe6jQc+Dhs5I3yBu78msu2ettSOaw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794779904; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:X-Mailer: MIME-Version:X-ThreadId:Date:From:To:Cc:Message-Id:In-Reply-To: References:Subject:Content-Type:Content-Transfer-Encoding; bh=omemX1lEWnfDDXO42qPUhNXOBFAKGZAy0xUrDaXsUY8=; b=BUYvYN2DEV91BHAe5y2BOQUmyShLsAJ49wBdWW47a4AvNZtlZJIdi1yb8hXgx5u2ovqf OJdAH2e/IUdSseKC8c5Ko9uG0jc5mUjqU4NTlsDRA7afkfUkpwglMofsBXhjSiF9xuB1q fmGPLCTRbE6+whivzdwayYZuXq/iOdeDUGm1va60MsmZFxWjEr3b7r6ojauDTlDX4wWiB 3C0ZOCNWMe9rhhY/Lz73TY6G7Bd6+dcGuVO6Aytck9peJhNv28nKqPvKjEXSILV8E6C4B OOjvMVk/6sInBGYQwpe0SCEMC2UCVCRUgQKGHO9yDAGAWqWA75E0Du+IT4p8tMsCk5w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=squebb.ca; spf=pass smtp.mailfrom=squebb.ca; dkim=pass header.d=squebb.ca header.i=@squebb.ca header.a=rsa-sha256 header.s=fm1 header.b=WEErMtaU; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=dJ4Zyajo; arc=none smtp.remote-ip=202.12.124.152 Received: from fhigh-b1-smtp.messagingengine.com (fhigh-b1-smtp.messagingengine.com [202.12.124.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14C8A606A331 for ; Sun, 15 Nov 2026 21:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 14C8A606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=squebb.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=squebb.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=squebb.ca header.i=@squebb.ca header.a=rsa-sha256 header.s=fm1 header.b=WEErMtaU; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=dJ4Zyajo Received: from stl-compute-04.internal (stl-compute-04.internal [10.204.2.64]) by mailfhigh.stl.internal (Postfix) with ESMTP id 88B5A7A011F for ; Sun, 15 Nov 2026 16:58:22 -0500 (EST) Received: from stl-imap-02 ([10.204.2.93]) by stl-compute-04.internal (MEProxy); Sun, 15 Nov 2026 16:58:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1794779902; x=1794866302; bh=omemX1lEWnfDDXO42qPUhNXOBFAKGZAy0xUrDaXsUY8=; b= WEErMtaUqeQAvKf6Yp8PWn8UBJNZVYpcGwHfOsWikMaP5mxPmPLbxxvlT8pVtLjJ nSS9OgtMvm+Y+kcvw5Wq2zmJohgnlQxtNo7f6vxY4I2k/Rym9ADVXHFHgaLn5Iwx QrTl+huJ99OCYEjKdHI8SSiwOarf1YNM2DflBDidSjQj12YYTcOTtNswbK2JIkdB 641sFkZBo3AXBTzT406auQFscTIbmE9lCMUK2GF//ZBS3zJwao5LwGtWprcdv6Zr uWhNXCIJGxAQHmIHOh672J+0yrvcUeKRW6ySYUp1LT3lksMYDFj+sWqQYXIKJEkI MZaID1IZ2Wu9YhXoOrNaSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794779902; x= 1794866302; bh=omemX1lEWnfDDXO42qPUhNXOBFAKGZAy0xUrDaXsUY8=; b=d J4ZyajogEFpilkDbhmqCgmlwrt7qKpLQQ0mxAic5emsijZZmvHQNuqoYSo+vQqts Sd8DCzKrp0XWRyk6hgsdWJRK2YBsGFUjGaTY6zQc9uQVFMxepp9OBrRdmTyIdBpQ edXg9lkKK7/IFhF8vUu1jptQ3odWFQuopkvDsFYcOTtIbWoMv2oDm+HCVov6q4gP OPs6IC1i7N3+DncuL0kQnz1FQdTLIR2HkLuQdyA2UpjaXtiraEORpnkEqBZEbAZA PVHlLoMD14ue+nlHcUBtA7/OCcfPR2BhbiUDSON6QAagA3JNhDMNcj4/zl94gOOw U4vtZkyMYl1gJo5p1RwOA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=squebb.ca a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794779902; d=squebb.ca; mf=PG1wZWFyc29uLWxlbm92b0BzcXVlYmIuY2E+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm1:rsa-sha256:HMivpwLOT6FSizZvRVfq3ZmYVFwzOHlrzZueoyBXRNGLQIO bpw6g+IyH4AqGPQGaYZFsdZQLT/mNFbSpghHYqEuNWPcilWKQEUUdCD54MuFlfN2 2/M972hMlM+iIeV5JpU9NtepNE2cOTn75Gww/vbxo58r+3ipB0+CSwL68XTnyxJZ Ee04A1rmuilL2GVf7adywpJbeJy4a213G8pDJjHacgQoezS+t+lNrNhcJNKQMO8Q OCi5a7zTOdYJMf3fQVUXZWGcjfbX5TYWzExCkTxNDfrS3IH8nCiB1UjebLt1ysLV PWoNLbxNXS7uAUSUN+fmqavXxyoOABVabu5dD9A==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:hy4kCm7rEcW1x2k8CCtDuRbOCBVxwxxXtw84rHG5ZvU=:ZfHLVqPQyUu91y0xuPm+KeHdUeMYrUpfFxJgHf2U/p4=; X-ME-Sender: X-ME-Proxy-Cause: dmFkZTGxVtkuemJOOutN4FdlbA+YFcEEVkgzLoncpn576eBZBAV7P3UgWrOD13fw7PiOqb vAU3pWCwQ7jFRa9S+u7adtz7YeoLm/4JpxLzmfhu7I5C3HxyEHigXMcn5zk4f6BWkkFzQe a6rQZCJ99zmyV/9XMOwMv0F98JrE7bTugN2+8ylTKG6aLK3Uu9+g8HynlP0heVKB6s4evh id35K8pT2Xnx6jCHIAJsBP1iBCvbO+JH9SokySQI3i34oa3laBSNsTVoZYBkEKTFcZzxqx tXK96JnUqnhQOn92TguRc0f1QAAugBQoQ78y5IVqBiVCj6KleTSDiR/FB/saMlHL75nOR8 ocYmDtlu4z3skyexI/Euj0HgbnffQnQ7OHG0hghXGnFSboj+2fOezWDL8/0ZlvSn2Aq8Cj CbfbS//ibgl7J9CBWxr2rCqonmqk/mX3q2s1YNKMyXWIKtJgaD1O+UGoQg6bPAp+6I98t2 ZnsT04/WXPGwmVbUvSEBcR06npCA3VnWS2PxiSeZYa9koFoSDvDUqN5KpRRZln1tJcpKQB p7AmJ5N3G95+gmJ5U7sBpoqCWMX5vVdyvmKxLwb9p6PQgmmLYLC/d04KZJvcwjeakOfF1w AcXMOhZ+5ioaXsuXmnucUeJlPDyG/OEQFDTRaWHPhmZlNAfdUxzKCp1c550Q X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mailuser.stl.internal (Postfix, from userid 501) id 9B0862C00085; Sun, 15 Nov 2026 16:58:21 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-ThreadId: AoH_4y8sCjjc Date: Sun, 15 Nov 2026 16:58:01 -0500 From: "Mark Pearson" To: "Rong Zhang" , "Qiling Zhu" , "Derek J . Clark" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "Henrique de Moraes Holschuh" Cc: "Andrea Rabbaglietti" , "Lee Jones" , "Pavel Machek" , "Griffin Kroah-Hartman" , "Vishnu Sankar" , "Vishnu Sankar" , "platform-driver-x86@vger.kernel.org" , ibm-acpi-devel@lists.sourceforge.net, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <31d80e19-0330-4a87-abda-1e134e4c4b63@app.fastmail.com> In-Reply-To: <64525e6fc8bd29dab836a5f6a4249523ef285012.camel@rong.moe> References: <20261102151211.40701-1-kmatzkaczor244@gmail.com> <20261114174814.62153-1-kmatzkaczor244@gmail.com> <20261114174814.62153-2-kmatzkaczor244@gmail.com> <64525e6fc8bd29dab836a5f6a4249523ef285012.camel@rong.moe> Subject: Re: [PATCH v3 1/7] platform/x86: thinkpad_acpi: Report auto keyboard backlight mode as off Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sun, Nov 15, 2026, at 2:53 AM, Rong Zhang wrote: > Hi Qiling, > > On Sun, 2026-11-15 at 01:48 +0800, Qiling Zhu wrote: >> The EC keyboard backlight level 3, which selects the auto mode, is >> passed to the LED classdev verbatim by kbdlight_sysfs_get(). The LED >> then reports a brightness of 3 with max_brightness 2, both through the >> brightness sysfs attribute and through brightness_hw_changed >> notifications. >> >> This is not only cosmetic: UPower 1.91.x treats the out-of-range value as >> invalid and stops watching brightness_hw_changed altogether, so the desktop >> stops following the Fn+Space hotkey once auto mode has been entered. >> >> The auto mode is not a brightness level. Map it to 0, the value it is >> reported as most of the time anyway, in line with what ideapad-laptop >> already does for its auto mode. >> >> Fixes: bb28f3d51ff5 ("thinkpad_acpi: Add support for keyboard backlight") >> Reported-by: Andrea Rabbaglietti >> Closes: https://lore.kernel.org/r/CAENjc+w0Rqy=kDSew7XtNJCSvyPiXPJ5faWdmCr5RGYFhpunCA@mail.gmail.com >> Cc: stable@vger.kernel.org >> Signed-off-by: Qiling Zhu > > Reviewed-by: Rong Zhang > > Thanks, > Rong > >> --- >> drivers/platform/x86/lenovo/thinkpad_acpi.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c >> index 4f81855ad..2c3f8cf32 100644 >> --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c >> +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c >> @@ -5102,6 +5102,9 @@ static struct ibm_struct video_driver_data = { >> * Keyboard backlight subdriver >> */ >> >> +/* EC level that selects the auto mode for the keyboard backlight */ >> +#define TPACPI_KBD_LIGHT_AUTO_LEVEL 3 >> + >> static enum led_brightness kbdlight_brightness; >> static DEFINE_MUTEX(kbdlight_mutex); >> >> @@ -5191,7 +5194,8 @@ static enum led_brightness kbdlight_sysfs_get(struct led_classdev *led_cdev) >> int level; >> >> level = kbdlight_get_level(); >> - if (level < 0) >> + /* Auto mode is not a brightness level; report it as off. */ >> + if (level < 0 || level == TPACPI_KBD_LIGHT_AUTO_LEVEL) >> return 0; >> >> return level; Looks good to me Reviewed-by: Mark Pearson Mark