From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FA32F549F for ; Tue, 4 Aug 2026 05:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785822502; cv=none; b=PRfJ6wpWrgbQdxwEZVMrpUTaYd5nHaWsKRYBfLoLJp+EvjcGV4mQ7iY2we9Ho7NHh1vgNhRM1lXoG34uMUlXWCc6k9c/EkYlxbgSz7mz/tKZP+CwqjJQP7qL1198uVsW8IrXKMv1XHCy70dynGVk4U/f/x1NjKnnfOihsMqoJis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785822502; c=relaxed/simple; bh=/d3PPoOccTppAqw+HSu9MyodtXQXfayImUx8U+PS3lA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BvQslXsOptHWTpQSUn76gw1xOGv5P9nf5eX+ntxMlKoaCMKmqd2yiQd3Fuw4lWQYLh3oZYcNv1bsUrv3CafclwcYm7GvoGMs+WXSaspn7fXNX2tyyKFpGXJW53gH4AWCHjFyNsmpMFC4+JPrM7VpHcJgEKwyWbcP1tNO2QslSFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RWUzQRXF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kuhGcO01; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RWUzQRXF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kuhGcO01" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67417AFa2429926 for ; Tue, 4 Aug 2026 05:48:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2K0MaHfg/IVnEisBPjeiZtL1pySD+SoRMnJYDCyHZCE=; b=RWUzQRXFbG9AG5ES lvqI/Nrzb+UIKiQfsAvfyM1gYM9o2fpH8s21+7GeLvmF6rFHVnAMBZMJlw26aMOZ zGskM8+UmVKRsVQywdfv3Bc9qLvxWLLPukypDgd6mMtz0AQsFGPJwZKqyl45BVx4 3WY3aSK2Twjo2ehn7Spvxvqa0nvAUS6WRsvXHLWCiotvnCNN+igQ69aCBVtaQY+X +2OjwUUHOXDfHNee+G5Xoyef68rajnnoPoewbQ6AMOWCSeuHKx0CZ5R+MFC6fpPF iBFq0yUg+kx4VVdumdDVb7s2ChyVxwpbZPUvelo4wLeIRlq5waEQ+R7rcanOoXZ4 NOWU4A== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fty3r2mxe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 05:48:19 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-522de3c645dso85030701cf.3 for ; Mon, 03 Aug 2026 22:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785822498; x=1786427298; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2K0MaHfg/IVnEisBPjeiZtL1pySD+SoRMnJYDCyHZCE=; b=kuhGcO01r+MftGETZ/Zpw1ktVdvpSTzy7B8ycqvL49fpkG5m8UxTra+ZXbUjI6ZoWm U07xZa0VKBXygYA9f+heUpSivS+p92OSBOUx1j04gMI6M1OYk7vy2+/pfH+qSR5kh7ez 9RwNCgPGKVWR53eqj5dJgQtZ2CORQmgicx4SkPPbyIiFjBRrzzIT6R6Xygqd70Q37YZC 0hZEGLBNqvTSuHS/8HNh8doBWA0v9iLFIcYmuDKrWS4ib0KQGmSGZtiI1FEBu+cIwy+i gyZSdR8Ec35xVXnkm31/eBk8gNg0KPiDO6tf0LRrmsTjqQGas27V2cH4UTsTm18mXWXp HlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785822498; x=1786427298; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2K0MaHfg/IVnEisBPjeiZtL1pySD+SoRMnJYDCyHZCE=; b=juaxeWKRQNwq66LVJz525o6EW7k1Xek1c6VmEemRJe8p4At6weg+vrJrO6OKudA873 d+yZZ1ns7fMlxUhXM/j4LAJz9t+lmE6N8SYKiE4xEQgC/D+Uhp6hVTjRcF7HJRVZ6op7 jANHP+vEeYPadD6RYYnZEO3klcEu4KSKd/A/7ivQikE60S0MlJlrfngHRfN7UTVnpt8M HsIeqxX8ayOrFJzgFmGHueIXysb+C9I8hvlgcGQUa0LPcmsbu6O6KWx+5bz99PU0nTaS cpDzXARiTbh2ovXTiFZwf7ZoRGJAXEmRTxw916nc9x189FGHery2gE2M+kd7PfXHjFhz yRBg== X-Forwarded-Encrypted: i=1; AHgh+RoHj/ve5S4mxPBdqAoWRjEY+TIOw57/9hlrrkLq1k4lnpNpVRbEgF0aWWvhTV8TKCi68HIiZmz+XeiTW3M=@vger.kernel.org X-Gm-Message-State: AOJu0YwEcRDR/7SZE9odrJ5483CI1SuyT2RdXUp62qzRdBM8DedFwHyi yFktyw/uieKRj3LmeMBCVWKa5FAtFwifm2816koY1nNVXNeXxLAO7SSewSzKu7yzHqV9zMci40j LHL9lYLa6W68A10TQHi2PyuVkKuP+Ll9CnN8Yae4/LOePuEHvS0xhM4253YbuFpsNbFI= X-Gm-Gg: AR+sD13PPx1eQVZn3aR0k3YumVY3WVg6+26QGlFnC08jJMjGotPmlR7BDIlx12a7tfv 4BXpZWgIvWkzT1C44B3Vk6sWxUYI1F28i/Q2VocYeMPyKVKO90K5wKt3pJFwgWT+FhG6QgpsL2P UPi4z7GroXCZXzPWYoACC9CXinjoC3jYTw+Prd7k0reSXnRcT3diN4PNQg6MZvtQqmCJt1zsfgR dB0CjPiGGaElCWGYjdl9+3iWjtzOdjyMkkzLGgcFNp02uD5XoYRjdmLs7xGFi2um77AZ775oQU5 2BHLIcC3wLT/CXWLc6Qe1fCEjh8p/VgLFmJ2WCksJguQzTpwkhVSV5LsdxAOhoUcrEsRMtLm/LI JTgY0DJzFSVHHtgsE67IWmZ3ITZixtuZzXy4qmYovWYERPCO2JRELmEoTCGhXafVP0AZmKbfj X-Received: by 2002:a05:622a:1350:b0:517:96f0:5658 with SMTP id d75a77b69052e-52b566aa84bmr221542101cf.14.1785822497946; Mon, 03 Aug 2026 22:48:17 -0700 (PDT) X-Received: by 2002:a05:622a:1350:b0:517:96f0:5658 with SMTP id d75a77b69052e-52b566aa84bmr221541871cf.14.1785822497517; Mon, 03 Aug 2026 22:48:17 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c5ae9fsm647095166b.7.2026.08.03.22.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 22:48:16 -0700 (PDT) Message-ID: <31db3de6-34a2-4ccb-af61-043f56d8f86b@oss.qualcomm.com> Date: Tue, 4 Aug 2026 08:48:13 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: sm8250: Add JPEG encoder node To: Dmitry Baryshkov , Atanas Filipov Cc: linux-media@vger.kernel.org, bod@kernel.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, loic.poulain@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260730150524.2659577-1-atanas.filipov@oss.qualcomm.com> <20260730150524.2659577-4-atanas.filipov@oss.qualcomm.com> <2rtrk7tsquxekqhk7tsiomjnfzc3xfqg574cbw2m5b4ui4ovt6@2oxme5w4wsqy> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: <2rtrk7tsquxekqhk7tsiomjnfzc3xfqg574cbw2m5b4ui4ovt6@2oxme5w4wsqy> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=caPiaHDM c=1 sm=1 tr=0 ts=6a717d23 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=G2glL8InyLvFS_YR_T0A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDA0MyBTYWx0ZWRfXzAZkYVaCp9R5 xNgfflFDAQEzsvS+ZU//YrM1JC+yvONZeiND+N8XT0dklLr/6i6NDLeae8HKBvcid2eqKr3aTlD mPBi59N/DO/rbmnXiizBvqkH3yu04AM= X-Proofpoint-GUID: aZelmQMykJdDe7sCk2njvlINFOsWNn_H X-Proofpoint-ORIG-GUID: aZelmQMykJdDe7sCk2njvlINFOsWNn_H X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDA0MyBTYWx0ZWRfXwP7Dq+XMCM4x eiA6gDJU7sCxGE7vHc+ueNMfXmEZdacrwTGMSpHjafSYtsCdvoCw7tvzAvW289AmzcZU1+rRLpC 0MOHPAKVFfO/DO+FAQ+GzexdkwC0acwO/qEGJDKpLHQpY6PTwXhRSLBLY7VrMQ2RfOvI5qQRJUh ChqyCEwc7WBf5OX78VHGYuRJVknWskxIzNK/Xo8BOEqYXiaXhvRflcqAkW3DQGSJivzVXC2IyhU kdHpX3HRYkMIoFRmC4sebFTkYs/ZWWyVXnVCts6mhwLHQrSahBx1y2+WOQWUIfhjX72vVaia0Ph dbqBm8RKbgZX0PVAlGnhCTB8fO0W84qVpmACGVQ/N6Ey1mMwlbSKsY/hWzDCipYWSOlfwrvGpmQ 6XaViXHn7d1R1lLn16QPDTBaXs6vn0pOdqQWMhhw5on5T5w5O7Ya8uUSZNR+92Vjn0gGB43NeQn GfRFNewpTkeNp6sBEnQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_01,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040043 Hi Dmitry, On 8/3/2026 9:44 PM, Dmitry Baryshkov wrote: > On Thu, Jul 30, 2026 at 09:02:26PM +0300, Atanas Filipov wrote: >> On 7/30/2026 7:01 PM, Dmitry Baryshkov wrote: >>> On Thu, Jul 30, 2026 at 06:05:24PM +0300, Atanas Filipov wrote: >>>> Add the JPEG encoder hardware node to the SM8250 device tree so the >>>> qcom-jpeg V4L2 encoder driver can bind and operate on this platform. >>>> >>>> Signed-off-by: Atanas Filipov >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 72 ++++++++++++++++++++++++++++ >>>> 1 file changed, 72 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>>> index f11da2ca4181..d42b29419320 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi >>>> @@ -13,6 +13,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> @@ -4486,6 +4487,77 @@ cci1_i2c1: i2c-bus@1 { >>>> }; >>>> }; >>>> + jpeg-encoder@ac53000 { >>>> + compatible = "qcom,sm8250-jpeg-enc"; >>>> + status = "disabled"; >>>> + >>>> + reg = <0x0 0x0ac53000 0x0 0x1000>; >>>> + >>>> + interrupts = ; >>>> + >>>> + power-domains = <&camcc TITAN_TOP_GDSC>, >>>> + <&rpmhpd RPMHPD_MMCX>, >>> >>> Is TITAN_TOP a part of the MMCX or CX domain? In the former case, >>> please drop separate mmcx vote here and let it come through the >>> titan_top (it might require camcc driver and node modifications). >>> >> >> The change was requested by Brian, most likely in connection with upcoming >> migrations. I think he would be able to explain the exact reasons. As far as >> the facts are concerned, this is not currently necessary for the driver to >> be functional. > > There is no word _driver_ in the _dt bindings_. What is the actual > hardware wrapping? What is being powered by which domain? Is MMCX > directly powering something? Or is it gated by TITAN_TOP_GDSC? I assume > that MX is powering on PLLs, correct? Yes i agree there is no word driver in the dt_bindings but you get my point, with only TITAN_TOP_GDSC hw is fully functional there is no need of additional MMCX power domain. > >>>> + >>>> + opp-100000000 { >>>> + opp-hz = /bits/ 64 <400000000>, >>>> + /bits/ 64 <100000000>; >>>> + required-opps = <&rpmhpd_opp_min_svs>; >>> >>> This looks a bit strange. Are you sure that PLL levels match the MMCX / >>> internal clock levels? I think you need to vote on both domains. > > This is not addressed / responded. Yes this need to be checked. I will get back when we get info for this... Regards, ~Gjorgji