mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Zhao Li <enderaoelyther@gmail.com>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Eric Woudstra" <ericwouds@gmail.com>,
	"Bjørn Mork" <bjorn@mork.no>,
	"Lucien . Jheng" <lucienzx159@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net] net: phy: air_en8811h: check PBUS register read errors
Date: Wed, 18 Nov 2026 19:43:55 +0100	[thread overview]
Message-ID: <31de7b62-098a-425a-bf0e-38064b3a42d3@lunn.ch> (raw)
In-Reply-To: <20261118182436.32455-1-enderaoelyther@gmail.com>

On Thu, Nov 19, 2026 at 02:24:36AM +0800, Zhao Li wrote:
> an8811hb_check_crc() ignores the return value of its PBUS reads. When
> the status read fails, the loop tests a stale or uninitialized
> pbus_value and can stop waiting before the check has finished. When the
> result read fails, the PASS or FAIL message tests the status value.
> 
> en8811h_print_fw_version() also ignores a failed read, which leaves
> priv->firmware_version at 0 on the first firmware load.
> en8811h_read_status() then handles it as firmware older than 24011202
> and guesses the link partner's 2.5GBASE-T ability from the link speed.
> 
> Return the error from each of these reads. A failed version read now
> fails the firmware load or the probe, as the other PBUS errors there
> do.
> 
> Found by an AI code review agent; not triggered. Compile-tested with W=1.
> 
> Fixes: 71e79430117d ("net: phy: air_en8811h: Add the Airoha EN8811H PHY driver")
> Fixes: 5afda1d734ed ("net: phy: air_en8811h: add Airoha AN8811HB support")
> Cc: stable@vger.kernel.org # needs adjustments for <= 7.1

Does this bother anybody?

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

MDIO pretty much never returns an error.

Please repost for net-next.

    Andrew

---
pw-bot: cr

      reply	other threads:[~2026-11-18 18:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:24 Zhao Li
2026-11-18 18:43 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31de7b62-098a-425a-bf0e-38064b3a42d3@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=enderaoelyther@gmail.com \
    --cc=ericwouds@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lucienzx159@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®