From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 391F1386C01 for ; Wed, 4 Mar 2026 11:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624644; cv=none; b=rzNMvE6Y16kDZEKEDXsIfXu4tk97sGblaNtjby2ZarBeEP7tEuxi3BR8lIfTgxuS2DLJavx4dSGiHEdLAeCUzInrJG87h3ahCSE4uum6/6WcjM61h4/TYRwlEAluX6MAkfWhOAvySYZ1E+OK+w4zWFKCDDqv8l3vqdYkCSfW10A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624644; c=relaxed/simple; bh=xzsn6k2b/PVPth62pltSdIi+Q9LNbG6H/NU4wHnKMsY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=VtwkH30XYjPuOR3Ky1qn79y6w7MtTqV1+p2sck2PXk5itFCBscq0ZRZWi+XqWkjNWck+2ux094p5nu3oEVyjt5DlaWwxYS9tUokXY8t+4e6vQenFjkGMsD+l26AWszTEsYJxdWezPKvanjWtEOVNgYhQEtBbG9LVtN5MCMaX/LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JjHPwwGB; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JjHPwwGB" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-439b8a3f2bcso2512238f8f.3 for ; Wed, 04 Mar 2026 03:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772624641; x=1773229441; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=aakhmee/raU7jdKZ9tPN3MemCiopLrjwJ8yjHuKYiX4=; b=JjHPwwGBMnMSo3dY3gjWpZBoElU8eS0vkwrnKIIEPLtL9V3UljCZL1IT+pbmIJ5ezf nN7JGMxsU1lkgUIO1Y98zE9d0dOTakGTihPNVRCHte/KNrKO4z9Zu6FLYP963MxAffZr +XvSfUNYFZrePOJrTK5ywPj6yV6LbYyxn4mYR0Z/bqtZJ+k6T3GyLMfGgLMx/cLzEkUg y0DIHxnVeZ7zrpt6uPCVCg8cZ8s5LjB6PYuVMKE3RnwDaXgMP89cfKWpHrIe+b0dz9W1 8f6S/3PCWz+i1xkxD45ML7gxd1HFCTMoSZS0PQUJmup4YXpt5j2DSM082ZBuoIxl7vj3 VpbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772624641; x=1773229441; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aakhmee/raU7jdKZ9tPN3MemCiopLrjwJ8yjHuKYiX4=; b=daaMaQv9I3cO//E6zzcHzMNAwfc/qZvo8mFRfaEKrwaLarLz5QibyNzzeYLQfoS1rd ma+jqdmZLTHvyOqfNlS2iqUqJ4ePcDfPrFIzU2wQOmJxBzGjBNKBztUNtGknTc94CF+7 Jbewd8j/SVe+l4a4rkild0bpxT+t2osx3cG1TmkcKwG0CdHMXlQlr3YbeD54KCSItZWZ vla/GPUM/jsdK19f1dkUxHK4RZnuivT2+T1KiR2r7IbGT88HdSxTtEfXIymKxdA8tT1q nOqEBSu5MBp55TSLXEDAP6K8cMRcfcwHZznttwA6ABL+rg6rsBqfAL36YN9dkHAJjEE0 0goQ== X-Forwarded-Encrypted: i=1; AJvYcCVnFcAPnnAkAe6hnTpC3bA0fD/w0DxJZK66MQCMUp1w6K20392nJheqjieqpl6Sh6r8SPF+tFmJYKTITuM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk0HOVCUD079gX7rs6YwYcLBQnDx/3rDCQqt1zWrX+V71dkvrN 1BhidDrZck2RdFRasjmHZ/OHGLN1vBd/vFDmyg3ujsKlwUdGBPF3Gfqn X-Gm-Gg: ATEYQzz1J3lq6JdMtLKA66yuRihEqS1BfEZkHWLFJ0KxRTcpCw22TV+6Uvjy9DXdPXT qTKPTP8Jn76N6OT3YxQuwcyWNxihLcOWquvnMj7Qs7AZxcIF1xIJiRBMKE648e4jgzo5h5t0a6H l3y8I16a/ALBSP8Hd5qlzJdHFSTnBiJxvKcPBTAFdK7Wh7JESdpEMB9ZhvKJrTWnuklLxdgE+lA RRLCM5b2gl31abbt/bf7fwC7bzUYWvr6dJZZ4nXaWn9cjgpmqGc4w3Grctsu8Kg0MLBeTLCkFBX fp/08hZRDyqFYON3xjmKSfGU2lNx69Er+sYYOaedabRHT6gbi+pYAjvNC1K34vMFcIx5s6o1e2b A1TmF0ddbAkxeqgu1xUa4cs8PmqjvlN47qlsnfsLddxaMJ6sGA0ev4GHVZq+mQYUwIa9X2aga8P gT81+Yn5TjHv1RGdgIVODuGQWpqMS2s6w= X-Received: by 2002:a05:6000:4381:b0:439:b3d2:376c with SMTP id ffacd0b85a97d-439c7f8f93emr3259733f8f.12.1772624641267; Wed, 04 Mar 2026 03:44:01 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b03db76bsm27413229f8f.18.2026.03.04.03.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 03:44:00 -0800 (PST) Message-ID: <31e0d644f251ae29063ef5575fcb851034ab6fd5.camel@gmail.com> Subject: Re: [PATCH] iio: adc: at91-sama5d2_adc: no devm for nvmem_cell_get From: Nuno =?ISO-8859-1?Q?S=E1?= To: Rosen Penev , linux-iio@vger.kernel.org Cc: Eugen Hristev , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , "moderated list:ARM/Microchip (AT91) SoC support" , open list Date: Wed, 04 Mar 2026 11:44:45 +0000 In-Reply-To: <20260304041843.7709-1-rosenp@gmail.com> References: <20260304041843.7709-1-rosenp@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-03-03 at 20:18 -0800, Rosen Penev wrote: > There is absolutely no reason to pospone cleanup of this post driver > removal. Just do it immediately. >=20 > Signed-off-by: Rosen Penev > --- I guess we do not have that many users for nvmem_cell_get(), otherwise a ne= w __free(nvmem_cell) could make sense. Anyways not related: Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/iio/adc/at91-sama5d2_adc.c | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sa= ma5d2_adc.c > index 69bb49434f90..255970b2e747 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -2259,7 +2259,7 @@ static int at91_adc_temp_sensor_init(struct at91_ad= c_state *st, > =C2=A0 return 0; > =C2=A0 > =C2=A0 /* Get the calibration data from NVMEM. */ > - temp_calib =3D devm_nvmem_cell_get(dev, "temperature_calib"); > + temp_calib =3D nvmem_cell_get(dev, "temperature_calib"); > =C2=A0 if (IS_ERR(temp_calib)) { > =C2=A0 ret =3D PTR_ERR(temp_calib); > =C2=A0 if (ret !=3D -ENOENT) > @@ -2268,6 +2268,7 @@ static int at91_adc_temp_sensor_init(struct at91_ad= c_state *st, > =C2=A0 } > =C2=A0 > =C2=A0 buf =3D nvmem_cell_read(temp_calib, &len); > + nvmem_cell_put(temp_calib); > =C2=A0 if (IS_ERR(buf)) { > =C2=A0 dev_err(dev, "Failed to read calibration data!\n"); > =C2=A0 return PTR_ERR(buf);