From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pierre Ossman <pierre-list@ossman.eu>
Subject: Re: [PATCH 2/2] cpufreq: don't call cpufreq_update_policy() on CPU addition
Date: Mon, 17 Feb 2014 23:22:07 +0100 [thread overview]
Message-ID: <3201988.ZpLiSN5z6s@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpo=57bYHsx+m5wevuB0_4fhTK813T5TXnUYZh64gQ1YdWA@mail.gmail.com>
On Monday, February 17, 2014 10:45:41 AM Viresh Kumar wrote:
> On 17 February 2014 05:51, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Friday, February 14, 2014 04:30:41 PM Viresh Kumar wrote:
> >> cpufreq_update_policy() is called from two places currently. From a workqueue
> >> handled queued from cpufreq_bp_resume() for boot CPU and from
> >> cpufreq_cpu_callback() whenever a CPU is added.
> >>
> >> The first one makes sure that boot CPU is running on the frequency present in
> >> policy->cpu. But we don't really need a call from cpufreq_cpu_callback(),
> >> because we always call cpufreq_driver->init() (which will set policy->cur
> >> correctly) whenever first CPU of any policy is added back. And so every policy
> >> structure is guaranteed to have the right frequency in policy->cur.
> >
> > That sounds good, but doing the extra cpufreq_update_policy() shouldn't actually
> > hurt, should it?
>
> Yeah, it shouldn't hurt badly..
>
> > So, that would be a cleanup rather than a fix, right?
>
> Hmm, yeah..
I've queued this up for 3.15, then. Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-02-17 22:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 11:00 [PATCH 1/2] cpufreq: Return error if ->get() failed in cpufreq_update_policy() Viresh Kumar
2014-02-14 11:00 ` [PATCH 2/2] cpufreq: don't call cpufreq_update_policy() on CPU addition Viresh Kumar
2014-02-17 0:21 ` Rafael J. Wysocki
2014-02-17 5:15 ` Viresh Kumar
2014-02-17 22:22 ` Rafael J. Wysocki [this message]
2014-02-17 8:43 ` Srivatsa S. Bhat
2014-02-17 8:54 ` Viresh Kumar
2014-02-17 8:59 ` Srivatsa S. Bhat
2014-02-17 0:28 ` [PATCH 1/2] cpufreq: Return error if ->get() failed in cpufreq_update_policy() Rafael J. Wysocki
2014-02-17 5:14 ` Viresh Kumar
2014-02-17 8:19 ` Srivatsa S. Bhat
2014-02-17 8:39 ` Viresh Kumar
2014-02-17 8:55 ` Srivatsa S. Bhat
2014-02-17 9:10 ` Viresh Kumar
2014-02-17 22:00 ` Rafael J. Wysocki
2014-02-18 2:19 ` Viresh Kumar
2014-02-25 4:41 ` Viresh Kumar
2014-02-25 5:53 ` Srivatsa S. Bhat
2014-02-25 6:08 ` Viresh Kumar
2014-02-25 13:10 ` Rafael J. Wysocki
2014-02-25 14:42 ` Viresh Kumar
2014-02-25 22:29 ` Rafael J. Wysocki
2014-02-26 5:15 ` Viresh Kumar
2014-03-10 5:37 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3201988.ZpLiSN5z6s@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pierre-list@ossman.eu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®